[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-12-19 05:54:52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 --- Comment #4 from Daniel Bruno dbr...@fedoraproject.org --- Follow the files fixed. Spec URL: http://dbruno.fedorapeople.org/python-elasticsearch/python-elasticsearch.spec SRPM URL: http://dbruno.fedorapeople.org/python-elasticsearch/python-elasticsearch-0.4.3-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Christopher Meng cicku...@gmail.com --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 Daniel Bruno dbr...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Daniel Bruno dbr...@fedoraproject.org --- New Package SCM Request === Package Name: python-elasticsearch Short Description: Client for Elasticsearch Owners: dbruno Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 --- Comment #2 from Daniel Bruno dbr...@fedoraproject.org --- The fixed spec and src. Spec URL: http://dbruno.fedorapeople.org/python-elasticsearch/python-elasticsearch.spec SRPM URL: http://dbruno.fedorapeople.org/python-elasticsearch/python-elasticsearch-0.4.3-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943
--- Comment #3 from Christopher Meng cicku...@gmail.com ---
Please remove this:
rm -rf %{buildroot}
EPEL6 doesn't need this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||cicku...@gmail.com
Assignee|nob...@fedoraproject.org|cicku...@gmail.com
Flags||fedora-review?
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 23 files have unknown license. Detailed output of
licensecheck in:
Unknown or generated
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/docs/conf.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/client/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/client/cluster.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/client/indices.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/client/utils.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/base.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/esthrift/Rest.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/esthrift/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/esthrift/constants.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/esthrift/ttypes.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/http_requests.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/http_urllib3.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/memcached.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/pooling.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection/thrift.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/connection_pool.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/exceptions.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/helpers.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/serializer.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/elasticsearch/transport.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/elasticsearch-0.4.3/setup.py
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
-- Please fix.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to
