[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Michael Simacek changed: What|Removed |Added Blocks||1030874 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1030874 [Bug 1030874] jetty-9.1.0.v20131115 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Michal Srb changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803
--- Comment #1 from Michal Srb ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 89 files have unknown license.
Detailed output of licensecheck in /home/msrb/review/1035803-jetty-
schemas/licensecheck.txt
license text for ASL 2.0 and EPL 1.0 is present in tarball:
jetty-distribution-remote-resources/src/main/resources/license-eplv10-aslv20.html
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of or
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 --- Comment #2 from Michael Simacek --- Changed License to "CDDL or GPLv2 with exceptions" http://msimacek.fedorapeople.org/jetty-schemas.spec http://msimacek.fedorapeople.org/jetty-schemas-3.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Michal Srb changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Michal Srb --- The packages looks good now. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 --- Comment #4 from Michael Simacek --- New Package SCM Request === Package Name: jetty-schemas Short Description: XML schemas for Jetty Owners: msimacek Branches: f20 InitialCC: java-sig msrb sochotni mizdebsk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Michael Simacek changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 --- Comment #6 from Fedora Update System --- jetty-schemas-3.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/jetty-schemas-3.1-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- jetty-schemas-3.1-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035803] Review Request: jetty-schemas - XML Schemas for Jetty
https://bugzilla.redhat.com/show_bug.cgi?id=1035803 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jetty-schemas-3.1-2.fc20 Resolution|--- |ERRATA Last Closed||2013-12-20 21:07:56 --- Comment #8 from Fedora Update System --- jetty-schemas-3.1-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
