[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Petr Vobornik changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Petr Vobornik changed: What|Removed |Added Depends On||1036754 --- Comment #1 from Petr Vobornik --- I've replaced the usage of custom font forge script which sets the embeddable to installable by ttembed tool. ttembed is cleaner solution since it doesn't regenerate the whole font file and can be also used by other font packages. Spec and SRPM were updated. ttembed package is currently under review: bug 1036754 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1036754 [Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 T.C. Hollingsworth changed: What|Removed |Added CC||tchollingswo...@gmail.com Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #2 from T.C. Hollingsworth --- Will be sponsored pending review of bug 1036754. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Bug 1035897 depends on bug 1036754, which changed state. Bug 1036754 Summary: Review Request: ttembed - Remove embedding limitations from TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=1036754 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897
Nathaniel McCallum changed:
What|Removed |Added
CC||npmccal...@redhat.com
--- Comment #3 from Nathaniel McCallum ---
+:ok, =:needs attention, -:needs fixing
MUST Items:
[+] MUST: rpmlint must be run on every package.
open-sans-fonts.src: W: strange-permission getopensans.sh 0755L
open-sans-fonts.src: W: invalid-url Source0: open-sans-fonts-1.10.tar.xz
open-sans-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/open-sans-fonts/LICENSE.txt
These warnings are all fine given the difficulty of finding a proper source
URL.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[=] MUST: The package must meet the Packaging Guidelines.
I *think* this needs to go in the fonts group.
See: https://fedoraproject.org/wiki/Packaging:FontsPolicy#Grouping
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
This doesn't apply given that we are generating the source package.
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[+] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: Usually, subpackages other
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Nathaniel McCallum changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Nathaniel McCallum --- Conditionally approved pending clarification on the groups requirement. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #5 from Petr Vobornik --- I will add it to 'fonts' group after publishing the package according to step 3a in https://fedoraproject.org/wiki/Font_package_lifecycle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #6 from Parag AN(पराग) --- Nathaniel, That comps addition happens when packages are built and available in koji. So that is not a blocker for this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Nathaniel McCallum changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #7 from Nathaniel McCallum --- I'm not able to set fedora-review to '+' for some reason. I'm guessing because I'm not in the sponsors group. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Nathaniel McCallum changed: What|Removed |Added Assignee|nob...@fedoraproject.org|npmccal...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #8 from Parag AN(पराग) --- Is your fas id npmccallum? if yes I see its connected with other email id. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #9 from Nathaniel McCallum --- Yes, it is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Nathaniel McCallum changed: What|Removed |Added CC||nathan...@natemccallum.com Assignee|npmccal...@redhat.com |nathan...@natemccallum.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Nathaniel McCallum changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Petr Vobornik changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Petr Vobornik --- New Package SCM Request === Package Name: open-sans-fonts Short Description: Open Sans is a humanist sans-serif typeface designed by Steve Matteson Owners: pvoborni Branches: f19 f20 InitialCC:fonts-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #12 from Fedora Update System --- open-sans-fonts-1.10-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/open-sans-fonts-1.10-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 --- Comment #13 from Fedora Update System --- open-sans-fonts-1.10-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/open-sans-fonts-1.10-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- open-sans-fonts-1.10-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||open-sans-fonts-1.10-1.fc20 Resolution|--- |ERRATA Last Closed||2014-01-23 06:05:30 --- Comment #15 from Fedora Update System --- open-sans-fonts-1.10-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=1035897 Fedora Update System changed: What|Removed |Added Fixed In Version|open-sans-fonts-1.10-1.fc20 |open-sans-fonts-1.10-1.fc19 --- Comment #16 from Fedora Update System --- open-sans-fonts-1.10-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
