[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-03-14 15:39:12 --- Comment #47 from Fedora Update System --- plv8-2.1.0-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Bug 1036130 depends on bug 1517657, which changed state. Bug 1517657 Summary: Missing libv8_libplatform.so and libv8_libbase.so in v8-devel https://bugzilla.redhat.com/show_bug.cgi?id=1517657 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #46 from Fedora Update System --- plv8-2.1.0-5.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-18be6c0e07 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added Status|POST|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added Status|MODIFIED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #45 from Fedora Update System --- plv8-2.1.0-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-18be6c0e07 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added Status|POST|MODIFIED --- Comment #44 from Pavel Raiskup --- https://koji.fedoraproject.org/koji/taskinfo?taskID=23792623 https://koji.fedoraproject.org/koji/taskinfo?taskID=23792614 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #43 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plv8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #42 from Pavel Raiskup --- $ fedrepo-req -t 1036130 plv8 master https://pagure.io/releng/fedora-scm-requests/issue/3602 $ fedrepo-req-branch plv8 f27 https://pagure.io/releng/fedora-scm-requests/issue/3603 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #41 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #40 from Pavel Raiskup --- Spec URL: https://raw.githubusercontent.com/praiskup/plv8-pkg/master/plv8.spec SRPM URL: https://praiskup.fedorapeople.org/plv8-2.1.0-5.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #39 from Pavel Raiskup --- Robert, I can only disagree (but I'll update, I'm glad that you go through the review). As a provenpackager, I basically shouldn't touch patches and if, I should really know what am I doing. Opening the patch itself is really trivial and natural habit. IOW, I really dislike duplicating the info given by (a) patch name, (b) git format-patch output and link pointing to upstream discussion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #38 from Robert-André Mauchin --- Please add a comment for the patches *in the SPEC*. The goal is to inform someone reading the SPEC, a proven packager needing to intervene on your package for example, what the patches do without needing to go look at the patches file themselves. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #37 from Pavel Raiskup --- (In reply to Robert-André Mauchin from comment #36) > - Add a comment for each patch explaining what they do Done inside the patch, but I added comment on top of "patch" section about this fact; and I've split the 'patch0' into two patches (with better naming, and per-issue purpose). > - Group: is not needed in Fedora. See: > https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections Removed. > - Use a more meaningful name for your archive, with the following Source0: > > Source0: > https://github.com/%{sname}/%{sname}/archive/v%{version}/%{name}-%{version}. > tar.gz Done, I didn't know this trick! Thank you. Spec URL: https://raw.githubusercontent.com/praiskup/plv8-pkg/master/plv8.spec SRPM URL: https://praiskup.fedorapeople.org/plv8-2.1.0-4.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #36 from Robert-André Mauchin --- - Add a comment for each patch explaining what they do - Group: is not needed in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - Use a more meaningful name for your archive, with the following Source0: Source0: https://github.com/%{sname}/%{sname}/archive/v%{version}/%{name}-%{version}.tar.gz Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "PostgreSQL", "Unknown or generated". 62 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/plv8/review-plv8/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/pgsql/extension(orafce, postgresql-server) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query u
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #35 from Pavel Raiskup --- Just to make it clear -- this should be basically ready for review as the #1517657 is worked-around. Spec URL: https://raw.githubusercontent.com/praiskup/plv8-pkg/master/plv8.spec SRPM URL: https://praiskup.fedorapeople.org/plv8-2.1.0-3.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #34 from Pavel Raiskup --- Spec URL: https://raw.githubusercontent.com/praiskup/plv8-pkg/master/plv8.spec SRPM URL: https://praiskup.fedorapeople.org/plv8-2.1.0-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added Depends On||1517657 --- Comment #33 from Pavel Raiskup --- Thanks for pre-review, fixes applied. But linking issues are there, as expected: postgres=# create extension plv8; ERROR: could not load library "/usr/lib64/pgsql/plv8.so": /usr/lib64/pgsql/plv8.so: undefined symbol: _ZN2v88platform21CreateDefaultPlatformEiNS0_15IdleTaskSupportENS0_21InProcessStackDumpingEPNS_17TracingControllerE We need to wait for v8-devel fix (blocking bug). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1517657 [Bug 1517657] Missing libv8_libplatform.so and libv8_libbase.so in v8-devel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #32 from Robert-André Mauchin --- Not a review, but: - Not needed: %defattr(-,root,root) - make %{?_smp_mflags} → %make_build - make install DESTDIR=%{buildroot} %{?_smp_mflags} → %make_install - Not used anymore: Group:Applications/Databases -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #31 from Pavel Raiskup --- I started from bug 1274417 (where pkajaba ended, inspired by pgrpms, thanks!): https://github.com/praiskup/plv8-pkg/blob/master/plv8.spec Build is on [1], but I doubt it works (linking issues expected [2]). I'll have a closer look soon. %v8_arches requested on [3]. [1] https://koji.fedoraproject.org/koji/taskinfo?taskID=23714224 [2] https://github.com/plv8/plv8/pull/247#partial-pull-merging [3] https://bugzilla.redhat.com/1526522 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #30 from Devrim GÜNDÜZ --- Hi, I think the community spec file is in a good shape, and can be adjusted for Fedora pretty easily: https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/plv8/master/plv8.spec;h=5802e15d9966f7c051d4bc976a22d7da351ec225;hb=HEAD Regards, Devrim -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added Status|ASSIGNED|NEW Blocks|177841 (FE-NEEDSPONSOR) | Assignee|pkaj...@redhat.com |nob...@fedoraproject.org --- Comment #29 from Pavel Raiskup --- (In reply to John Griffiths from comment #28) > Any progress one this? I think upstream moved forward a bit. Pavel Kajaba is not in team anymore, so let's find some other maintainer. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #28 from John Griffiths --- Any progress one this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #27 from Pavel Kajaba --- I tried to work a bit on plv8 yesterday. However there is problem since latest released version supports just v8 up to version 4.10 and in rawhide there is something like 5.*. Current master branch supports latest v8, but it's just in development since they have lot of issues to solve [1]. I have contacted upstream [2]. Is there anyone who could help with JavaScript? I will try to help them, but I have just basic knowledge of JS. [1] https://github.com/plv8/plv8/issues?q=is%3Aopen+is%3Aissue+milestone%3A%222.0+Release%22 [2] https://github.com/plv8/plv8/issues/178 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #26 from Pavel Kajaba --- Sure, I will fire new bug today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added Flags|needinfo?(mikko.tiihonen@ik | |i.fi) | |needinfo?(mikko.tiihonen@ik | |i.fi) | --- Comment #25 from Pavel Raiskup --- (In reply to John Griffiths from comment #24) > There is a package on the Postgre site for plv8, > http://yum.postgresql.org/9.4/fedora/fedora-22-x86_64/plv8_94-1.4.4-1.f22. > x86_64.rpm > That rpm will not install against the Fedora 22 Postgre. There are some > naming mismatches I think. Right, RPMs on yum.postgresql.org are self-standing, those are usually built against PostgreSQL server from yum.postgresql.org, too. Well, with respect to original reporter - we wanted a wait a bit. Maybe it is the right time to take it over. Pavel, are you OK to re-start the review process (starting probably wit plv8 from PGRPMS spec file, I bet the spec license is compatible as usually - we should CC Devrim) and submit a new Review bug? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #24 from John Griffiths --- There is a package on the Postgre site for plv8, http://yum.postgresql.org/9.4/fedora/fedora-22-x86_64/plv8_94-1.4.4-1.f22.x86_64.rpm That rpm will not install against the Fedora 22 Postgre. There are some naming mismatches I think. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #23 from John Griffiths --- What is going on with this package? xTuple has new versions that will not run against postgre in Fedora 22 since postgre does not have plv8. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Kajaba changed: What|Removed |Added Flags||needinfo?(mikko.tiihonen@ik ||i.fi) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #22 from Pavel Kajaba --- Hello, do you want to complete this review? We would like to get this package into Fedora so we would complete it. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added CC||mikko.tiiho...@iki.fi Flags||needinfo?(mikko.tiihonen@ik ||i.fi) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|pkaj...@redhat.com --- Comment #21 from Pavel Raiskup --- I agree, we basically need the format as you've done in comment #16, but the links need to point directly to files, not to "download page". That way you allow automatic 'fedora-review --bug 1036130 -m fedora-rawhide-x86_64' command to succeed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Mikko Tiihonen changed: What|Removed |Added Attachment #837220|0 |1 is obsolete|| Pavel Kajaba changed: What|Removed |Added CC||pkaj...@redhat.com --- Comment #20 from Pavel Kajaba --- Please don't attach packages in bugzilla. Request fedorapeople.org web space if you don't have any other public place where to share the rpms. That's step 2.1.11 here: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers Would you kindly reupload it somewhere else ? Thanks :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #19 from Mikko Tiihonen --- Created attachment 1094959 --> https://bugzilla.redhat.com/attachment.cgi?id=1094959&action=edit Proposed plv8.spec file against plv8 1.4.4 version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #18 from Pavel Raiskup --- Mikko, I tried: $ fedora-review -b 1036130 -m fedora-rawhide-x86_64 INFO: Processing bugzilla bug: 1036130 INFO: Getting .spec and .srpm Urls from : 1036130 INFO: --> SRPM url: https://www.dropbox.com/s/ehbxasatvkcqe3f/plv8-1.4.1-1.fc21.src.rpm INFO: --> Spec url: https://www.dropbox.com/s/9cezsd32j7ppj5q/plv8.spec INFO: Using review directory: /home/praiskup/rh/packages/plv8/review/1036130-plv8 INFO: Downloading .spec and .srpm files error: line 1: Unknown tag: http://ogp.me/ns/fb#"; xml:lang="en" class="media-desktop" xmlns="http://www.w3.org/1999/xhtml";>
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Pavel Raiskup changed: What|Removed |Added CC||fedora.jr...@grifent.com --- Comment #17 from Pavel Raiskup --- *** Bug 1274417 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 --- Comment #16 from Mikko Tiihonen --- Spec URL: https://www.dropbox.com/s/9cezsd32j7ppj5q/plv8.spec SRPM URL: https://www.dropbox.com/s/ehbxasatvkcqe3f/plv8-1.4.1-1.fc21.src.rpm Fedora Account System Username: gmokki The postgresql-plv8 is not an allowed name, so the package will be kept as plv8 (to match upstream). Since last report: 1) I got myself a fedora account and did all required steps (ssh key etc) 2) Removed the smp_flags from the make install 3) Did a scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=6692068 4) verified that the correct(?) fedora ld flags are passed to the final .so link command. See: http://kojipkgs.fedoraproject.org//work/tasks/2070/6692070/build.log which shows the following parameters: g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -DLINUX_OOM_SCORE_ADJ=0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fpic -shared -o plv8.so plv8.o plv8_type.o plv8_func.o plv8_param.o coffee-script.o livescript.o -L/usr/lib64 -Wl,-z,relro -Wl,--as-needed -lv8 I think that by including the /usr/lib64/pgsql/pgxs/src/makefiles/pgxs.mk from the postgresql-devel package the Makefile gets correct linking parameters. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036130] Review request: plv8 - javascript language extension for postgresql
https://bugzilla.redhat.com/show_bug.cgi?id=1036130 Mikko Tiihonen changed: What|Removed |Added Summary|New package plv8 - |Review request: plv8 - |javascript language |javascript language |extension for postgresql|extension for postgresql -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review