[Bug 1036297] Review Request: libturpial - library needed to new turpial (twitter client) version
https://bugzilla.redhat.com/show_bug.cgi?id=1036297
--- Comment #5 from Edwind Richzendy Contreras Soto richze...@gmail.com ---
(In reply to Eduardo Echeverria from comment #3)
Hi @Edwin
- rename the package to turpial-libturpial or python-libturpial.
Done!
- Remove all el5 stuff (buildroot_tag, %clean, rm -rf after %install.
Done!
- Add python2-devel or python3-devel as the case may, as BR
Done!
- The unversioned macro, %{__python} is deprecated. You should use
%{__python2}
Done!
- use %build section (You has moved python build in install section, why?)
if i use %build section, and move:
sed -i 's/\.\//share\/doc\/%{name}/' setup.py
%{__python2} setup.py build
%{__python2} setup.py install --root %{buildroot}
From install section to build section, the rpmbuild fail
- Change the permissions of the directories and files that are wrong. Do
that in %install section preferably (Don't use %attr for that, neither
%defattr)
If i use:
{__chmod} 644 -R %{_buildroot}/doc/%{name}/*
In the %install section, rpmbuild fails
- Since F20 doc are unversioned please see
http://fedoraproject.org/wiki/Changes/UnversionedDocdirs.
- Your package generates unowned directories in the documentation because
you hasn't marked them as %doc
Done!
- certs shouldn't go in that place, maybe /etc/pki/$name ?
I need patch the source code to make this, because the path to this cert file
appears in one source file (lib/http.py) and one binary file (lib/http.pyo),
it's fine do it?
Spec URL: http://repo.richzendy.org/turpial/python-libturpial.spec
SRPM URL:
http://repo.richzendy.org/turpial/python-libturpial-1.0-2.fc19.src.rpm
RPM URL:
http://repo.richzendy.org/turpial/python-libturpial-1.0-2.fc19.noarch.rpm
#rpmlint rpmbuild/SRPMS/python-libturpial-1.0-2.fc19.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
#rpmlint rpmbuild/RPMS/noarch/python-libturpial-1.0-2.fc19.noarch.rpm
python-libturpial.noarch: W: pem-certificate
/usr/lib/python2.7/site-packages/libturpial/certs/cacert.pem
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Thank you for your time
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036297] Review Request: libturpial - library needed to new turpial (twitter client) version
https://bugzilla.redhat.com/show_bug.cgi?id=1036297 --- Comment #4 from Michael Schwendt bugs.mich...@gmx.net --- rename the package to turpial-libturpial or python-libturpial python-libturpial is the right choice -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036297] Review Request: libturpial - library needed to new turpial (twitter client) version
https://bugzilla.redhat.com/show_bug.cgi?id=1036297 --- Comment #1 from Michael Schwendt bugs.mich...@gmx.net --- Skimming over the spec file, this is surprisingly mispackaged. :-( Please try to review your own package with the help of the Package Review Guidelines ( https://fedoraproject.org/wiki/Packaging:ReviewGuidelines ) and rpmlint and/or the fedora-review tool. https://fedoraproject.org/wiki/Packaging:NamingGuidelines https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions https://fedoraproject.org/wiki/Packaging:UnownedDirectories -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036297] Review Request: libturpial - library needed to new turpial (twitter client) version
https://bugzilla.redhat.com/show_bug.cgi?id=1036297 --- Comment #2 from Edwind Richzendy Contreras Soto richze...@gmail.com --- rpmlint rpmbuild/SRPMS/libturpial-1.0-1.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint rpmbuild/RPMS/noarch/libturpial-1.0-1.fc19.noarch.rpm libturpial.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/libturpial/certs/cacert.pem 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036297] Review Request: libturpial - library needed to new turpial (twitter client) version
https://bugzilla.redhat.com/show_bug.cgi?id=1036297
Eduardo Echeverria echevemas...@gmail.com changed:
What|Removed |Added
CC||echevemas...@gmail.com
--- Comment #3 from Eduardo Echeverria echevemas...@gmail.com ---
Hi @Edwin
- rename the package to turpial-libturpial or python-libturpial.
- Remove all el5 stuff (buildroot_tag, %clean, rm -rf after %install.
- Add python2-devel or python3-devel as the case may, as BR
- The unversioned macro, %{__python} is deprecated. You should use %{__python2}
- use %build section (You has moved python build in install section, why?)
- Change the permissions of the directories and files that are wrong. Do that
in %install section preferably (Don't use %attr for that, neither %defattr)
- Since F20 doc are unversioned please see
http://fedoraproject.org/wiki/Changes/UnversionedDocdirs.
- Your package generates unowned directories in the documentation because you
hasn't marked them as %doc
- certs shouldn't go in that place, maybe /etc/pki/$name ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
