[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl
https://bugzilla.redhat.com/show_bug.cgi?id=1036319 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-01-09 03:56:55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl
https://bugzilla.redhat.com/show_bug.cgi?id=1036319 --- Comment #2 from Kevin Fenzi ke...@scrye.com --- Thanks for the review! (In reply to Michael Schwendt from comment #1) * Both configure.ac and libnftables.pc contain version 1.0.0 already, symbol versioning uses 1.0. If you're afraid of making this a 1.0.0 pre-release, use Version 0, not 0.0. The extra .0 doesn't serve any purpose at all. Fair enough. Changing to 0. * Reproducing the git checkout resulted in a 2KB diff, updates to file xt_LOG.h and nft-expr_target-test.c Will look. Possibly commits that happened after my checkout. * Build output is non-verbose. One cannot examine compiler flags'n'friends that way. Add option --disable-silent-rules to the %configure call. That works with the regenerated Autotools files. Will add. * Relevant rpmlint output: libnftables.x86_64: W: incoherent-version-in-changelog 0.0-0.1 ['0.0-0.1.2013113 0git.fc20', '0.0-0.1.20131130git'] libnftables.x86_64: E: incorrect-fsf-address /usr/share/doc/libnftables/COPYING https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Will ask upstream to fix. * Directory tests contains stuff compiled by Make target check and run by tests/test-script.sh. It could be worthwhile building that stuff in the %check section. Here everything builds, and all test programs print OK. Will add. %packagedevel Group: Development/Libraries Either drop the Group tag here, or add one also to the base package (System Environment/Libraries there). Poor copy and paste on my part, removing. %install rm -rf $RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Would be nice if rpmdev-newspec didn't add this (as thats what I used here). Removed. * No real blockers during review. I highly recommend changing version to 0 and enabling verbose build, at least. That could be done when importing into dist git, however. So: APPROVED Thanks. Will do above cleanups. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl
https://bugzilla.redhat.com/show_bug.cgi?id=1036319 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Kevin Fenzi ke...@scrye.com --- New Package SCM Request === Package Name: libnftables Short Description: Library for low-level interaction with nftables Netlink's API over libmnl Owners: kevin Branches: devel InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl
https://bugzilla.redhat.com/show_bug.cgi?id=1036319 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl
https://bugzilla.redhat.com/show_bug.cgi?id=1036319 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl
https://bugzilla.redhat.com/show_bug.cgi?id=1036319 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Status|NEW |ASSIGNED CC||bugs.mich...@gmx.net Assignee|nob...@fedoraproject.org|bugs.mich...@gmx.net Flags||fedora-review+ --- Comment #1 from Michael Schwendt bugs.mich...@gmx.net --- * Both configure.ac and libnftables.pc contain version 1.0.0 already, symbol versioning uses 1.0. If you're afraid of making this a 1.0.0 pre-release, use Version 0, not 0.0. The extra .0 doesn't serve any purpose at all. * Reproducing the git checkout resulted in a 2KB diff, updates to file xt_LOG.h and nft-expr_target-test.c * Build output is non-verbose. One cannot examine compiler flags'n'friends that way. Add option --disable-silent-rules to the %configure call. That works with the regenerated Autotools files. * Relevant rpmlint output: libnftables.x86_64: W: incoherent-version-in-changelog 0.0-0.1 ['0.0-0.1.2013113 0git.fc20', '0.0-0.1.20131130git'] libnftables.x86_64: E: incorrect-fsf-address /usr/share/doc/libnftables/COPYING https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address * Directory tests contains stuff compiled by Make target check and run by tests/test-script.sh. It could be worthwhile building that stuff in the %check section. Here everything builds, and all test programs print OK. %packagedevel Group: Development/Libraries Either drop the Group tag here, or add one also to the base package (System Environment/Libraries there). %install rm -rf $RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag * No real blockers during review. I highly recommend changing version to 0 and enabling verbose build, at least. That could be done when importing into dist git, however. So: APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl
https://bugzilla.redhat.com/show_bug.cgi?id=1036319 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Blocks||1036320 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1036320 [Bug 1036320] Review Request: nftables - Netfilter Tables userspace utillites -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
