[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-codemirror-4.6.0-3.e ||l7 Resolution|--- |ERRATA Last Closed||2014-11-12 18:13:49 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #6 from Mosaab Alzoubi moc...@hotmail.com --- Done: Spec: http://ojuba.org/test/nodejs-codemirror.spec Srpm: http://ojuba.org/test/nodejs-codemirror-4.6.0-3.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Parag AN(पराग) panem...@gmail.com --- Looks good now :) Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Mosaab Alzoubi moc...@hotmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mosaab Alzoubi moc...@hotmail.com --- ThanX. New Package SCM Request === Package Name: nodejs-codemirror Short Description: A versatile JS text editor Owners: moceap Branches: f19 f20 f21 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-codemirror-4.6.0-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-codemirror-4.6.0-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-codemirror-4.6.0-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-codemirror-4.6.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-codemirror-4.6.0-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #5 from Parag AN(पराग) panem...@gmail.com --- but its not that hard to fix shebang issues just add following lines in the end of %prep section chmod 644 mode/dylan/index.html addon/hint/html-hint.js sed -i '1 i\#!/usr/bin/env bash ' bin/authors.sh everything else looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #4 from Mosaab Alzoubi moc...@hotmail.com --- All Fixed , except sebangs. They aren't important in these places. Spec: http://ojuba.org/test/nodejs-codemirror.spec Srpm: http://ojuba.org/test/nodejs-codemirror-4.6.0-2.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354
Parag AN(पराग) panem...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||panem...@gmail.com
Assignee|nob...@fedoraproject.org|panem...@gmail.com
--- Comment #3 from Parag AN(पराग) panem...@gmail.com ---
Review:
+ package built fine in mock rawhide(x86_64)
- rpmlint on generated rpms gave output
nodejs-codemirror.noarch: W: incoherent-version-in-changelog 3.20.0-1
['4.6.0-1.fc22', '4.6.0-1']
nodejs-codemirror.noarch: W: only-non-binary-in-usr-lib
nodejs-codemirror.noarch: E: script-without-shebang
/usr/lib/node_modules/codemirror/mode/dylan/index.html
nodejs-codemirror.noarch: E: script-without-shebang
/usr/lib/node_modules/codemirror/addon/hint/html-hint.js
nodejs-codemirror.noarch: E: script-without-shebang
/usr/lib/node_modules/codemirror/bin/authors.sh
nodejs-codemirror.src: W: strange-permission codemirror-4.6.0.tgz 0640L
2 packages and 0 specfiles checked; 3 errors, 3 warnings.
+ Source verified with upstream as (sha256sum)
upstream
tarball:c7d089b5ebec55fb9edbb05090f2ffc66b950018607fdc2c2d01678c483def87
srpm tarball:c7d089b5ebec55fb9edbb05090f2ffc66b950018607fdc2c2d01678c483def87
+ License is MIT and its text is included in LICENSE
Suggestions:
1) Fix the rpmlint message of changelog version and then manually change the
tarball permission from 0640 to 664 and then create srpm. Also, shebang issues.
See
2) Group tag is optional and you may want to remove it for Fedora releases
3) change
BuildRequires: nodejs-devel
to
BuildRequires: nodejs-packaging
4)I don't think you need following in spec so remove it
%{?nodejs_find_provides_and_requires}
5) Its general practice to use in %prep
rm -rf node_modules
Please submit updated srpm for further package review. Also do read
https://fedoraproject.org/wiki/Packaging:Node.js
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 --- Comment #2 from Mosaab Alzoubi moc...@hotmail.com --- Updated to 4.6: Spec: http://ojuba.org/test/nodejs-codemirror.spec Srpm: http://ojuba.org/test/nodejs-codemirror-4.6.0-1.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354
Ian Firns fir...@gmail.com changed:
What|Removed |Added
CC||fir...@gmail.com
--- Comment #1 from Ian Firns fir...@gmail.com ---
I currently have no sponsor and am very much in the learning phase. Please note
this is an informal preliminary review IAW the Packaging Review Guidelines
[1].
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
1. To build a package containing pure JavaScript node modules, you need to have
BuildRequires: nodejs-packaging [2]
2. bin/authors.sh and some other scripts are missing shebangs. See rpmlint
output below.
3. measure_scroll.txt looks like a small TODO/questions. It's certainly not
documentation.
4. the doc folder is not included in the %doc directive
5. rpmlint has errors.
= MUST =
[!]: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
Note: rpmlint has output and is attached below. rpmlint was run on both
the src.rpm and resulting noarch.rpm packages.
[x]: The package must be named according to the Package Naming Guidelines.
[x]: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[x]: The package must meet the Packaging Guidelines.
[x]: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
[x]: The License field in the package spec file must match the actual license.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package must be included in %doc.
[x]: The spec file must be written in American English.
[x]: The spec file for the package MUST be legible.
[x]: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as
it is used by the sources file once imported into git. If no upstream URL
can be specified for this package, please see the Source URL Guidelines
for how to deal with this.
Note: upstream is now at 4.1.0
[x]: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[-]: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug
filed
in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number MUST be placed in
a comment, next to the corresponding ExcludeArch line.
[x]: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[-]: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[-]: Every binary RPM package (or subpackage) which stores shared library
files
(not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[x]: Packages must NOT bundle copies of system libraries.
[-]: If the package is designed to be relocatable, the packager must state
this
fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[x]: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does
create that directory.
[x]: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific
%situations)
[x]: Permissions on files must be set properly. Executables should be set with
executable permissions, for example.
[x]: Each package must consistently use macros.
[x]: The package must contain code, or permissable content.
[x]: Large documentation files must go in a -doc subpackage. (The definition
of
large is left up to the packager's best judgement, but is not restricted
to size. Large can refer to either size or quantity).
Note: Documentation size is 300k over 13 files.
[x]: If a package includes something as %doc, it must not affect the runtime
of
the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
[-]: Static libraries
[Bug 1036354] Review Request: nodejs-codemirror - A versatile JS text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1036354 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added CC||tchollingswo...@gmail.com Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
