[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 --- Comment #15 from Orion Poplawski or...@cora.nwra.com --- Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 --- Comment #14 from Petr Vobornik pvobo...@redhat.com --- Package Change Request == Package Name: ttembed New Branches: el6 Owners: pvoborni -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #13 from Orion Poplawski or...@cora.nwra.com --- Petr or others willing to maintain this in EPEL6? It at least builds there fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Petr Vobornik pvobo...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #11 from Petr Vobornik pvobo...@redhat.com --- Package Change Request == Package Name: ttembed New Branches: epel7 Owners: pvoborni Because of https://bugzilla.redhat.com/show_bug.cgi?id=1138538 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ttembed-1.1-1.fc19 |ttembed-1.1-1.fc20 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- ttembed-1.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ttembed-1.1-1.fc19 Resolution|--- |ERRATA Last Closed||2013-12-19 20:32:53 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- ttembed-1.1-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Petr Vobornik pvobo...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Petr Vobornik pvobo...@redhat.com --- New Package SCM Request === Package Name: ttembed Short Description: Remove embedding limitations from TrueType fonts Owners: pvoborni Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- ttembed-1.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ttembed-1.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- ttembed-1.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ttembed-1.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- ttembed-1.1-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754
Petr Vobornik pvobo...@redhat.com changed:
What|Removed |Added
Flags|needinfo?(pvoborni@redhat.c |
|om) |
--- Comment #2 from Petr Vobornik pvobo...@redhat.com ---
Thank you for the review.
Spec and srpm updated:
* man page included
* %{?_smp_mflags} macro added
* simple smoke test added - The only functionality tested is detection of not a
font file because it has the most distinctive output. Other use cases are very
similar to each other (exit code 0 with no output). Using Buildrequires with
font with incorrect fsType is not used because the test will become incorrect
when the font is fixed. More comprehensive tests should be implemented upstream
and then the %check section should be replaced by simple `make test`.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from T.C. Hollingsworth tchollingswo...@gmail.com --- In the future, please increment the Release and add a changelog entry for all updates during the review process. This package is APPROVED. You will be sponsored into the packager group momentarily. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tchollingswo...@gmail.com Blocks|177841 (FE-NEEDSPONSOR) | Assignee|nob...@fedoraproject.org|tchollingswo...@gmail.com Flags||fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754
T.C. Hollingsworth tchollingswo...@gmail.com changed:
What|Removed |Added
CC||pvobo...@redhat.com
Flags||needinfo?(pvoborni@redhat.c
||om)
--- Comment #1 from T.C. Hollingsworth tchollingswo...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Status: NEEDS WORK
= MUST Issues
These issues must be fixed prior to approval.
- The upstream tarball distribution contains a man page, but it is not included
in the binary RPM.
Please install the ttembed.1 man page.
= SHOULD Issues
Packagers are strongly encouraged to resolve these issues where possible, but
they are not blockers.
- Does not use parallel make %{?_smp_mflags} macro.
Guess this is such a tiny C program that this doesn't help much, but
please consider adding it if the Makefile supports it anyway.
- %check is present and all tests pass.
Upstream does not seem to ship tests. You could BuildRequire a font and
run this on it and test that it was successful, just as a little smoke test
in case something goes south and the build fails
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in
/home/fedora/patches/FedoraReview/1036754-ttembed/licensecheck.txt
Public Domain - OK
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Petr Vobornik pvobo...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1036754 Petr Vobornik pvobo...@redhat.com changed: What|Removed |Added Blocks||1035897 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1035897 [Bug 1035897] Review Request: open-sans-fonts - a humanist sans-serif typeface -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
