[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-liquid-3.0.0-2.fc21 Resolution|--- |ERRATA Last Closed||2015-01-17 00:47:04 --- Comment #13 from Fedora Update System --- rubygem-liquid-3.0.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- rubygem-liquid-3.0.0-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 --- Comment #11 from Fedora Update System --- rubygem-liquid-3.0.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-liquid-3.0.0-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Ken Dreyer changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Ken Dreyer --- New Package SCM Request === Package Name: rubygem-liquid Short Description: A secure, non-evaling end user template engine with aesthetic markup Upstream URL: http://www.liquidmarkup.org Owners: ktdreyer Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 --- Comment #8 from Jon Ciesla --- WARNING: No description provided. WARNING: Requested package name rubygem-liquid Short A secure, non-evaling end user template engine with aesthetic markup doesn't match bug summary rubygem-liquid -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Ken Dreyer changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Ken Dreyer --- Thanks very much for the review! New Package SCM Request === Package Name: rubygem-liquid Short A secure, non-evaling end user template engine with aesthetic markup Upstream URL: http://www.liquidmarkup.org Owners: ktdreyer Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Mamoru TASAKA changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Mamoru TASAKA --- Okay, approving. This package (rubygem-liquid) is APPROVED by mtasaka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 --- Comment #5 from Ken Dreyer --- That is a good idea with the spy dummy lib. Thanks for that. New version: * Wed Jan 07 2015 Ken Dreyer - 3.0.0-2 - Add "Ruby" to License tag (RHBZ #1038274) - Create a dummy "spy/integration" lib so we can run the tests during %%check (RHBZ #1038274) Exact change in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-liquid.git/commit/?id=517dd72445d2a32767661db7bbc62c5f9aa41ba6 Spec URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid.spec SPRM URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid-3.0.0-2.fc22.src.rpm Rawhide (F22) Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8545110 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 --- Comment #4 from Mamoru TASAKA --- Would you update this? (also I would appreciate it if you have time to review bug 1175601) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274
--- Comment #3 from Mamoru TASAKA ---
Two comments
* License
- As lib/liquid/module_ex.rb is under Ruby,
the License tag should be "MIT and Ruby".
* Enabling tests
- Would you actually execute test suite as much
as possible, like below (for example)?
mkdir spy
touch spy/integration.rb
ruby -I"lib:.:test" -e 'Dir.glob("./test/**/*_test.rb").each{|f| require f
unless /context_unit_test/ =~ f }'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 Mamoru TASAKA changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #2 from Mamoru TASAKA --- Taking. I would appreciate it if you would review my review request (bug 1175601) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274 --- Comment #1 from Ken Dreyer --- I've updated the package to the latest upstream release and the latest Fedora Ruby guidelines. * Wed Dec 10 2014 Ken Dreyer - 3.0.0-1 - Update to latest upstream release - Adjustments for https://fedoraproject.org/wiki/Changes/Ruby_2.1 - Use %%license tag - Unconditionally pass tests until rubygem-spy is available Exact changes in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-liquid.git/commit/?id=61b430b7489a46773b2927b540270ff7b2341906 Spec URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid.spec SRPM URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid-3.0.0-1.fc22.src.rpm F22 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8333800 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
