[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed|2013-12-29 03:52:42 |2014-09-28 16:02:49 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #13 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Wolfgang Ulbrich --- Opps, sorry. Package Change Request == Package Name: caja New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #11 from Wolfgang Ulbrich --- New Package SCM Request === Package Name: caja Short Description: File manager for MATE desktop Owners: raveit65 vicodan Branches: f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |ERRATA Last Closed||2013-12-29 03:52:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Wolfgang Ulbrich --- New Package SCM Request === Package Name: caja Short Description: File manager for MATE desktop Owners: raveit65 vicodan Branches: InitialCC: Note: branch is empty because other branches than rawhide will use old package name until releases are EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #8 from Björn "besser82" Esser --- Created attachment 837258 --> https://bugzilla.redhat.com/attachment.cgi?id=837258&action=edit Suggestion for an improved spec-file This is out of scope for a review, but since I know Wolfgang always wants to learn new stuff, I just toss in my 0,02 €. :-P Looking on your spec-file, I cannot understand why you make your maintainer's life unnecessialy hard. ;) There is no need for manually downloading, renaming and reuploading the source-tarball, e.g. I attached you a nice possible solution for building release and snapshot pkgs from the same spec, with just editing one single line (and the commit-sha / commit-date, release on updatess of course). :D In scope of this review is following: I found you are tossing in Obsoletes / Proviedes without conditionals to drop them after a few releases. The needed mods a in the attached spec-file, too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Björn "besser82" Esser changed: What|Removed |Added CC||bjoern.es...@gmail.com Blocks||1043297, 1043290 Alias||caja Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1043290 [Bug 1043290] Review Request: engrampa - MATE Desktop file archiver https://bugzilla.redhat.com/show_bug.cgi?id=1043297 [Bug 1043297] Review Request: atril - MATE Document viewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #7 from Wolfgang Ulbrich --- New Package SCM Request === Package Name: caja Short Description: File manager for MATE desktop Owners: raveit65 vicodan Branches: InitialCC: Note: branch is empty because other branches than rawhide will use old package name until releases are EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 leigh scott changed: What|Removed |Added Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co ||m Flags|fedora-review? |fedora-review+ --- Comment #6 from leigh scott --- Approved This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2 or later)", "*No copyright* LGPL (v2 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 19 files have unknown license. Detailed output of licensecheck in /home/leigh/1038773-caja/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/glib-2.0/schemas, /usr/share/glib-2.0 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in caja-schemas [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in caja [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in caja [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 6 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions sec
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #5 from Wolfgang Ulbrich --- New build: Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-1.7.1-0.4.git0ef48fab.fc21.src.rpm * Sun Dec 08 2013 Wolfgang Ulbrich - 1.7.1-0.4.git0ef48fab - add mimeinfo rpm scriplets again -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773
--- Comment #4 from Wolfgang Ulbrich ---
New build:
Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja.spec
SRPM URL:
http://raveit65.fedorapeople.org/Mate/SRPM/caja-1.7.1-0.3.git0ef48fab.fc21.src.rpm
* Sun Dec 08 2013 Wolfgang Ulbrich -
1.7.1-0.3.git0ef48fab
- fix usage of %%{buildroot}
- use desktop-database rpm scriptlet instead of mimeinfo scriptlet
Dan, fedora-review-tool runs in a rawhide VM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #3 from Wolfgang Ulbrich --- Thanks Leigh for your hints. New build: Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-1.7.1-0.2.git0ef48fab.fc21.src.rpm * Fri Dec 06 2013 Wolfgang Ulbrich - 1.7.1-0.2.git0ef48fab - fix all the macro-in-comment warnings - add ldconfig scriptlets for the extension subpackage - add versioned provides for the obsoleted packages - remove licence tags from subpackages - remove group tags from subpackages - fix permission for caja-autostart script -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773
leigh scott changed:
What|Removed |Added
Status|ASSIGNED|NEW
CC||leigh123li...@googlemail.co
||m
--- Comment #2 from leigh scott ---
Here's your todo list
$ rpmlint caja*rpm
caja.src: W: strange-permission caja-autostart 0775L
caja.src:16: W: macro-in-comment %{name}
caja.src:16: W: macro-in-comment %{version}
caja.src:54: W: unversioned-explicit-obsoletes mate-file-manager
caja.src:69: W: unversioned-explicit-obsoletes mate-file-manager-extensions
caja.src:79: W: unversioned-explicit-obsoletes mate-file-manager-schemas
caja.src:89: W: unversioned-explicit-obsoletes mate-file-manager-devel
caja.src:97: W: macro-in-comment %setup
caja.src:103: W: macro-in-comment %patch0
caja.src:207: W: macro-in-comment %doc
caja.src:207: W: macro-in-comment %{_datadir}
caja.src:141: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 141)
caja.x86_64: W: obsolete-not-provided mate-file-manager
caja.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/caja-autostart.desktop
caja.x86_64: W: no-manual-page-for-binary caja-autostart
caja-devel.x86_64: W: obsolete-not-provided mate-file-manager-devel
caja-devel.x86_64: W: no-documentation
caja-extensions.x86_64: W: obsolete-not-provided mate-file-manager-extensions
caja-extensions.x86_64: W: no-documentation
caja-extensions.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libcaja-extension.so.1.4.0
caja-extensions.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libcaja-extension.so.1.4.0
caja-schemas.x86_64: W: spelling-error %description -l en_US gsettings ->
settings, g settings, insetting
caja-schemas.x86_64: W: obsolete-not-provided mate-file-manager-schemas
caja-schemas.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 2 errors, 22 warnings.
1. Please fix all the macro-in-comment warnings
2. add ldconfig scriptlets for the extension subpackage
3. also sort out the use of mixed-use-of-spaces-and-tabs
4. please add provides for the obsoleted packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Dan Mashal changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #1 from Wolfgang Ulbrich --- This is a re-review request for a package rename. Old packackage name is mate-file-manager. Note, this affect only rawhide, f18/19/20 will use mate-file-manager-1.6.x until there EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
