[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Wolfgang Ulbrich changed: What|Removed |Added CC||dan.mas...@gmail.com --- Comment #1 from Wolfgang Ulbrich --- This is a re-review request for a package rename. Old package names are mate-file-manager-image-converter, mate-file-manager-open-terminal, mate-file-manager-sendto and mate-file-manager-share Note, this affect only rawhide, f18/19/20 will use old packages until there EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Dan Mashal changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 --- Comment #2 from Wolfgang Ulbrich --- updated sources: Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja-extensions.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-extensions-1.7.1-0.2.git298c725.fc21.src.rpm * Fri Dec 06 2013 Wolfgang Ulbrich - 1.7.1-0.2.git298c725 - fix all the macro-in-comment warnings - add versioned provides for the obsoleted packages - remove NEWS, zero-length - fix spelling-errors -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 --- Comment #3 from Wolfgang Ulbrich --- Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja-extensions.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-extensions-1.7.1-0.3.git298c725.fc21.src.rpm * Sat Dec 14 2013 Wolfgang Ulbrich - 1.7.0-0.3.git298c725 - remove isa tags from obsoletes/provides -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817
Dan Mashal changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Dan Mashal ---
Looks good, approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "Unknown or
generated". 4 files have unknown license. Detailed output of licensecheck
in /home/dan/fedora-review/1038817-caja-extensions/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gtk-doc, /usr/share
/gtk-doc/html
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/gtk-doc/html/caja-
sendto(mate-file-manager-sendto), /usr/lib64/caja-sendto(mate-file-
manager-sendto), /usr/include/caja-sendto(mate-file-manager-sendto-
devel), /usr/lib64/caja-sendto/plugins(mate-file-manager-sendto)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/samba/caja-share-smb.conf.example
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: glib-compile-schemas is run in %postun and %posttrans if package has
*.gschema.xml files.
Note: gschema file(s) in caja-open-terminal, caja-sendto
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Wolfgang Ulbrich --- New Package SCM Request === Package Name: caja-extensions Short Description: Set of extensions for caja file manager Owners: raveit65 vicodan Branches: InitialCC: Note: branch is empty because other branches than rawhide will use old package name until releases are EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Wolfgang Ulbrich changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2013-12-29 03:51:53 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Wolfgang Ulbrich changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #7 from Wolfgang Ulbrich --- Package Change Request == Package Name: caja-extensions New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 --- Comment #8 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Wolfgang Ulbrich changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed|2013-12-29 03:51:53 |2014-09-28 16:02:02 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
