[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-rspec-longrun-0.1.2 ||-3.fc19 Resolution|--- |ERRATA Last Closed||2013-12-20 21:27:59 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- rubygem-rspec-longrun-0.1.2-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|rubygem-rspec-longrun-0.1.2 |rubygem-rspec-longrun-0.1.2 |-3.fc19 |-3.fc20 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- rubygem-rspec-longrun-0.1.2-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453
Vít Ondruch vondr...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #8 from Vít Ondruch vondr...@redhat.com ---
And I have a few remarks:
* %{gem_cache}
- For simplification, I would drop it on every OS. It is lightly mentioned
just in old guidelines, which are currently aimed on EPEL5, but it makes
(almost) no difference if the cache is kept or not.
* Shebang change
- Although there is no difference in functionality, we are typically doing
such changes in %install section.
The above remarks are just minor nits and otherwise the package looks sane =
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453
Björn besser82 Esser bjoern.es...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags||fedora-cvs?
--- Comment #9 from Björn besser82 Esser bjoern.es...@gmail.com ---
Updated package:
%changelog
* Thu Dec 12 2013 Björn Esser bjoern.es...@gmail.com - 0.1.2-3
- improvements as recommended in review by Vít Ondruch (vondruch)
from comments #7 and #8 (#1040453)
* Wed Dec 11 2013 Björn Esser bjoern.es...@gmail.com - 0.1.2-2
- improvements as recommended in review by Vít Ondruch (vondruch)
from comments #2 and #3 (#1040453)
* Sun Dec 08 2013 Björn Esser bjoern.es...@gmail.com - 0.1.2-1
- Initial rpm release (#1040453)
Urls:
Spec URL: http://besser82.fedorapeople.org/review/rubygem-rspec-longrun.spec
SRPM URL:
http://besser82.fedorapeople.org/review/rubygem-rspec-longrun-0.1.2-3.fc20.src.rpm
Koji Builds for updated package:
el5: no build --- missing dependencies
el6: no build --- missing dependencies
F18: no build --- missing dependencies, will be soon EOL
F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6283070
F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6283074
Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=6283076
(In reply to Vít Ondruch from comment #7)
That is one possibility, the easier one is:
rspec spec
The example is actually in guidelines ;) I also suggest to run the test
suite on build gem, not the expanded, i.e. surroudn the execution by
pushd .%{gem_instdir} ... popd
Changed the %check-target accordingly. Thanks for your proposal.
(In reply to Vít Ondruch from comment #8)
And I have a few remarks:
* %{gem_cache}
- For simplification, I would drop it on every OS. It is lightly mentioned
just in old guidelines, which are currently aimed on EPEL5, but it makes
(almost) no difference if the cache is kept or not.
dropped on every OS.
* Shebang change
- Although there is no difference in functionality, we are typically doing
such changes in %install section.
Thats a matter of preference, isn't it? On most every other language's package
I've seen so far this is done during %prep. So I'll keep it this way.
The above remarks are just minor nits and otherwise the package looks sane
= APPROVED.
Many thanks for the review, Vít!
New Package SCM Request
===
Package Name: rubygem-rspec-longrun
Short Description: RSpec formatter for long-running specs
Owners: besser82
Branches: el5 el6 f18 f19 f20
InitialCC:
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- rubygem-rspec-longrun-0.1.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-rspec-longrun-0.1.2-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- rubygem-rspec-longrun-0.1.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-rspec-longrun-0.1.2-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- rubygem-rspec-longrun-0.1.2-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Alias||rubygem-rspec-longrun -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||vondr...@redhat.com Assignee|nob...@fedoraproject.org|vondr...@redhat.com Flags||fedora-review? --- Comment #1 from Vít Ondruch vondr...@redhat.com --- I'll take this for a review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453
--- Comment #3 from Vít Ondruch vondr...@redhat.com ---
And several more:
* ruby(abi) vs ruby(release)
- R; ruby(release) have to be used since F19 and it should be non-versioned
(unless there is some special need)
- I would drop %{ruby_ver} macro and went with 1.8 instead. Using such macro
was never recomended and I personally find its programatical determination
a bit dangerous.
* s/Config/RbConfig/
- Config was deprecated long time ago. RbConfig should be used instead.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453
--- Comment #2 from Vít Ondruch vondr...@redhat.com ---
* Bundler, Rake
- We are typically trying to get rid of these (an usually quite
successfully).
* Move documentation into -doc subpackage
- Large documentation is usually good to split into -doc subpackage
- You can move there also all files not needed for runtime, i.e. examples,
spec, Gemfile, Rakefile
* Gem repack
- Please go with 'gem spec %{SOURCE0} -l --ruby %{gem_name}.gemspec' as
specified in guidelines. You will save yourself the 'git' kung-fu.
- The upstream .gemspec, although provided, was never intended to be used for
repackaging.
* %gem_install in EPEL6
- Since RHEL 6.5, rubygems know how to use %gem_install macro. This applies
also to rubygems-devel package (these two are related).
* URL:
- The upstream url should be http://github.com/mdub/rspec-longrun if I am not
wrong
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453
--- Comment #4 from Björn besser82 Esser bjoern.es...@gmail.com ---
Updated package:
%changelog
* Wed Dec 11 2013 Björn Esser bjoern.es...@gmail.com - 0.1.2-2
- improvements as recommended in review by Vít Ondruch (vondruch)
from comments #2 and #3 (#1040453)
* Sun Dec 08 2013 Björn Esser bjoern.es...@gmail.com - 0.1.2-1
- Initial rpm release (#1040453)
Urls:
Spec URL: http://besser82.fedorapeople.org/review/rubygem-rspec-longrun.spec
SRPM URL:
http://besser82.fedorapeople.org/review/rubygem-rspec-longrun-0.1.2-2.fc20.src.rpm
(In reply to Vít Ondruch from comment #2)
* Bundler, Rake
- We are typically trying to get rid of these (an usually quite
successfully).
How would one usually accoplish this?!? I'm actually new to Ruby stuff and
need to learn about that :( In fact this is my 2nd rubygem-package.
* Move documentation into -doc subpackage
- Large documentation is usually good to split into -doc subpackage
- You can move there also all files not needed for runtime, i.e. examples,
spec, Gemfile, Rakefile
done
* Gem repack
- Please go with 'gem spec %{SOURCE0} -l --ruby %{gem_name}.gemspec' as
specified in guidelines. You will save yourself the 'git' kung-fu.
- The upstream .gemspec, although provided, was never intended to be used
for repackaging.
done
* %gem_install in EPEL6
- Since RHEL 6.5, rubygems know how to use %gem_install macro. This applies
also to rubygems-devel package (these two are related).
done
* URL:
- The upstream url should be http://github.com/mdub/rspec-longrun if I am
not wrong
replaced
(In reply to Vít Ondruch from comment #3)
And several more:
* ruby(abi) vs ruby(release)
- R; ruby(release) have to be used since F19 and it should be non-versioned
(unless there is some special need)
- I would drop %{ruby_ver} macro and went with 1.8 instead. Using such
macro was never recomended and I personally find its programatical
determination a bit dangerous.
done
* s/Config/RbConfig/
- Config was deprecated long time ago. RbConfig should be used instead.
replaced
Thanks for your comments and improvements Vít! I hope you'll give this another
run...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 --- Comment #5 from Björn besser82 Esser bjoern.es...@gmail.com --- (In reply to Björn besser82 Esser from comment #4) (In reply to Vít Ondruch from comment #2) * Bundler, Rake - We are typically trying to get rid of these (an usually quite successfully). How would one usually accoplish this?!? I'm actually new to Ruby stuff and need to learn about that :( In fact this is my 2nd rubygem-package. Already figured out for this one. :D I just needed to replace %check rake with %check ruby-S rspec spec/rspec/longrun/formatter_spec.rb\ --colour --format nested and `YEAH!`, I could drop the BuildRequires on bundler and rake. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040453] Review Request: rubygem-rspec-longrun - RSpec formatter for long-running specs
https://bugzilla.redhat.com/show_bug.cgi?id=1040453 --- Comment #6 from Björn besser82 Esser bjoern.es...@gmail.com --- Koji Builds for updated package: el5: no build --- missing dependencies el6: no build --- missing dependencies F18: no build --- missing dependencies, will be soon EOL F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6280734 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6280736 Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=6280738 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
