[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added Resolution|NOTABUG |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed|2014-02-14 11:50:32 |2014-09-28 16:01:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 --- Comment #6 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #5 from Wolfgang Ulbrich --- Package Change Request == Package Name: marco New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |ERRATA Last Closed||2014-02-14 11:50:32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Wolfgang Ulbrich --- New Package SCM Request === Package Name: marco Short Description: MATE Desktop window manager Owners: raveit65 vicodan Branches: InitialCC: Note: branch is empty because other branches than rawhide will use old package name until releases are EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995
leigh scott changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #2 from leigh scott ---
Approved
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2 or later)",
"GPL (v2 or later)", "Unknown or generated". 10 files have unknown
license. Detailed output of licensecheck in
/home/leigh/1042995-marco/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/mate-control-center, /usr/share/mate-
control-center/keybindings, /usr/share/mate
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/help, /usr/share/mate-
control-center/keybindings, /usr/share/mate, /usr/share/mate-control-
center, /usr/share/help/C
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: glib-compile-schemas is run in %postun and %posttrans if package has
*.gschema.xml files.
Note: gschema file(s) in marco
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added CC||leigh123li...@googlemail.co ||m --- Comment #1 from Wolfgang Ulbrich --- This is a re-review request for a package rename. Old packackage name is mate-window-manager. Note, this affect only rawhide, f18/19/20 will use mate-window-manager-1.6.x until there EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
