[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 --- Comment #1 from Wolfgang Ulbrich --- This is a re-review request for a package rename. Old packackage name is mate-document-viewer. Note, this affect only rawhide, f18/19/20 will use mate-window-manager-1.6.x until there EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Björn "besser82" Esser changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? --- Comment #2 from Björn "besser82" Esser --- mine ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Björn "besser82" Esser changed: What|Removed |Added Depends On||1038773 (caja) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1038773 [Bug 1038773] Review Request: caja - File manager for MATE desktop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Björn "besser82" Esser changed: What|Removed |Added Alias||atril -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Björn "besser82" Esser changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Björn "besser82" Esser --- Package has one issue, but no blocker. You can fix during import. :) Package Review == Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. ---> all is fine here. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/besser82/shared/fedora/review/1043297-atril/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/help/sr, /usr/share/help/nl, /usr/share/help/uk, /usr/share/help/ja, /usr/share/help/vi ---> false positive, those dirs should be owned by yelp ---> BUG! [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/help/fi, /usr/share/help/uk, /usr/share/help/de, /usr/share/dbus-1/services, /usr/share/help/sv, /usr/share/help/sr, /usr/share/help/fr, /usr/share/thumbnailers, /usr/share/help/C, /usr/share/help/nl, /usr/share/help/ja, /usr/share/help/es, /usr/share/help/eu, /usr/share/help, /usr/share/help/vi, /usr/share/help/ca, /usr/share/help/sl, /usr/share/help/el, /usr/share/help/en_GB, /usr/share/help/zh_CN, /usr/share/dbus-1, /usr/share/help/pt_BR, /usr/share/help/oc, /usr/share/help/it, /usr/share/help/cs, /usr/share/help/bg, /usr/share/help/ru ---> those dirs should be owned by `yelp`, but aren't. File a bug against `yelp` and complain about the missing ownerships, please. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/atril/3(mate- document-viewer-libs), /usr/lib64/atril/3/backends(mate-document-viewer- libs), /usr/include/atril/1.5.0/libdocument(mate-document-viewer-devel), /usr/include/atril(mate-document-viewer-devel), /usr/include/atril/1.5.0 (mate-document-viewer-devel), /usr/lib64/atril(mate-document-viewer- libs), /usr/include/atril/1.5.0/libview(mate-document-viewer-devel) ---> the above named pkg will be obsoleted by this one. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in atril ---> scriptlets are sane. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. ---> please limit them to be present until a specific distro-release like until F23 or so. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in atril ---> scriptlets are sane. [x]: gtk-update-icon-c
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Wolfgang Ulbrich --- Thanks Björn for review the package. New Package SCM Request === Package Name: atril Short Description: MATE Document viewer Owners: raveit65 vicodan Branches: InitialCC: Note: branch is empty because other branches than rawhide will use old package name until releases are EOL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 --- Comment #6 from Wolfgang Ulbrich --- Björn, issue report against yelp is filed out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 --- Comment #7 from Wolfgang Ulbrich --- https://bugzilla.redhat.com/show_bug.cgi?id=1046500 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Bug 1043297 depends on bug 1038773, which changed state. Bug 1038773 Summary: Review Request: caja - File manager for MATE desktop https://bugzilla.redhat.com/show_bug.cgi?id=1038773 What|Removed |Added Status|NEW |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Wolfgang Ulbrich changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA Last Closed||2013-12-29 03:54:51 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Bug 1043297 depends on bug 1038773, which changed state. Bug 1038773 Summary: Review Request: caja - File manager for MATE desktop https://bugzilla.redhat.com/show_bug.cgi?id=1038773 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Wolfgang Ulbrich changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #8 from Wolfgang Ulbrich --- Package Change Request == Package Name: atril New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Wolfgang Ulbrich changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed|2013-12-29 03:54:51 |2014-09-28 16:00:30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Bug 1043297 depends on bug 1038773, which changed state. Bug 1038773 Summary: Review Request: caja - File manager for MATE desktop https://bugzilla.redhat.com/show_bug.cgi?id=1038773 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
