[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||ghc-webkit-0.12.5.1-1.fc20
 Resolution|--- |ERRATA
Last Closed||2014-01-24 21:20:34



--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
ghc-webkit-0.12.5.1-1.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System upda...@fedoraproject.org ---
ghc-webkit-0.12.5.1-1.fc20 has been pushed to the Fedora 20 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418



--- Comment #7 from Fedora Update System upda...@fedoraproject.org ---
ghc-webkit-0.12.5.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ghc-webkit-0.12.5.1-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #6 from Jens Petersen peter...@redhat.com ---
Built for f21 rawhide.
http://koji.fedoraproject.org/koji/buildinfo?buildID=487644

I will build for f20 in a few days after the
https://admin.fedoraproject.org/updates/FEDORA-2013-24050/ghc-gtk-0.12.5.0-1.fc20
stack is pushed stable

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418



--- Comment #5 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2014-01-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Jens Petersen peter...@redhat.com ---
Thanks again!  I also plan to package up the webkitgtk3 binding
once ghc-gtk3 (bug 1045963) has been reviewed.


New Package SCM Request
===
Package Name: ghc-webkit
Short Description: Binding to the Webkit library for gtk2
Owners: petersen
Branches: f20 f19 el6
InitialCC: haskell-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2013-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418



--- Comment #3 from Jens Petersen peter...@redhat.com ---
Thanks Christopher for reviewing the package so soon.

(In reply to Christopher Meng from comment #2)
 One question before +, I think the doc is very large, is it better to add
 -doc subpackage? I'm not sure if we should do this for haskell package,
 please tell me.

Good question.

$ du -sh /usr/share/doc/ghc/html/libraries/webkit/
/usr/lib64/ghc-7.6.3/webkit-0.12.5.1/
12M/usr/share/doc/ghc/html/libraries/webkit/
49M/usr/lib64/ghc-7.6.3/webkit-0.12.5.1/

I admit the size of the docs here is not negligible.
To be honest it is partly a packaging convenience/simplification,
since the package docs can cross-reference docs of dependencies
they need to be BRs, so subpackaging docs effectively doubles
the number of BRs in each package, which also increases the time
for downloading and installing.
The previous version of the Haskell Guidelines (2011) actually
recommend having a doc subpackage, but I felt they were generally
an overhead, so this was dropped in the revised Guidelines.
Generally the installed size of generated devel docs is still small
compared to the total of the devel files, and they compress well.

Perhaps we need a more precise criterion for deciding when
docs are too big to be bundled in the devel package: from
the packaging maintenance PoV it would be simpler to make it
all or none though, but perhaps cabal-rpm could work out which
library packages have a doc subpackage or not.  At least since
we don't rebuild the doc index after each devel package install,
the install/uninstall overhead of docs is not heavy anymore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2013-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2013-12-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418



--- Comment #1 from Jens Petersen peter...@redhat.com ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=6344172

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2013-12-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cicku...@gmail.com
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1047418] Review Request: ghc-webkit - Binding to the Webkit library

2013-12-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1047418



--- Comment #2 from Christopher Meng cicku...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 11591680 bytes in 496 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 LGPL (v2.1 or later), LGPL (v2 or later), Unknown or generated. 139
 files have unknown license. Detailed output of licensecheck:

LGPL (v2 or later)
--
webkit-0.12.5.1/hswebkit.h

LGPL (v2.1 or later)

webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/CacheModel.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/hsevents.c
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/Download.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/GeolocationPolicyDecision.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/HitTestResult.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/Internal.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/NetworkRequest.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/NetworkResponse.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/SecurityOrigin.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/SoupAuthDialog.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebBackForwardList.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebDataSource.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebDatabase.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebFrame.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebHistoryItem.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebInspector.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebNavigationAction.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebPolicyDecision.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebResource.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebSettings.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebView.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/WebWindowFeatures.chs
webkit-0.12.5.1/cbits/hsgclosure.h

Unknown or generated

webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Attr.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/BarProp.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Blob.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSRule.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSRuleList.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSStyleDeclaration.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSStyleSheet.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CSSValue.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/CharacterData.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Console.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Css.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMApplicationCache.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMImplementation.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMMimeType.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMMimeTypeArray.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMNamedFlowCollection.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMPlugin.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMPluginArray.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMSecurityPolicy.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMSelection.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMSettableTokenList.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMStringList.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMTokenList.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMWindow.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DOMWindowCSS.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Document.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/DocumentType.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Element.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Event.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/EventM.hs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/EventTargetClosures.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Events.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/File.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/FileList.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/Geolocation.chs
webkit-0.12.5.1/Graphics/UI/Gtk/WebKit/DOM/HTMLAnchorElement.chs