[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Summary|Review Request: |Review Request: |google-android-emoji - |google-android-emoji-fonts |Android Emoji font released |- Android Emoji font |by Google |released by Google Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Paul Flo Williams changed: What|Removed |Added CC||p...@frixxon.co.uk --- Comment #2 from Paul Flo Williams --- As you are packaging a single font from an upstream git repo, in the absence of a versioned archive from upstream, I wonder whether it might be better to go with a package version that directly corresponds to the font version? That way, any updated versions that appear in other repos could be more clearly recognised. Both the head and name tables of this font say that this is version 1.01. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076
--- Comment #3 from Parag AN(पराग) ---
1) I will suggest to use following release tag
Release Tag for Pre-Release Packages: 0.%{X}.%{alphatag}
and version tag as 1.01
So, package name is google-android-emoji-fonts-1.01-0.1.20120228
2) It took a lot of time to clone the fonts git (approx. 495 MB data) but I see
another easy way is to use URL
https://android.googlesource.com/platform/frameworks/base.git/+archive/jb-release/data/fonts.tar.gz
and extract required files and create new source archive.
3) Remove following files from the source archive as they are not needed
Android.mk fallback_fonts-ja.xml fallback_fonts.xml fonts.mk
MODULE_LICENSE_APACHE2 NOTICE system_fonts.xml vendor_fonts.xml
4) As the getdroid.sh only fetches AndroidEmoji font, name it as
getandroidemoji.sh
5) No need of clean section in spec file. Remove following from spec
%clean
rm -fr %{buildroot}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #4 from Peter Oliver --- Spec URL: http://mavit.fedorapeople.org/rpm/google-android-emoji-fonts.spec SRPM URL: http://mavit.fedorapeople.org/rpm/google-android-emoji-fonts-1.01-1.20120228git.fc21.src.rpm Having consulted https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages, I have changed the package name to google-android-emoji-fonts-1.01-1.20120228git. The gitdroid.sh script was taken from the google-droid-fonts package. I have written a new script, get-source-from-git.sh, which fetches the files from https://android.googlesource.com/platform/frameworks/base.git/+archive/jb-release/data/fonts.tar.gz and manipulates them into a source tarball. Are you sure NOTICE can be omitted? It contains the licence. I have removed the %clean section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076
--- Comment #5 from Parag AN(पराग) ---
1) Please use the recommended way of naming release tags
Pre-Release Packages: 0.%{X}.%{alphatag}
2) I take NOTICE is a duplication of README.txt file. README file clearly says
License URL and fonts in that directory licensed under Apache 2 license whereas
NOTICE just provides text of license file only.
If you want you can package it as I don't see it as a blocker.
Other than these, packaging looks Ok. fontconfig rule not needed as this is
pictorial font.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #6 from Parag AN(पराग) --- Group tag is not mandatory now so you can remove that also. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #7 from Peter Oliver --- Could you explain why that is the appropriate release tag? As I understand it, this is a "post-release package" rather than a "pre-release package", as described at https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages, but I accept that my understanding may be wrong :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #8 from Parag AN(पराग) --- I asked this release tag issue on packaging list and got reply to clarify with upstream about what they think. Here is that reply https://lists.fedoraproject.org/pipermail/packaging/2014-January/009919.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #9 from Peter Oliver --- Thanks. I'm convinced. Android don't do tarball releases, they just tag the release in git. What I hadn't considered before was that that's a release of Android as a whole, not a release of this font. So, if there's never been a release, this must be a prerelease. Spec URL: http://mavit.fedorapeople.org/rpm/google-android-emoji-fonts.spec SRPM URL: http://mavit.fedorapeople.org/rpm/google-android-emoji-fonts-1.01-0.1.20120228git.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Parag AN(पराग) --- Looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Peter Oliver changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Peter Oliver --- New Package SCM Request === Package Name: google-android-emoji-fonts Short Description: Android Emoji font released by Google Owners: mavit Branches: f19 f20 InitialCC: fonts-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Peter Oliver changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-01-14 11:47:56 --- Comment #13 from Peter Oliver --- Thanks, all! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #14 from Fedora Update System --- google-android-emoji-fonts-1.01-0.1.20120228git.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/google-android-emoji-fonts-1.01-0.1.20120228git.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #15 from Fedora Update System --- google-android-emoji-fonts-1.01-0.1.20120228git.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/google-android-emoji-fonts-1.01-0.1.20120228git.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Fedora Update System changed: What|Removed |Added Fixed In Version||google-android-emoji-fonts- ||1.01-0.1.20120228git.fc20 Resolution|NEXTRELEASE |ERRATA --- Comment #16 from Fedora Update System --- google-android-emoji-fonts-1.01-0.1.20120228git.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Fedora Update System changed: What|Removed |Added Fixed In Version|google-android-emoji-fonts- |google-android-emoji-fonts- |1.01-0.1.20120228git.fc20 |1.01-0.1.20120228git.fc19 --- Comment #17 from Fedora Update System --- google-android-emoji-fonts-1.01-0.1.20120228git.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 Bryan Yount changed: What|Removed |Added CC||byo...@redhat.com --- Comment #18 from Bryan Yount --- Is it possible to get this font (or the discussed upstream replacement) included in a default Desktop install of Fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049076] Review Request: google-android-emoji-fonts - Android Emoji font released by Google
https://bugzilla.redhat.com/show_bug.cgi?id=1049076 --- Comment #19 from Peter Oliver --- (In reply to Bryan Yount from comment #18) > Is it possible to get this font (or the discussed upstream replacement) > included in a default Desktop install of Fedora? I've asked about this in https://lists.fedoraproject.org/pipermail/desktop/2015-February/011582.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
