[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 Marek Goldmann changed: What|Removed |Added Blocks||652183 (FE-JAVASIG), ||1043498 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug https://bugzilla.redhat.com/show_bug.cgi?id=1043498 [Bug 1043498] hornetq: Upgrade to 2.4.0.Final -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #1 from gil cattaneo --- please, you should/must remove bundled https://github.com/maven-nar/cpptasks-parallel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #2 from gil cattaneo --- please, must remove all prebuilt libraries ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.dll ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.dll ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.dll.manifest ./src/it/it0016-layout/lib/x86_64-MacOSX-g++/shared/libit0016-lib-shared-1.0-SNAPSHOT.dylib ./src/it/it0020-lib-3rdparty/src/nar/resources/aol/x86_64-MacOSX-g++/lib/libit0007-lib-shared-1.0-SNAPSHOT.dylib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.exp ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.exp ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/ppc-MacOSX-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/i386-Linux-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86_64-MacOSX-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Linux-gpp/share/it0003-jni-1.0-SNAPSHOT.jar ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/ppc-MacOSX-gpp/lib/libit0003-jni-1.0-SNAPSHOT.jnilib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86_64-MacOSX-gpp/lib/libit0003-jni-1.0-SNAPSHOT.jnilib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/x86-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.lib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Windows-msvc/lib/it0003-jni-1.0-SNAPSHOT.lib ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/i386-Linux-gpp/lib/libit0003-jni-1.0-SNAPSHOT.so ./src/it/it0006-jni-3rdparty/src/nar/resources/aol/amd64-Linux-gpp/lib/libit0003-jni-1.0-SNAPSHOT.so -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #3 from gil cattaneo --- Build fails on arm builder Running com.github.maven_nar.test.TestLinkerVersion Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.216 sec <<< FAILURE! - in com.github.maven_nar.test.TestLinkerVersion testVersion(com.github.maven_nar.test.TestLinkerVersion) Time elapsed: 0.096 sec <<< ERROR! org.apache.maven.plugin.MojoExecutionException: NAR: One of two things may be wrong here: 1. tag is missing inside the tag of your NAR configuration 2. no linker is defined in the aol.properties file for 'arm.Linux.linker' at com.github.maven_nar.Linker.getName(Linker.java:190) at com.github.maven_nar.test.TestLinkerVersion.setUp(TestLinkerVersion.java:49) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #4 from gil cattaneo --- http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/build.log http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/mock_output.log http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/root.log http://kojipkgs.fedoraproject.org//work/tasks/4431/6374431/state.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #5 from gil cattaneo --- These files should be consider under lgpl license ...(?) from http://java.freehep.org/freehep-nar-plugin/license.html ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteCCompiler.java ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteF77Compiler.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32Compiler.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64CLinker.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32CLinker.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinuxFortranCompiler.java ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64Compiler.java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #6 from gil cattaneo --- (In reply to gil cattaneo from comment #5) > These files should be consider under lgpl license ...(?) > from http://java.freehep.org/freehep-nar-plugin/license.html > http://java.freehep.org/freehep-nar-plugin/cpptasks.html > ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteCCompiler.java > ./src/main/java/com/github/maven_nar/cpptasks/sun/ForteF77Compiler.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32Compiler.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64CLinker.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux32CLinker.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/ > IntelLinuxFortranCompiler.java > ./src/main/java/com/github/maven_nar/cpptasks/intel/IntelLinux64Compiler.java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #7 from Marek Goldmann --- Spec URL: http://goldmann.fedorapeople.org/package_review/nar-maven-plugin/2/nar-maven-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/nar-maven-plugin/2/nar-maven-plugin-3.0.0-2.fc20.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6383506 Changes: - Added support for ARM - Fixed license field - Removed bundled libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #8 from Marek Goldmann --- (In reply to gil cattaneo from comment #1) > please, you should/must remove bundled > https://github.com/maven-nar/cpptasks-parallel This project is obsolete and was merged into the nar-maven-plugin codebase, see README.md, no need to "unbundle". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 gil cattaneo changed: What|Removed |Added Assignee|punto...@libero.it |nob...@fedoraproject.org Flags|fedora-review? | --- Comment #9 from gil cattaneo --- Sorry, i cant review this package cause: problem/s with mock on my system see https://bugzilla.redhat.com/show_bug.cgi?id=1051485#c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 gil cattaneo changed: What|Removed |Added Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942
gil cattaneo changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
--- Comment #10 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- This seems like a Java package, please install fedora-review-plugin-java to
get additional checks
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 60 files have unknown license.
Detailed output of licensecheck in /home/gil/1049942-nar-maven-
plugin/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[!]: Dist tag is present (not strictly required in GL).
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nar-maven-
plugin-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary r
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 Marek Goldmann changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Flags||fedora-cvs? --- Comment #11 from Marek Goldmann --- Thanks! New Package SCM Request === Package Name: nar-maven-plugin Short Description: Native ARchive plugin for Maven Owners: goldmann Branches: f20 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 Marek Goldmann changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||nar-maven-plugin-3.0.0-2 Resolution|--- |RAWHIDE Last Closed||2014-01-14 03:42:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 --- Comment #13 from Fedora Update System --- nar-maven-plugin-3.0.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nar-maven-plugin-3.0.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049942] Review Request: nar-maven-plugin - Native ARchive plugin for Maven
https://bugzilla.redhat.com/show_bug.cgi?id=1049942 Fedora Update System changed: What|Removed |Added Fixed In Version|nar-maven-plugin-3.0.0-2|nar-maven-plugin-3.0.0-2.fc ||20 Resolution|RAWHIDE |ERRATA --- Comment #14 from Fedora Update System --- nar-maven-plugin-3.0.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
