[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-libqutrub-1.0-3.el7 Resolution|--- |ERRATA Last Closed||2014-11-14 15:23:43 --- Comment #18 from Fedora Update System --- python-libqutrub-1.0-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #17 from Fedora Update System --- python-libqutrub-1.0-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #15 from Fedora Update System --- python-libqutrub-1.0-3.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #16 from Fedora Update System --- python-libqutrub-1.0-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- python-libqutrub-1.0-3.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #13 from Fedora Update System --- python-libqutrub-1.0-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-libqutrub-1.0-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #12 from Fedora Update System --- python-libqutrub-1.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-libqutrub-1.0-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #10 from Fedora Update System --- python-libqutrub-1.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-libqutrub-1.0-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #10 from Fedora Update System --- python-libqutrub-1.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-libqutrub-1.0-3.fc19 --- Comment #11 from Fedora Update System --- python-libqutrub-1.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-libqutrub-1.0-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Mosaab Alzoubi changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mosaab Alzoubi --- Ok, Thank You. New Package SCM Request === Package Name: python-libqutrub Short Description: Arabic verb conjuagtion library Owners: moceap Branches: f19 f20 f21 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Parag AN(पराग) --- just a single rpmlint warning remains python-libqutrub.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 4) you can fix this when you import this package. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #6 from Mosaab Alzoubi --- I called him not by email, and he mean GPLv1. All Fixed: Spec: http://ojuba.org/test/python-libqutrub.spec Srpm: http://ojuba.org/test/python-libqutrub-1.0-3.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #5 from Parag AN(पराग) --- 1) fix the rpmlint messages python-libqutrub.noarch: W: spelling-error Summary(en_US) conjuagtion -> conjugation, conjuration, continuation python-libqutrub.noarch: I: enchant-dictionary-not-found ar python-libqutrub.noarch: W: spelling-error %description -l en_US conjuagtion -> conjugation, conjuration, continuation python-libqutrub.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-libqutrub/PKG-INFO python-libqutrub.src: W: spelling-error Summary(en_US) conjuagtion -> conjugation, conjuration, continuation python-libqutrub.src: W: spelling-error %description -l en_US conjuagtion -> conjugation, conjuration, continuation python-libqutrub.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 4) 2 packages and 0 specfiles checked; 0 errors, 6 warnings. => fix the wrong-file-end-of-line-encoding and mixed-use-of-spaces-and-tabs warnings. 2) When you add license text as GPLv1 and use tag GPL+ then its contradiction. Because GPL+ mean technically licensed under *any* version of the GPL. If upstream is saying its GPLv1 then ask upstream to add it in upstream code and release new version or as I said either keep license as "GPL+" and drop Source1 or if upstream can clarify it as a GPLv1 then attach its email reply or any other static reference on the internet (say like you got a reply on upstream project website) that you can include in spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #4 from Mosaab Alzoubi --- Done: Spec: http://ojuba.org/test/python-libqutrub.spec Srpm: http://ojuba.org/test/python-libqutrub-1.0-2.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840
--- Comment #3 from Parag AN(पराग) ---
Review:
+ package built fine in mock rawhide(x86_64)
+ rpmlint on generated rpms gave output
python-libqutrub.noarch: W: spelling-error Summary(en_US) conjuagtion ->
conjugation, conjuration, continuation
python-libqutrub.noarch: I: enchant-dictionary-not-found ar
python-libqutrub.noarch: W: spelling-error %description -l en_US conjuagtion ->
conjugation, conjuration, continuation
python-libqutrub.noarch: W: no-documentation
python-libqutrub.src: W: spelling-error Summary(en_US) conjuagtion ->
conjugation, conjuration, continuation
python-libqutrub.src: W: spelling-error %description -l en_US conjuagtion ->
conjugation, conjuration, continuation
python-libqutrub.src: W: strange-permission LibQutrub-1.0.zip 0600L
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
+ Source verified with upstream as (sha256sum)
srpm tarball: c10d6e1d101026920060d2b8d921debcdfaaf795bd3c7241278e357415e942c1
upstream tarball :
c10d6e1d101026920060d2b8d921debcdfaaf795bd3c7241278e357415e942c1
+ License is just "GPL+" as per PKG-INFO
suggestions:
1) Email to upstream author and get clarification on what is the license for
this python module. When you get reply you can include that reply as a LICENSE
file as Source1: in spec and add it to %doc
2) I failed to understand the meaning of following line
#Site of files just for including:
instead of this you can include like "Remove the python shebang"
3) you need to follow https://fedoraproject.org/wiki/Packaging:Python
guidelines
Add in %prep after setup macro line
rm -rf *.egg-info
this is to make sure you will not install directly egg info file that upstream
if providing and instead you are installing egg info that gets created in
%build section
4) As per python guidelines your %install section should use
%{__python2} setup.py install --skip-build --root=%{buildroot}
5) your %files section should look like this
%files -n python-%{module_name}
%doc PKG-INFO
%{python2_sitelib}/%{modname}/
%{python2_sitelib}/%{distname}-%{version}-py2.*.egg-info
6) License tag can be just "GPL+" as there is no mention of any GPL version
information but good to ask upstream.
Note: We need some reference that will show what is the license for this
package.
7) Group tag is optional so you can remove it for fedora releases.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #2 from Mosaab Alzoubi --- I call the programmar Taha Zarroqi and he said he mean GPL1 :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051840] Review Request: python-libqutrub - Arabic verb conjuagtion library
https://bugzilla.redhat.com/show_bug.cgi?id=1051840 Volker Fröhlich changed: What|Removed |Added CC||volke...@gmx.at --- Comment #1 from Volker Fröhlich --- I think the license is GPL, not GPLv1. At least I can't find any evidence of a version statement. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
