[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 --- Comment #1 from Patrick Uiterwijk --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6414698 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Patrick Uiterwijk changed: What|Removed |Added Assignee|nob...@fedoraproject.org|sgall...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269
Stephen Gallagher changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||puiterw...@redhat.com
Flags||needinfo?(puiterwijk@redhat
||.com)
--- Comment #2 from Stephen Gallagher ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
[!] The summary and description are udisks-centric and focused on LVM. It would
probably be better to describe it as a set of extended storage capabilities
built upon the udisks foundation
[!] 'BuildRequires: systemd' appears twice
[?] There are no arguments passed to %configure and the output of ./configure
does not list defaults for some options. I'm assuming they are appropriate for
Fedora.
= MUST items =
C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "LGPL", "GPL (v2 or later)". Detailed output of
licensecheck in /dev/shm/1054269-storaged/licensecheck.txt
[X]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[X]: Package contains systemd file(s) if in need.
[X]: Useful -debuginfo package or justification otherwise.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 4 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Package functions as described.
[X]: Latest v
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Patrick Uiterwijk changed: What|Removed |Added Flags|needinfo?(puiterwijk@redhat | |.com) | --- Comment #3 from Patrick Uiterwijk --- Spec URL: http://puiterwijk.fedorapeople.org//storaged.spec SRPM URL: http://puiterwijk.fedorapeople.org//storaged-0.1.0-2.fc20.src.rpm * Thu Jan 16 2014 Patrick Uiterwijk - 0.1.0-2 - Removed double systemd BuildRequire - Rewritten summary and description -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 --- Comment #4 from Patrick Uiterwijk --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6417339 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Stephen Gallagher changed: What|Removed |Added Flags||fedora-review+ --- Comment #5 from Stephen Gallagher --- Looks good to me. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Patrick Uiterwijk changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Patrick Uiterwijk --- New Package SCM Request === Package Name: storaged Short Description: Extended storage management DBus service Owners: puiterwijk Branches: f19 f20 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 --- Comment #8 from Fedora Update System --- storaged-0.1.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/storaged-0.1.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 --- Comment #9 from Fedora Update System --- storaged-0.1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/storaged-0.1.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- storaged-0.1.0-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||storaged-0.1.0-2.fc20 Resolution|--- |ERRATA Last Closed||2014-01-24 21:22:01 --- Comment #11 from Fedora Update System --- storaged-0.1.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1054269] Review Request: storaged - LVM DBus add-on for udisks
https://bugzilla.redhat.com/show_bug.cgi?id=1054269 Fedora Update System changed: What|Removed |Added Fixed In Version|storaged-0.1.0-2.fc20 |storaged-0.1.0-2.fc19 --- Comment #12 from Fedora Update System --- storaged-0.1.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
