[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #1 from Christopher Meng --- Swap with something later ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366
--- Comment #2 from Christopher Meng ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (2 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
generated", "LGPL (v2 or later) (with incorrect FSF address)". 4 files
have unknown license. Detailed output of licensecheck:
BSD (2 clause)
--
snapraid-5.2/tommyarray.c
snapraid-5.2/tommyarray.h
snapraid-5.2/tommyarrayblk.c
snapraid-5.2/tommyarrayblk.h
snapraid-5.2/tommyarrayblkof.c
snapraid-5.2/tommyarrayblkof.h
snapraid-5.2/tommychain.h
snapraid-5.2/tommyhash.c
snapraid-5.2/tommyhash.h
snapraid-5.2/tommyhashdyn.c
snapraid-5.2/tommyhashdyn.h
snapraid-5.2/tommylist.c
snapraid-5.2/tommylist.h
snapraid-5.2/tommytypes.h
GPL (v2 or later)
-
snapraid-5.2/cpu.h
snapraid-5.2/mktables.c
snapraid-5.2/raid.c
snapraid-5.2/raid.h
snapraid-5.2/tables.h
GPL (v3 or later)
-
snapraid-5.2/check.c
snapraid-5.2/combo.h
snapraid-5.2/dry.c
snapraid-5.2/dup.c
snapraid-5.2/elem.c
snapraid-5.2/elem.h
snapraid-5.2/handle.c
snapraid-5.2/handle.h
snapraid-5.2/import.c
snapraid-5.2/import.h
snapraid-5.2/list.c
snapraid-5.2/mingw.c
snapraid-5.2/mingw.h
snapraid-5.2/mktest.c
snapraid-5.2/murmur3.c
snapraid-5.2/parity.c
snapraid-5.2/parity.h
snapraid-5.2/pool.c
snapraid-5.2/portable.h
snapraid-5.2/rehash.c
snapraid-5.2/scan.c
snapraid-5.2/scrub.c
snapraid-5.2/selftest.c
snapraid-5.2/snapraid.c
snapraid-5.2/snapraid.h
snapraid-5.2/speed.c
snapraid-5.2/spooky2.c
snapraid-5.2/state.c
snapraid-5.2/state.h
snapraid-5.2/status.c
snapraid-5.2/sync.c
snapraid-5.2/tommy.c
snapraid-5.2/unix.c
snapraid-5.2/unix.h
snapraid-5.2/util.c
snapraid-5.2/util.h
LGPL (v2 or later) (with incorrect FSF address)
---
snapraid-5.2/fnmatch.c
snapraid-5.2/fnmatch.h
Unknown or generated
snapraid-5.2/autogen.sh
snapraid-5.2/murmur3test.c
snapraid-5.2/noautomake.sh
snapraid-5.2/spooky2test.c
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #3 from Eric Smith --- The License tag is for the effective license of the files in the binary RPM: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License:_field http://fedoraproject.org/wiki/Licensing:FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F BSD code linked with GPL results in a GPL binary. Updated to latest upstream: Spec URL: http://fedorapeople.org/~brouhaha/snapraid/snapraid.spec SRPM URL: http://fedorapeople.org/~brouhaha/snapraid/snapraid-6.1-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #4 from Christopher Meng --- Although tommyds and snapraid shares the same upstream, I still consider that these BSD are bundled code. You'd better package tommyds and use the system one to replace them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #5 from Eric Smith --- tommyds review request bug #1089523 Spec URL: http://fedorapeople.org/~brouhaha/snapraid/snapraid.spec SRPM URL: http://fedorapeople.org/~brouhaha/snapraid/snapraid-6.1-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Christopher Meng changed: What|Removed |Added Depends On||1089523 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089523 [Bug 1089523] Review Request: tommyds - High performance C library for hashtables and tries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Christopher Meng changed: What|Removed |Added Depends On|1089523 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089523 [Bug 1089523] Review Request: tommyds - High performance C library for hashtables and tries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #6 from Eric Smith --- Andrea Mazzoleni, author of both TommyDS and SnapRAID, has requested that TommyDS not be built as a shared library. I've opened FPC ticket #423 requesting a "copylib" bundling exception. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Christopher Meng --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #8 from Eric Smith --- FPC approved the SnapRAID/TommyDS bundling exception (FPC ticket #423) at their 2014-05-15 meeting. Should any of the conditions that led to the bundling exception request change, I will contact FPC. The spec and SRPM are updated to be equivalent to the 6.1-1 package previously reviewed, except that the bundling exception is noted in the changelog. Spec URL: http://fedorapeople.org/~brouhaha/snapraid/snapraid.spec SRPM URL: http://fedorapeople.org/~brouhaha/snapraid/snapraid-6.1-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Eric Smith changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Eric Smith --- New Package SCM Request === Package Name: snapraid Short Description: Disk array backup for many large rarely-changed files Upstream URL: http://snapraid.sourceforge.net/ Owners: brouhaha Branches: f19 f20 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #11 from Fedora Update System --- snapraid-6.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/snapraid-6.1-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #12 from Fedora Update System --- snapraid-6.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/snapraid-6.1-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #13 from Fedora Update System --- snapraid-6.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/snapraid-6.1-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- snapraid-6.1-3.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||snapraid-6.1-3.fc19 Resolution|--- |ERRATA Last Closed||2014-05-26 19:56:21 --- Comment #15 from Fedora Update System --- snapraid-6.1-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Fedora Update System changed: What|Removed |Added Fixed In Version|snapraid-6.1-3.fc19 |snapraid-6.1-3.fc20 --- Comment #16 from Fedora Update System --- snapraid-6.1-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Fedora Update System changed: What|Removed |Added Fixed In Version|snapraid-6.1-3.fc20 |snapraid-6.1-3.el6 --- Comment #17 from Fedora Update System --- snapraid-6.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 --- Comment #18 from Fedora Update System --- snapraid-6.3-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/snapraid-6.3-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055366] Review Request: snapraid - Disk array backup for many large rarely-changed files
https://bugzilla.redhat.com/show_bug.cgi?id=1055366 Fedora Update System changed: What|Removed |Added Fixed In Version|snapraid-6.1-3.el6 |snapraid-6.3-2.el7 --- Comment #19 from Fedora Update System --- snapraid-6.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
