[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391



--- Comment #14 from Jon Ciesla  ---
WARNING: Requested package name ocaml-cppo doesn't match bug summary
ocaml-easy-format

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Ding-Yi Chen  changed:

   What|Removed |Added

 CC||dc...@redhat.com
  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #13 from Ding-Yi Chen  ---
New Package SCM Request
===
Package Name: ocaml-cppo
Short Description: Equivalent of the C preprocessor for OCaml programs
Owners: salimma
Branches: epel7 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|ocaml-easy-format-1.0.2-2.f |ocaml-easy-format-1.0.2-2.f
   |c19 |c20



--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
ocaml-easy-format-1.0.2-2.fc20 has been pushed to the Fedora 20 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||ocaml-easy-format-1.0.2-2.f
   ||c19
 Resolution|--- |ERRATA
Last Closed||2014-02-02 21:45:41



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
ocaml-easy-format-1.0.2-2.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
ocaml-easy-format-1.0.2-2.fc19 has been pushed to the Fedora 19 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Michel Alexandre Salim michel+...@sylvestre.me ---
Thank you very much for reviewing.

New Package SCM Request
===
Package Name: ocaml-easy-format
Short Description: High-level and functional interface to the Format module
Owners: salimma
Branches: f19 f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391



--- Comment #7 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391



--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
ocaml-easy-format-1.0.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ocaml-easy-format-1.0.2-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391



--- Comment #8 from Fedora Update System upda...@fedoraproject.org ---
ocaml-easy-format-1.0.2-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ocaml-easy-format-1.0.2-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391



--- Comment #3 from Michel Alexandre Salim michel+...@sylvestre.me ---
(In reply to Jerry James from comment #1)
 I will take this one.  Would you mind reviewing bug 1021017 in exchange?

Certainly, taken

(In reply to Jerry James from comment #2)
 Issues, in no particular order:
 

Will get them fixed at the next revision

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391



--- Comment #4 from Michel Alexandre Salim michel+...@sylvestre.me ---
Spec URL: http://salimma.fedorapeople.org/specs/ocaml/ocaml-easy-format.spec
SRPM URL:
http://salimma.fedorapeople.org/specs/ocaml/ocaml-easy-format-1.0.2-2.fc20.src.rpm

✗ rpmlint
/var/lib/mock/fedora-20-x86_64-oef/result/ocaml-easy-format-*.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Review feedback incorporated, details below:


(In reply to Jerry James from comment #2)
 Issues, in no particular order:
 
 1) These lines at the top of the spec file:
 
%global debug_package %{nil}
%global _use_internal_dependency_generator 0
%global __find_requires /usr/lib/rpm/ocaml-find-requires.sh
%global __find_provides /usr/lib/rpm/ocaml-find-provides.sh
 
should all be removed.  The first is not necessary starting in Fedora
19, and was actively removed from ocaml packages in Fedora 20 (see
   
 https://lists.fedoraproject.org/pipermail/devel/2013-September/189247.html).

Aha, thanks! As it turns out the debug_package nullification is still needed
when ocamlopt is not present (tested by overriding opt to 0) so I've if-guarded
it.

The last three lines have not been needed for a very long time; I
don't remember now when they became unnecessary, but it was prior to
Fedora 19.  Also, the strip invocation in %install should be removed,
and we need to figure out how to add -g to the compiler flags,
probably with something like this in %prep:
 
sed -i 's/ocamlopt/ocamlopt -g/;s/ocamlc \(-[co]\)/ocamlc -g \1/' Makefile
 
That line works, thanks. As for the dependency generator, wow, someone needs to
update those templates.

 2) The build seems to need ocaml-findlib only, not ocaml-findlib-devel;
i.e., the ocamlfind tool is used, but I don't see any use of the
ocaml-findlib library in the source code.
 
Yes, works fine once I depended only on ocaml-findlib.

 3) Not all architectures support ocaml.  Add this to your spec file:
 
ExclusiveArch: %{ocaml_arches}
 
Added

 4) There is no need to build the bytecode version for architectures that
support native code.  I suggest changing the make invocation to this,
without the leading make:
 
%if %opt
make %{?_smp_mflags} opt
%else
make %{?_smp_mflags}
%endif
 
I've modified it since upstream's Makefile is a bit unusual (the default target
invoked 'all' and 'opt' -- the latter is a no-op that just creates a marker to
tell make install to copy additional files). so the non-optimizing case just
calls make all (this way, I can test building non-ocamlopt builds even on my
x86_64 mock environment)

 5) Since the packages are arch-specific, the dependency from the -devel
subpackage to the main package should include %{?_isa}.
 
Added (again, the newspec template... sigh)

 6) Consider adding a %check section.  The make test invocation just
creates output files without checking them for correctness, so that's
not sufficient, unless you are just testing for crashes, or the like.
There may not be a reasonable test to run.  I will leave this to your
disgression.
 
I'm using upstream's test suite for now, even though it's incomplete.

 7) The description contains two British English spellings, as noted by
the spell checker (see below).  American English uses only one 'l'
where British English uses two in modeled and labeled.
 
Fixed

 8) The line:
 
rm -rf $RPM_BUILD_ROOT
 
at the top of %install is not needed in Fedora.  The versions of RPM
in all supported Fedora releases do this already.  (If you are
thinking of building the package for EPEL, that's another story.)
 
Fixed

 9) Rpmlint complains about %define libname.  I understand that you can't
use %global at that location, since %{name} hasn't been defined yet.
One solution to that is to use %global, but move the definition
farther down in the spec file, perhaps just above %description.
 
Good idea, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Jerry James loganje...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jerry James loganje...@gmail.com ---
(In reply to Michel Alexandre Salim from comment #4)
 Aha, thanks! As it turns out the debug_package nullification is still needed
 when ocamlopt is not present (tested by overriding opt to 0) so I've
 if-guarded it.

Hmmm, that's a good point.  I don't think that was done during the mass
enabling of debuginfo for ocaml packages.  Maybe we don't currently have any
architectures that support byte-code-only ocaml, so nobody has noticed?

 That line works, thanks. As for the dependency generator, wow, someone needs
 to update those templates.

Agreed.  I'll see if I can poke somebody to do that.

You handled all of the issues I brought up, and a re-review did not turn up any
new issues, so this package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Jerry James loganje...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jerry James loganje...@gmail.com ---
I will take this one.  Would you mind reviewing bug 1021017 in exchange?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391



--- Comment #2 from Jerry James loganje...@gmail.com ---
Issues, in no particular order:

1) These lines at the top of the spec file:

   %global debug_package %{nil}
   %global _use_internal_dependency_generator 0
   %global __find_requires /usr/lib/rpm/ocaml-find-requires.sh
   %global __find_provides /usr/lib/rpm/ocaml-find-provides.sh

   should all be removed.  The first is not necessary starting in Fedora
   19, and was actively removed from ocaml packages in Fedora 20 (see
   https://lists.fedoraproject.org/pipermail/devel/2013-September/189247.html).
   The last three lines have not been needed for a very long time; I
   don't remember now when they became unnecessary, but it was prior to
   Fedora 19.  Also, the strip invocation in %install should be removed,
   and we need to figure out how to add -g to the compiler flags,
   probably with something like this in %prep:

   sed -i 's/ocamlopt/ocamlopt -g/;s/ocamlc \(-[co]\)/ocamlc -g \1/' Makefile

2) The build seems to need ocaml-findlib only, not ocaml-findlib-devel;
   i.e., the ocamlfind tool is used, but I don't see any use of the
   ocaml-findlib library in the source code.

3) Not all architectures support ocaml.  Add this to your spec file:

   ExclusiveArch: %{ocaml_arches}

4) There is no need to build the bytecode version for architectures that
   support native code.  I suggest changing the make invocation to this,
   without the leading make:

   %if %opt
   make %{?_smp_mflags} opt
   %else
   make %{?_smp_mflags}
   %endif

5) Since the packages are arch-specific, the dependency from the -devel
   subpackage to the main package should include %{?_isa}.

6) Consider adding a %check section.  The make test invocation just
   creates output files without checking them for correctness, so that's
   not sufficient, unless you are just testing for crashes, or the like.
   There may not be a reasonable test to run.  I will leave this to your
   disgression.

7) The description contains two British English spellings, as noted by
   the spell checker (see below).  American English uses only one 'l'
   where British English uses two in modeled and labeled.

8) The line:

   rm -rf $RPM_BUILD_ROOT

   at the top of %install is not needed in Fedora.  The versions of RPM
   in all supported Fedora releases do this already.  (If you are
   thinking of building the package for EPEL, that's another story.)

9) Rpmlint complains about %define libname.  I understand that you can't
   use %global at that location, since %{name} hasn't been defined yet.
   One solution to that is to use %global, but move the definition
   farther down in the spec file, perhaps just above %description.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
 The flags are missing -g; see issue #1 above.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[!]: Spec file is legible and written in American English.
 See the spell checker's output below.  American English uses only
 one 'l' where British English uses two: modeled and labeled.
 See issue #7 above.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
 See issue #1 above.
[!]: Package is not known to require an ExcludeArch tag.
 This is missing.  See issue #3 above.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package 

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

 Blocks||1055393




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1055393
[Bug 1055393] Review Request: ocaml-biniou - Safe and fast binary data
format
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055391] Review Request: ocaml-easy-format - High-level and functional interface to the Format module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055391

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

 Blocks||1055396




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1055396
[Bug 1055396] Review Request: ocaml-yojson - An optimized parsing and
printing library for the JSON format
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review