[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Stephen Gallagher changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Flags|needinfo?(puiterwijk@redhat | |.com) | Last Closed||2016-07-20 11:31:10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Stephen Gallagher changed: What|Removed |Added Status|CLOSED |NEW Resolution|CURRENTRELEASE |--- Assignee|sgall...@redhat.com |puiterw...@redhat.com Keywords||Reopened --- Comment #11 from Stephen Gallagher --- Sorry, closed accidentally. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST Flags||needinfo?(puiterwijk@redhat ||.com) --- Comment #12 from Igor Gnatenko --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 --- Comment #1 from Patrick Uiterwijk --- *** Bug 1055501 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 --- Comment #2 from Patrick Uiterwijk --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6429169 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Patrick Uiterwijk changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|sgall...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Colin Walters changed: What|Removed |Added CC||walt...@redhat.com --- Comment #3 from Colin Walters --- I should note here that while originally libgssh depended on libgsystem (a copylib), it now only depends on the "libgsystem-local-alloc" copylib which is a subset of libgsystem - it's about 150 lines of code. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500
--- Comment #4 from Stephen Gallagher ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= Issues =
* Package bundles libgsystem-local-alloc. Bundling exception required.
* Commented-out "Requires:" line should be removed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2 or later) (with incorrect FSF address)", "Unknown or
generated". 1 files have unknown license. Detailed output of licensecheck
in /dev/shm/1055500-libgssh/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original ins
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Stephen Gallagher changed: What|Removed |Added CC||puiterw...@redhat.com Flags||needinfo?(puiterwijk@redhat ||.com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 --- Comment #5 from Colin Walters --- (In reply to Stephen Gallagher from comment #4) > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > = Issues = > * Package bundles libgsystem-local-alloc. Bundling exception required. Hmm...looks like this was stuck here: https://fedorahosted.org/fpc/ticket/383 I just commented. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Patrick Uiterwijk changed: What|Removed |Added Flags|needinfo?(puiterwijk@redhat | |.com) | --- Comment #6 from Patrick Uiterwijk --- Sorry, I had been waiting for a new release with the external libgsystem. This release has now been made, and I updated the package. New Spec URL: http://puiterwijk.fedorapeople.org//libgssh.spec New SRPM URL: http://puiterwijk.fedorapeople.org//libgssh-2014.2-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Stephen Gallagher changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Stephen Gallagher --- Updated packages look good to me. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Michael Schwendt (Fedora Packager Sponsors Group) changed: What|Removed |Added Flags||needinfo?(puiterwijk@redhat ||.com) --- Comment #10 from Michael Schwendt (Fedora Packager Sponsors Group) --- Package not imported yet! And the download links give 404 Not Found! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Patrick Uiterwijk changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Patrick Uiterwijk --- New Package SCM Request === Package Name: libgssh Short Description: Friendly GIO wrapper for libssh Owners: puiterwijk Branches: f19 f20 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055500] Review Request: libgssh - Friendly GIO wrapper for libssh
https://bugzilla.redhat.com/show_bug.cgi?id=1055500 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA Flags|needinfo?(puiterwijk@redhat | |.com) | Last Closed|2016-07-20 15:31:10 |2021-06-04 07:12:50 --- Comment #13 from Mattia Verga --- This ticket was never closed. Package was imported and later retired, so I'm going to close this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
