[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872



--- Comment #11 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-03-17 09:09:35



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

  Flags|fedora_requires_release_not |fedora-cvs?
   |e?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Christopher Meng cicku...@gmail.com ---
(In reply to Michael Schwendt from comment #6)
  2. In -utils, remove:
  
  Requires: %{name}%{?_isa} = %{version}-%{release}
 
 No.
 
 Notice:
 https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
 
 In case it's not clear, that one is not specific to -devel subpackages.
 
 The full story is somewhat more complicated and has been discussed on
 various mailing-lists over the past years.

Hmm...

I just read again and think that preserving it is right.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #8 from Peter Robinson pbrobin...@gmail.com ---
Thanks for the review

New Package GIT Request
===
Package Name: libusbg
Short Description: Library for USB gadget-configfs userspace functionality
Owners: 
Branches: F-19 F-20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872



--- Comment #9 from Jon Ciesla limburg...@gmail.com ---
No FAS account provided.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

  Flags||fedora_requires_release_not
   ||e?



--- Comment #10 from Peter Robinson pbrobin...@gmail.com ---
New Package GIT Request
===
Package Name: libusbg
Short Description: Library for USB gadget-configfs userspace functionality
Owners: pbrobinson
Branches: F-19 F-20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872



--- Comment #5 from Peter Robinson pbrobin...@gmail.com ---
 1. In -devel, remove:
 
 Requires: pkgconfig

OK

 2. In -utils, remove:
 
 Requires: %{name}%{?_isa} = %{version}-%{release}
 
 As RPM will find the deps correctly:

What about for multilib?

 I'd like to see your new spec, then I will approve.

Why? They are minor bits that can easily fixed before commit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872



--- Comment #6 from Michael Schwendt bugs.mich...@gmx.net ---
 2. In -utils, remove:
 
 Requires: %{name}%{?_isa} = %{version}-%{release}

No.

Notice:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

In case it's not clear, that one is not specific to -devel subpackages.

The full story is somewhat more complicated and has been discussed on various
mailing-lists over the past years.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-03-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872



--- Comment #4 from Christopher Meng cicku...@gmail.com ---
ping

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-02-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872



--- Comment #2 from Peter Robinson pbrobin...@gmail.com ---
We don't need nor want pdf or PS based documentation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-02-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872



--- Comment #3 from Christopher Meng cicku...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 LGPL (v2.1 or later), GPL (v2 or later). Detailed output of
 licensecheck:

GPL (v2 or later)
-
libusbg-0.1.0/examples/gadget-acm-ecm.c
libusbg-0.1.0/examples/show-gadgets.c

LGPL (v2.1 or later)

libusbg-0.1.0/include/usbg/usbg.h
libusbg-0.1.0/src/usbg.c

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, 

[Bug 1057872] Review Request: libusbg - Library for USB gadget-configfs userspace functionality

2014-01-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1057872

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cicku...@gmail.com
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1. Remove Requires: pkgconfig(RPM will add it for you)

2. graphviz?

configure: WARNING: dot not found - will not generate graphics for doxygen
documentation

3. Tex helps?
checking for x86_64-redhat-linux-gnu-latex... no
checking for latex... no
configure: WARNING: latex not found - will not generate doxygen PostScript
documentation
checking for pdflatex... no
configure: WARNING: pdflatex not found - will not generate doxygen PDF
documentation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review