[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-deep-eql-0.1.3-1.fc2 |nodejs-deep-eql-0.1.3-2.el7 |0 | --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-deep-eql-0.1.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-deep-eql-0.1.3-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-deep-eql-0.1.3-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added CC||piotr1...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #8 from Piotr Popieluch piotr1...@gmail.com --- Package Change Request == Package Name: nodejs-deep-eql New Branches: el6 epel7 Owners: piotrp tomh jamielinux -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Bug 1060254 depends on bug 1060245, which changed state. Bug 1060245 Summary: Review Request: nodejs-simple-assert - Vanilla assertions for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=1060245 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-deep-eql-0.1.3-1.fc2 ||0 Resolution|--- |ERRATA Last Closed||2014-03-07 01:41:48 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-deep-eql-0.1.3-1.fc20, nodejs-type-detect-0.1.2-1.fc20, nodejs-simple-assert-1.0.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Bug 1060254 depends on bug 1060250, which changed state. Bug 1060250 Summary: Review Request: nodejs-type-detect - Improved typeof detection for Node.js and the browser https://bugzilla.redhat.com/show_bug.cgi?id=1060250 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-deep-eql-0.1.3-1.fc20, nodejs-type-detect-0.1.2-1.fc20, nodejs-simple-assert-1.0.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||jamieli...@fedoraproject.or ||g Assignee|nob...@fedoraproject.org|jamieli...@fedoraproject.or ||g Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254
--- Comment #1 from Jamie Nguyen jamieli...@fedoraproject.org ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
---
Checking: nodejs-deep-eql-0.1.3-1.fc21.noarch.rpm
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Looks good. Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Tom Hughes t...@compton.nu --- New Package SCM Request === Package Name: nodejs-deep-eql Short Description: Improved deep equality testing for Node.js and the browser Owners: tomh jamielinux Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- nodejs-deep-eql-0.1.3-1.fc20,nodejs-type-detect-0.1.2-1.fc20,nodejs-simple-assert-1.0.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-deep-eql-0.1.3-1.fc20,nodejs-type-detect-0.1.2-1.fc20,nodejs-simple-assert-1.0.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 Tom Hughes t...@compton.nu changed: What|Removed |Added Blocks||956806 (nodejs-reviews), ||1060030 Depends On||1060245, 1060250 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1060030 [Bug 1060030] nodejs-chai-1.9.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1060245 [Bug 1060245] Review Request: nodejs-simple-assert - Vanilla assertions for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=1060250 [Bug 1060250] Review Request: nodejs-type-detect - Improved typeof detection for Node.js and the browser -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
