[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Ed Marshall changed: What|Removed |Added CC||e...@logic.net --- Comment #10 from Ed Marshall --- It looks like this got pushed into Fedora as the name "golang-githu-mitchellh-cli-temporary" instead of the proper name, and without any provides (so it won't get picked up by a properly-configured package, only by something that explicitly pulls it in). So, uh...what happened? :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Jan Chaloupka changed: What|Removed |Added Flags||needinfo?(e...@logic.net) --- Comment #11 from Jan Chaloupka --- It is a temporary rpm. I don't have permissions to push to and build golang-github-mitchellh-cli. Once the real package gets build, I will remove the temporary one. Think, you could approve my request for permissions [1]? [1] https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-mitchellh-cli/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Ed Marshall changed: What|Removed |Added Flags|needinfo?(e...@logic.net)| --- Comment #12 from Ed Marshall --- I would if I could, but I think only sejeff (or a provenpackager?) will be able to do that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #13 from Jan Chaloupka --- I have contacted Jeff three times already asking for the permissions. Sadly, I have not been able to get them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #14 from Jeff Schroeder --- How do I give you permissions? I don't recall you contacting me anytime recently, but recall you asking once and me saying sure go nuts. I'll have to redo my FAS credentials but how do I give you access? I never pushed anything to Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #15 from Jan Chaloupka --- About a year ago? :) I don't recall it clearly. Should be enough to go here https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-mitchellh-cli/, client on "Manage the admins", set line with my name to "Approve" and "Apply Changes". Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #16 from Jeff Schroeder --- Jan, you've been added as an admin for this package. Sorry I suck so bad at life sometimes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #17 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a52932d849 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #19 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9b083b689 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #18 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7cb11f013 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #20 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-87dd824e11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #21 from Jan Chaloupka --- Thanks for the permission Jeff. This is something of a low priority so I was not in hurry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9b083b689 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #23 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7cb11f013 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #24 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-87dd824e11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #25 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a52932d849 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-06-14 23:00:35 --- Comment #26 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #27 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #28 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #29 from Fedora Update System --- golang-github-mitchellh-cli-0-0.1.git8102d0e.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Jan Chaloupka changed: What|Removed |Added Blocks||1212318 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1212318 [Bug 1212318] Review Request: golang-github-hashicorp-serf- Service orchestration and management tool http://www.serfdom.io -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Jeff Schroeder changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502
Dan Mashal changed:
What|Removed |Added
CC||dan.mas...@gmail.com
--- Comment #1 from Dan Mashal ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 16 files have unknown license. Detailed output of
licensecheck in /home/dan/fedora-review/1060502-golang-github-mitchellh-
cli/licensecheck.txt
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/gocode/src(golang-
github-gorilla-mux-devel, golang-googlecode-net-devel, golang-googlecode-
goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang-
googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang-
github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-
github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode
(golang-github-gorilla-mux-devel, golang-googlecode-net-devel, golang-
googlecode-goprotobuf-devel, golang-github-coreos-go-systemd-devel,
golang-googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel,
golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel,
golang-github-kr-pty-devel, golang-github-goraft-raft-devel),
/usr/share/gocode/src/github.com(golang-github-gorilla-mux-devel, golang-
github-syndtr-gocapability-devel, golang-github-coreos-go-systemd-devel,
golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel,
golang-github-kr-pty-devel, golang-github-goraft-raft-devel)
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502
Lokesh Mandvekar changed:
What|Removed |Added
CC||l...@redhat.com
--- Comment #2 from Lokesh Mandvekar ---
Hi Jeff,
I'm not sure if the noarch for rhel >= 7 would work right now. Last time I
checked, stuff was failing for some arch for rhel7 (I think ppc64). So I had
noarch only for fedora >= 19.
Did 'go test' work for you without specifying GOPATH? IIRC, it failed for me
sometime back, and I used this: GOPATH=%{buildroot}/%{gopath} go test
%{import_path}/capability
(line 45
http://pkgs.fedoraproject.org/cgit/golang-github-syndtr-gocapability.git/tree/golang-github-syndtr-gocapability.spec)
some minor things to consider (no biggie), for upstreams using git I've used
'shortcommit'
(http://pkgs.fedoraproject.org/cgit/golang-github-gorilla-context.git/tree/golang-github-gorilla-context.spec)
and for those using hg I've used 'shortrev'
(http://pkgs.fedoraproject.org/cgit/golang-bitbucket-kardianos-osext.git/tree/golang-bitbucket-kardianos-osext.spec).
The shortrev and abbrevrev could perhaps be replaced with a single shortcommit
here and it could be used in the release tag too. (Again, this is just the
current state of existing golang-* packages and _not_ a guideline.).
HTH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Peter Lemenkov changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #3 from Peter Lemenkov --- Removing FE-NEEDSPONSOR - I've just sponsored Jeff. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk Assignee|nob...@fedoraproject.org|lkund...@v3.sk Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502
--- Comment #4 from Lubomir Rintel ---
The above review makes sense. Just some random extra things I've verified
manually:
* Package is named correctly
* The version tag makes sense
* License tag is correct
* License is fine
* License text included
* rpmlint is happy
* SPEC file is clean and legible
Nothing severe really stands out; basically a couple of style issues:
0.) The description is a bit weird: Please do not repeat the summary and omit
the hyperlinks.
%description
This (cli) is the library for implementing powerful command-line
interfaces in Go. It's used by Self and Packer.
%description devel
This package contains the library for implementing powerful command-line
interfaces in Go. It's intended for building other packages which use these
functions.
1.) Please move BuildRequires ourside %package section.
2.) The package should always be noarch.
It only ships architecture-independent files. See [1]
[1]
https://fedoraproject.org/wiki/Packaging:Guidelines#Noarch_with_unported_dependencies
-%if 0%{?fedora} >= 19 || 0%{?rhel} >= 7
-BuildArch: noarch
-%else
-ExclusiveArch: %{ix86} x86_64 %{arm}
-%endif
+BuildArch: noarch
+%if 0%{?fedora} < 19 && 0%{?rhel} < 7
+ExclusiveArch: %{ix86} x86_64 %{arm} noarch
+%endif
3.) No need for the %attr macro; install files with correct mode in %install.
You won't need to list the whole hierarchy too.
-%dir %attr(755,root,root) %{gopath}
-%dir %attr(755,root,root) %{gopath}/src
-%dir %attr(755,root,root) %{gopath}/src/github.com
-%dir %attr(755,root,root) %{gopath}/src/github.com/mitchellh
-%dir %attr(755,root,root) %{gopath}/src/%{import_path}
-%attr(644,root,root) %{gopath}/src/%{import_path}/*.go
+%{gopath}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #5 from Jeff Schroeder --- Thanks for the help, I've addressed (I believe) all comments: [jeff@omniscience SPECS] (master)$ rpmlint golang-github-mitchellh-cli.spec ../SRPMS/golang-github-mitchellh-cli-0-0.1.git69f0b65.fc20.src.rpm ../RPMS/golang-github-mitchellh-cli-devel-0-0.1.git69f0b65.fc20.noarch.rpm Scratch build in koji looks good: https://koji.fedoraproject.org/koji/taskinfo?taskID=6887559 Updated Version: http://www.digitalprognosis.com/opensource/packages/golang-github-mitchellh-cli/golang-github-mitchellh-cli.spec http://www.digitalprognosis.com/opensource/packages/golang-github-mitchellh-cli/golang-github-mitchellh-cli-0-0.1.git69f0b65.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Lubomir Rintel changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Lubomir Rintel --- Seems all fine to me now. Thank you! APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Jeff Schroeder changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jeff Schroeder --- New Package SCM Request === Package Name: golang-github-mitchellh-cli Short Description: A library for implementing powerful command-line interfaces in Go Upstream URL: https://github.com/mitchellh/cli Owners: sejeff Branches: f19 f20 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Jan Chaloupka changed: What|Removed |Added CC||jchal...@redhat.com --- Comment #9 from Jan Chaloupka --- Hello. I am checking all golang packages from github. Just noticed this package has git done but there is no spec file committed so far. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
