[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Flags|fedora-review? | |needinfo?(mho...@redhat.com | |) | Last Closed|2014-09-13 17:33:59 |2015-05-27 08:28:31 --- Comment #17 from Parag AN(पराग) panem...@gmail.com --- I am closing this request. If anyone want to package this in Fedora please open a new bugzilla review request. Thanks all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #16 from Hans de Goede hdego...@redhat.com --- (In reply to Parag AN(पराग) from comment #15) any updates here? Martin no longer is with Red Hat, so his bugzilla email address no longer works. So unless we can find someone to take this review request over this review request should probably be closed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #15 from Parag AN(पराग) panem...@gmail.com --- any updates here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Tomas Pelka tpe...@redhat.com changed: What|Removed |Added Status|CLOSED |ASSIGNED CC||tpe...@redhat.com Resolution|WONTFIX |--- Keywords||Reopened -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Martin mho...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Last Closed||2014-09-13 17:33:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||mho...@redhat.com Flags||needinfo?(mho...@redhat.com ||) --- Comment #13 from Parag AN(पराग) panem...@gmail.com --- any updates here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #12 from Parag AN(पराग) panem...@gmail.com --- ping any updates here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #11 from Parag AN(पराग) panem...@gmail.com --- any update on above issue? Still bugzilla email id and email ID registered in FAS martix account differs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #9 from Martin Holec mho...@redhat.com --- Please read yellow note: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Create_a_Bugzilla_Account Bugzilla address connected with my Fedora Account can be different from FAS e-mail. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #10 from Parag AN(पराग) panem...@gmail.com --- What I am trying to say is that you submitted review request from bugzilla account which is linked to mho...@redhat.com whereas your FAS is showing mar...@martix.name I also read from your link is this The email address that you use for your bugzilla account should be the same email address as you use in the Fedora Account System for all things related to Fedora Packaging. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #3 from Hans de Goede hdego...@redhat.com --- Hi Parag, Martin, Parag, note that Martin needs a sponsor, Martin you should have marked this bug as needing a sponsor, I've done so for you now. Parag, I don't know if you can sponsor people, if you can and you're willing to sponser Martin, then great. If not let me know and I'll take over. Thanks Regards, Hans Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #4 from Parag AN(पराग) panem...@gmail.com --- I can sponsor him but I have not yet checked how many more package submissions he has done and/or how many (unofficial) package reviews done. I will check that later today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #5 from Parag AN(पराग) panem...@gmail.com --- Hi Martin, I can't find any other package review request submitted by you other than this package. Also, you have not done a single informal package review. If I am missing any of your reviews then please point me to those reviews. You may want to read - http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group If you need any other help please ask here or email me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #6 from Parag AN(पराग) panem...@gmail.com --- Just found your fas account is linked to mar...@martix.name which is different from the email id from which you have submitted this review request. Both email id's should be same. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #7 from Martin Holec mho...@redhat.com --- (In reply to Parag AN(पराग) from comment #6) Just found your fas account is linked to mar...@martix.name which is different from the email id from which you have submitted this review request. Both email id's should be same. This should be already fixed: https://fedorahosted.org/fedora-infrastructure/ticket/4222 Should I reopen the ticket? I will update spec and SRPM as I go through suggestions and linked guidelines. Quick note about license, source files are mixed MIT and GPLv2+: https://github.com/ssvb/xf86-video-fbturbo/blob/master/src/sunxi_disp_ioctl.h https://github.com/ssvb/xf86-video-fbturbo/blob/master/COPYING -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #8 from Parag AN(पराग) panem...@gmail.com --- 1) yes please reopen the ticket. I can still see your FAS info showing Account Name:martix Full Name:Martin Holec Email:mar...@martix.name 2) Right I missed to look at that file only ;-) you can use GPLv2+ as a license tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? --- Comment #2 from Parag AN(पराग) panem...@gmail.com --- Looks like spec is written using some existing old xorg package spec Review:- + Mock build is successful for f21 x86_64 + rpmlint on generated rpms gave output xorg-x11-drv-fbturbo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xf86-video-fbturbo-0.4.0/src/g2d_driver.h xorg-x11-drv-fbturbo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xf86-video-fbturbo-0.4.0/src/sunxi_disp_ioctl.h 3 packages and 0 specfiles checked; 2 errors, 0 warnings. == Ok + Source verified with upstream tarball as (sha256sum) upstream tarball 10411686de0a9d8b2cde300b0d68e9f1d22e3611470d357ef3afc337f123ca0f srpm tarball 10411686de0a9d8b2cde300b0d68e9f1d22e3611470d357ef3afc337f123ca0f - License is NOT valid. It should be MIT as per written in source files headers. Suggestions: 1) %define should be replaced by %global Reference - https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define 2) group tag line is not needed now anymore Reference - https://fedoraproject.org/wiki/:Guidelines#Group_tag 3) removing the buildroot in (first line of) %install is not needed now, remove it. Reference - https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 4) %clean is not needed now Reference - https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean 5) Files installed should preserve timestamp, you can do that using make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p Reference - https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps 6) %description can also add lines X.Org X11 fbturbo video driver, primarily optimized for the devices powered by the Allwinner SoC (A10, A13, A20). It can use some of the 2D/3D hardware acceleration features. 7) Fix license tag 8) Should contact upstream to get fsf address corrected as reported by rpmlint output. I also observed that build.log is showing following lines sh: xserver-sdk-abi-requires: command not found sh: xserver-sdk-abi-requires: command not found Package xorg-server was not found in the pkg-config search path. Perhaps you should add the directory containing `xorg-server.pc' to the PKG_CONFIG_PATH environment variable No package 'xorg-server' found I am not sure if its an issue with macro expansion in Requires: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||mar...@martix.name --- Comment #1 from Christopher Meng cicku...@gmail.com --- *** Bug 1062311 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
