[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libdatrie-0.2.8-4.fc20 Resolution|--- |ERRATA Last Closed||2014-07-13 20:53:27 --- Comment #25 from Fedora Update System --- libdatrie-0.2.8-4.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #24 from Fedora Update System --- libdatrie-0.2.8-4.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 --- Comment #23 from Fedora Update System --- libdatrie-0.2.8-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libdatrie-0.2.8-4.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 --- Comment #22 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Christopher Meng changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from Christopher Meng --- Thanks.. New Package SCM Request === Package Name: libdatrie Short Description: Implementation of Double-Array structure for representing trie Upstream URL: http://linux.thai.net/projects/datrie Owners: cicku ueno Branches: f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(dominik@greysecto | |r.net) | --- Comment #20 from Dominik 'Rathann' Mierzejewski --- Nice and smart fix. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Christopher Meng changed: What|Removed |Added Flags||needinfo?(dominik@greysecto ||r.net) --- Comment #19 from Christopher Meng --- NEW SPEC URL: http://us-la.cicku.me/libdatrie.spec NEW SRPM URL: http://us-la.cicku.me/libdatrie-0.2.8-4.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
--- Comment #18 from Dominik 'Rathann' Mierzejewski ---
(In reply to Christopher Meng from comment #17)
> No sweat, I understand your logic now:
>
> Here is my new %files section:
>
> %doc COPYING
> %{_libdir}/libdatrie.so.*
> %exclude %{_pkgdocdir}/*.css
> %exclude %{_pkgdocdir}/*.html
> %exclude %{_pkgdocdir}/*.js
> %exclude %{_pkgdocdir}/*.png
>
> %files devel
> %doc AUTHORS ChangeLog NEWS README*
> %{_pkgdocdir}/*.css
> %{_pkgdocdir}/*.html
> %{_pkgdocdir}/*.js
> %{_pkgdocdir}/*.png
> %{_includedir}/datrie/
> %{_libdir}/libdatrie.so
> %{_libdir}/pkgconfig/datrie-0.2.pc
> %{_bindir}/trietool*
>
> Note that I don't want to put useless files for end users in main-pkg, I
> hope you can understand. Thus only the license file packaged in main-pkg.
That is OK. I personally like to read ChangeLogs and READMEs from time to time,
but that's not a review blocker.
> Is it OK? If so please set + on this review, thanks in advance.
Not quite. The %doc macro in -devel subpackage will put the listed files
in /usr/share/doc/libdatrie-devel instead of libdatrie. If you're putting the
HTML docs from -devel in /usr/share/doc/libdatrie, you should be consistent and
put all the docs there.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
--- Comment #17 from Christopher Meng ---
No sweat, I understand your logic now:
Here is my new %files section:
%doc COPYING
%{_libdir}/libdatrie.so.*
%exclude %{_pkgdocdir}/*.css
%exclude %{_pkgdocdir}/*.html
%exclude %{_pkgdocdir}/*.js
%exclude %{_pkgdocdir}/*.png
%files devel
%doc AUTHORS ChangeLog NEWS README*
%{_pkgdocdir}/*.css
%{_pkgdocdir}/*.html
%{_pkgdocdir}/*.js
%{_pkgdocdir}/*.png
%{_includedir}/datrie/
%{_libdir}/libdatrie.so
%{_libdir}/pkgconfig/datrie-0.2.pc
%{_bindir}/trietool*
Note that I don't want to put useless files for end users in main-pkg, I hope
you can understand. Thus only the license file packaged in main-pkg.
Is it OK? If so please set + on this review, thanks in advance.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
Flags|needinfo?(dominik@greysecto |
|r.net) |
--- Comment #16 from Dominik 'Rathann' Mierzejewski ---
So you did, but now all the API docs are in the main package instead of -devel.
I don't think that was intended, either. You can use the _pkgdocdir macro like
Ralf suggested, but you must %exclude the files that should be in the -devel
package in %files section for the main package.
For example, like this (I'd keep AUTHORS COPYING ChangeLog NEWS README in the
main package):
%files
%doc AUTHORS COPYING ChangeLog NEWS README
%exclude %{_pkgdocdir}/*.html
%exclude %{_pkgdocdir}/*.png
%exclude %{_pkgdocdir}/*.js
%exclude %{_pkgdocdir}/*.css
%exclude %{_pkgdocdir}/README.migration
%{_libdir}/libdatrie.so.*
%files devel
%{_pkgdocdir}/*.html
%{_pkgdocdir}/*.png
%{_pkgdocdir}/*.js
%{_pkgdocdir}/*.css
%{_pkgdocdir}/README.migration
%{_includedir}/datrie/
%{_libdir}/libdatrie.so
%{_libdir}/pkgconfig/datrie-0.2.pc
%{_bindir}/trietool*
%{_mandir}/man1/trietool*.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Christopher Meng changed: What|Removed |Added Flags||needinfo?(dominik@greysecto ||r.net) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
--- Comment #15 from Christopher Meng ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #14)
> Scratch that.
> With the
>
> %files devel
> %{_pkgdocdir}/
>
> change, both libdatrie and libdatrie-devel hold all doc files now, which I
> don't think was intended. Please fix the doc file duplication.
I've rearranged the %doc:
https://mega.co.nz/#!CIxggKRK!r7F7_3cZhOPya9OXOsFqKLTah1tv0H53k-sfHYMgNC0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
Flags|fedora-review+ |fedora-review?
--- Comment #14 from Dominik 'Rathann' Mierzejewski ---
Scratch that.
With the
%files devel
%{_pkgdocdir}/
change, both libdatrie and libdatrie-devel hold all doc files now, which I
don't think was intended. Please fix the doc file duplication.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(dominik@greysecto | |r.net) | --- Comment #13 from Dominik 'Rathann' Mierzejewski --- rpath issue is gone, good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
Christopher Meng changed:
What|Removed |Added
CC||domi...@greysector.net
Flags||needinfo?(dominik@greysecto
||r.net)
--- Comment #12 from Christopher Meng ---
(In reply to Ralf Corsepius from comment #11)
> I hate packages, which install docs into a different directory but
> /usr/share/doc/. These days, there isn't any reason for not doing
> so.
>
> All you need to do is to install these docs just like normal files and to
> reference them as normal files.
> This basically boils donw to not use %doc in %files but to
> use
> %{_pkgdocdir}/
It's not a big problem, though. I've addressed the issue.
Due to bad Internet connection in China now, I've uploaded the SRPM to cloud
disk(not publicly accessible):
NEW SRPM URL:
https://mega.co.nz/#!yIZxlIoJ!b7n-scDAJfEa3tsBZbJ9Gi7zdNJRpyQJCnbljY_ZviM
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
Ralf Corsepius changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #11 from Ralf Corsepius ---
I hate packages, which install docs into a different directory but
/usr/share/doc/. These days, there isn't any reason for not doing so.
All you need to do is to install these docs just like normal files and to
reference them as normal files.
This basically boils donw to not use %doc in %files but to use
%{_pkgdocdir}/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Christopher Meng changed: What|Removed |Added Whiteboard|NotReady| --- Comment #10 from Christopher Meng --- Hi, I hacked and finished: SPEC URL: http://misc.cicku.me/fedora/libdatrie.spec SRPM URL: http://misc.cicku.me/fedora/libdatrie-0.2.8-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Michael Schwendt changed: What|Removed |Added Whiteboard||NotReady --- Comment #9 from Michael Schwendt --- > http://cicku.me/libdatrie.spec | Not Found | | The requested URL /libdatrie.spec was not found on this server. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Daiki Ueno changed: What|Removed |Added CC||du...@redhat.com --- Comment #8 from Daiki Ueno --- Any update? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 --- Comment #7 from Dominik 'Rathann' Mierzejewski --- Unfortunately, the rpath is still there: [...] INFO: Done(build/RPMS/libdatrie-0.2.8-3.fc20.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 36 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-x86_64/result Finish: run $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result [...] libdatrie-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/trietool-0.2 ['/usr/lib64'] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 --- Comment #6 from Christopher Meng --- Spec URL: http://cicku.me/libdatrie.spec SRPM URL: http://cicku.me/libdatrie-0.2.8-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 --- Comment #5 from Christopher Meng --- (In reply to Dominik 'Rathann' Mierzejewski from comment #4) > rpmlint found rpath in trietool: > > libdatrie-devel.x86_64: E: binary-or-shlib-defines-rpath > /usr/bin/trietool-0.2 ['/usr/lib64'] > > Out of curiosity, do you know why it's suffixed with the version number? > > Otherwise it looks fine. Please fix the rpath and I'll approve. Haha I know. I've had same question in my mind when I packaged this package, and I tell upstream and he said that it was intended for API bump, but now it seems it's useless and confusing, he will remove it later maybe. On Fri, Feb 7, 2014 at 3:46 PM, Christopher Meng wrote: > Can you rename trietool-0.2 to trietool? > > Why 0.2 suffixed? Because when releasing 0.2.0, it broke ABI with 0.1.x, and both versions were expected to be installed together. Now that libdatrie 0.1.x has been obsolete for a long time, I'm considering dropping the suffix, with backward compatibility in mind. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|domi...@greysector.net Flags||fedora-review? --- Comment #4 from Dominik 'Rathann' Mierzejewski --- rpmlint found rpath in trietool: libdatrie-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/trietool-0.2 ['/usr/lib64'] Out of curiosity, do you know why it's suffixed with the version number? Otherwise it looks fine. Please fix the rpath and I'll approve. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 --- Comment #3 from Christopher Meng --- Fixed: Spec URL: http://cicku.me/libdatrie.spec SRPM URL: http://cicku.me/libdatrie-0.2.8-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
--- Comment #2 from Michael Schwendt ---
%check
make check
is missing.
> %files devel
> %doc AUTHORS ChangeLog NEWS README*
> %doc %{_docdir}/%{name}-devel
This causes "File listed twice" warnings on F20 or newer due to the unversioned
docdirs feature. The line that includes the local %doc files also includes
anything in its docdir (here %{_docdir}/%{name}-devel).
https://fedorahosted.org/fpc/ticket/338
Installing into a temporary directory --with-html-docdir=$(pwd)/something would
be one work-around, because then you could use %doc magic to include the local
tree.
> %doc %{_docdir}/%{name}-devel
Anything below %_docdir is marked %doc implicitly (rpm -E %__docdir_path).
> %files utils
> %{_bindir}/trietool-0.2
> %{_mandir}/man1/trietool-0.2.1*
What's the reason this developer tool is put into a separate package?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Christopher Meng changed: What|Removed |Added Blocks|201449 (FE-DEADREVIEW) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Christopher Meng changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) CC||auri...@gmail.com --- Comment #1 from Christopher Meng --- *** Bug 733925 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542 Christopher Meng changed: What|Removed |Added Blocks||1062540 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1062540 [Bug 1062540] Unbundle libdatrie -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
