[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 David King changed: What|Removed |Added Status|NEW |ASSIGNED CC||amigad...@amigadave.com Assignee|nob...@fedoraproject.org|amigad...@amigadave.com Flags||fedora-review? --- Comment #1 from David King --- Will look at this today (swap with bug 1077810). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 David King changed: What|Removed |Added CC||cicku...@gmail.com Flags||needinfo?(cicku...@gmail.co ||m) --- Comment #2 from David King --- I cannot seem to fetch the spec nor SRPM: ERROR: 'Error [Errno socket error] [Errno 111] Connection refused downloading http://cicku.me/mandelbulber-1.21-1.fc21.src.rpm' Can you check it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Christopher Meng changed: What|Removed |Added Flags|needinfo?(cicku...@gmail.co | |m) | --- Comment #3 from Christopher Meng --- (In reply to David King from comment #2) > I cannot seem to fetch the spec nor SRPM: > > ERROR: 'Error [Errno socket error] [Errno 111] Connection refused > downloading http://cicku.me/mandelbulber-1.21-1.fc21.src.rpm' > > Can you check it? Oh, I nearly forgot that my website is down for maintenance, please try later from the URL. SRPM(1 week only): http://www.tempfiles.net/download/201403/341006/mandelbulber-1.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610
David King changed:
What|Removed |Added
Flags||needinfo?(cicku...@gmail.co
||m)
--- Comment #4 from David King ---
Functionally fine, just the Boost license problem to fix. The other "issues"
are all optional.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
Issues:
===
- update-desktop-database is invoked in %post and %postun if package contains
desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in mandelbulber
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
Bogus, as the MimeType entry is empty. Upstream should be informed so that the
line can be removed.
- BSL (Boost) license
src/clew.cpp lists:
// Distributed under the Boost Software License, Version 1.0.
// (See accompanying file license.txt)
license.txt should be included, as the Boost license requires that. :-/
Upstream should be informed (License field is fine)
- examples in /usr/share
The .c files (examplesOCLformulas) probably do not need to be installed at all,
but their presence currently throws up an rpmlint warning. The other examples
could be split into a noarch subpackage, but that is just a suggestion.
- rpmlint spelling errors
Bogus, ignore.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)", "BSL (v1.0)", "Unknown or generated". 48 files have
unknown license. Detailed output of licensecheck in
/home/david/checkout/rpms/mandelbulber/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 71680 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the u
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Christopher Meng changed: What|Removed |Added Flags|needinfo?(i...@cicku.me) | --- Comment #5 from Christopher Meng --- Thanks for the review. 1. Mimetype rpmlint warning can be safely ignored. 2. License problem is not a problem actually, it's a typo. Quoted from upstream reply: "Hi I have substituted src/clew.cpp file with the file which contains following header: // // Copyright (c) 2009 Organic Vectory B.V. // Written by George van Venrooij // // Distributed under the Boost Software License, Version 1.0. //(See accompanying file LICENSE_1_0.txt or copy at // http://www.boost.org/LICENSE_1_0.txt) // It links now to the license file witch is on boost.org website Actual source package is here: https://sourceforge.net/projects/mandelbulber/files/mandelbulber1.21-1.orig.tar.gz/download Best regards Krzysztof" Upstream had updated the source file since he received the report from me. 3. I'd like to leave those underneath %_datadir intact. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #6 from David King --- (In reply to Christopher Meng from comment #5) > 2. License problem is not a problem actually, it's a typo. > > Quoted from upstream reply: > > "Hi > > I have substituted src/clew.cpp file with the file which contains following > header: > > // > // Copyright (c) 2009 Organic Vectory B.V. > // Written by George van Venrooij > // > // Distributed under the Boost Software License, Version 1.0. > //(See accompanying file LICENSE_1_0.txt or copy at > // http://www.boost.org/LICENSE_1_0.txt) > // > > It links now to the license file witch is on boost.org website > > Actual source package is here: > https://sourceforge.net/projects/mandelbulber/files/mandelbulber1.21-1.orig. > tar.gz/download > > Best regards >Krzysztof" > > Upstream had updated the source file since he received the report from me. The Boost license requires that the license text is supplied with the source code (as you can see if you read the license in full, specifically the second paragraph). According to the Fedora licensing guidelines, if such a license is used, the license must either be included in the upstream tarball, or supplied as a separate source file and included in %doc: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Directing to a URL for the Boost license is not sufficient. It must be included, and so the upstream change is insufficient. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #7 from Christopher Meng --- Is it OK for packager to add the license? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #8 from David King --- Hi Christopher. Yes, it is absolutely fine for the packager to include the license, if they are sure which license is used. In this case, you know that the license is the Boost license, so including the license text as a separate Source, and including it in the package with %doc, is correct. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #9 from Pavel Alexeev (aka Pahan-Hubbitus) --- https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text said: "If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake.". Later: "However, in situations where upstream is unresponsive, unable, or unwilling to provide proper full license text as part of the source code, and the indicated license requires that the full license text be included, Fedora Packagers must either: Include a copy of what they believe the license text is intended to be, as part of the Fedora package in %doc, in order to remain in compliance." So, packager may include license separately only if upstream irresponsible or refuse such inclusion request. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #10 from Christopher Meng --- Thank you Pavel and David, I've attached it into the new SPEC/SRPM: SPEC: http://misc.cicku.me/fedora/mandelbulber.spec SRPM: http://misc.cicku.me/fedora/mandelbulber-1.21-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 David King changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from David King --- License change looks good to me. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Christopher Meng changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Christopher Meng --- New Package SCM Request === Package Name: mandelbulber Short Description: Advanced 3D fractal generator Upstream URL: http://www.mandelbulber.com/ Owners: cicku Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #14 from Pavel Alexeev (aka Pahan-Hubbitus) --- Upstream author refuse request include it in tarball? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #15 from Christopher Meng --- (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #14) > Upstream author refuse request include it in tarball? Maybe, since I haven't got any response from him. He is offline/busy now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #17 from Fedora Update System --- mandelbulber-1.21-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mandelbulber-1.21-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 --- Comment #16 from Fedora Update System --- mandelbulber-1.21-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mandelbulber-1.21-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- mandelbulber-1.21-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mandelbulber-1.21-2.fc20 Resolution|--- |ERRATA Last Closed||2014-06-24 19:21:18 --- Comment #19 from Fedora Update System --- mandelbulber-1.21-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065610] Review Request: mandelbulber - Advanced 3D fractal generator
https://bugzilla.redhat.com/show_bug.cgi?id=1065610 Fedora Update System changed: What|Removed |Added Fixed In Version|mandelbulber-1.21-2.fc20|mandelbulber-1.21-2.fc19 --- Comment #20 from Fedora Update System --- mandelbulber-1.21-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
