[Bug 1065627] Review Request: pire - Perl Incompatible Regular Expressions library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065627

Kamil Dudka  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |WONTFIX
Last Closed||2016-07-08 09:09:09



--- Comment #3 from Kamil Dudka  ---
Staled since February 2014.  URLs in comment #0 do not seem to work any more. 
Closing...


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1065627] Review Request: pire - Perl Incompatible Regular Expressions library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065627

Kamil Dudka kdu...@redhat.com changed:

   What|Removed |Added

 CC||i...@cicku.me
  Flags|needinfo?   |needinfo?(i...@cicku.me)



--- Comment #2 from Kamil Dudka kdu...@redhat.com ---
There seems to be no progress in the past 18 months.  Christopher, is this
review request still valid?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1065627] Review Request: pire - Perl Incompatible Regular Expressions library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065627

Kamil Dudka kdu...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?



--- Comment #1 from Kamil Dudka kdu...@redhat.com ---
- %description contains trailing white spaces and few typos:
maches - matches
mantaining - maintaining
apx.10 - apx. 10
realtime   - real-time
nongreedy  - non-greedy

- I would move running autoreconf to %prep assuming it really needs to be run
(a comment justifying it would help)

- obsolete macro AC_PROG_LIBTOOL found in: pire-release-0.0.5/configure.ac:15

- running autoreconf with recent autotools produces a lot of warnings:

pire/Makefile.am:11: warning: source file 'scanners/null.cpp' is in a
subdirectory,
pire/Makefile.am:11: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the
'subdir-objects'
automake: automake option hasn't been enabled.  For now, the corresponding
output
automake: object file(s) will be placed in the top-level directory. 
However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same
subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout
your
automake: project, to avoid future incompatibilities.
pire/Makefile.am:11: warning: source file 'stub/utf8.cpp' is in a
subdirectory,
pire/Makefile.am:11: but option 'subdir-objects' is disabled
pire/Makefile.am:56: warning: source file 'extra/capture.cpp' is in a
subdirectory,
pire/Makefile.am:56: but option 'subdir-objects' is disabled
pire/Makefile.am:56: warning: source file 'extra/count.cpp' is in a
subdirectory,
pire/Makefile.am:56: but option 'subdir-objects' is disabled
pire/Makefile.am:56: warning: source file 'extra/glyphs.cpp' is in a
subdirectory,
pire/Makefile.am:56: but option 'subdir-objects' is disabled
/usr/share/automake-1.14/am/ltlibrary.am: warning: 'libpire.la': linking
libtool libraries using a non-POSIX
/usr/share/automake-1.14/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in
'configure.ac'
pire/Makefile.am:10:   while processing Libtool library 'libpire.la'
pire/Makefile.am: installing './depcomp'
configure.ac: installing './ylwrap'
tests/Makefile.am:10: warning: source file 'stub/cppunit.cpp' is in a
subdirectory,
tests/Makefile.am:10: but option 'subdir-objects' is disabled
/usr/share/automake-1.14/am/ltlibrary.am: warning: 'libpire_unit.la':
linking libtool libraries using a non-POSIX
/usr/share/automake-1.14/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in
'configure.ac'
tests/Makefile.am:9:   while processing Libtool library 'libpire_unit.la'
parallel-tests: installing './test-driver'
autoreconf: Leaving directory `.'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1065627] Review Request: pire - Perl Incompatible Regular Expressions library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065627

Kamil Dudka kdu...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||kdu...@redhat.com
   Assignee|nob...@fedoraproject.org|kdu...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review