[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||birdie-1.1-1.fc20 Resolution|--- |ERRATA Last Closed||2014-03-02 22:11:08 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- birdie-1.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- birdie-1.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #25 from Christopher Meng cicku...@gmail.com --- (In reply to Mukundan Ragavan from comment #22) Ryan, That looks good. I think almost everything is done. Just a couple of minor issues and then I think it's done. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/indicators, /usr/share/indicators/messages, /usr/share/locale/sr_RS@latin, /usr/share/indicators/messages/applications [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/indicators, /usr/share/locale/sr_RS@latin, /usr/share/indicators/messages/applications, /usr/share/appdata, /usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/indicators/messages Here, based on my discussion on #fedora-devel, we can ignore the messages about the locales since these should be owned by the filesystem. If it's a bug in filesystem package, please report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747
--- Comment #26 from Ryan Lerch rle...@redhat.com ---
(In reply to Mukundan Ragavan from comment #22)
Ryan, That looks good. I think almost everything is done. Just a couple of
minor issues and then I think it's done.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/sr_RS@latin/LC_MESSAGES,
/usr/share/indicators, /usr/share/indicators/messages,
/usr/share/locale/sr_RS@latin,
/usr/share/indicators/messages/applications
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/indicators,
/usr/share/locale/sr_RS@latin,
/usr/share/indicators/messages/applications, /usr/share/appdata,
/usr/share/locale/sr_RS@latin/LC_MESSAGES,
/usr/share/indicators/messages
Here, based on my discussion on #fedora-devel, we can ignore the messages
about the locales since these should be owned by the filesystem.
The package must own /usr/share/indicators.
So, add in %files section
%{_datadir}/indicators/*
instead of /usr/share/indicators/messages/applications/birdie so that the
directory is owned by the package.
Based on -
https://fedoraproject.org/wiki/Packaging:
Guidelines#The_directory_is_wholly_contained_in_your_package.
2C_or_involves_core_functionality_of_your_package
I believe that should be it.
If you could please fix that, upload the spec and srpm (link is broken), I
can run fedora-review again (just in case) and approve the package.
Thanks, Updated and pushed to my git repo here.
https://github.com/ryanlerch/my-fedora-package-reviews/commit/b85b072fea776ff597f50219d5b20025acea9510
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #27 from Ryan Lerch rle...@redhat.com --- Spec URL: https://raw.github.com/ryanlerch/my-fedora-package-reviews/master/birdie/birdie.spec SRPM URL: https://github.com/ryanlerch/my-fedora-package-reviews/raw/master/birdie/birdie-1.1-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #28 from Mukundan Ragavan nonamed...@gmail.com --- Would you be interested in looking in to updating the description and summary as per Michael's suggestion (comment #24)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #29 from Mukundan Ragavan nonamed...@gmail.com --- (In reply to Christopher Meng from comment #25) If it's a bug in filesystem package, please report. Christopher, It's already done in rawhide. $ rpm -qf /usr/share/locale/sr_RS@latin filesystem-3.2-24.fc21.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #30 from Ryan Lerch rle...@redhat.com --- (In reply to Mukundan Ragavan from comment #28) Would you be interested in looking in to updating the description and summary as per Michael's suggestion (comment #24)? I am happy with the way it is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747
Mukundan Ragavan nonamed...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #31 from Mukundan Ragavan nonamed...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v3 or later), Unknown or generated. 41 files have unknown
license. Detailed output of licensecheck in
/home/mukundan/personal/pkgs/reviews/1068747-birdie/licensecheck.txt
--- This is fine.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/sr_RS@latin/LC_MESSAGES,
/usr/share/locale/sr_RS@latin
--- Verified that these directories are owned by filesystem in rawhide.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/appdata,
/usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/locale/sr_RS@latin
--- This is fine. appdata is owned by other packages in rawhide.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: glib-compile-schemas is run in %postun and %posttrans if package has
*.gschema.xml files.
Note: gschema file(s) in birdie
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in birdie
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in birdie
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Ryan Lerch rle...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #32 from Ryan Lerch rle...@redhat.com --- New Package SCM Request === Package Name: birdie Short Description: A twitter client for Linux Owners: ryanlerch Branches: f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #33 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- birdie-1.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/birdie-1.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #15 from Ryan Lerch rle...@redhat.com --- (In reply to Mukundan Ragavan from comment #14) That looks good Ryan. Please also fix the LOCALE issues as described in wiki (comment 6) Thanks Mukundan! Fixed the LOCALE issue with the following commit: https://github.com/ryanlerch/my-fedora-package-reviews/commit/ad915157a2b06cfe040b4e5d862212b15c128fbd cheers, ryanlerch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747
--- Comment #16 from Mukundan Ragavan nonamed...@gmail.com ---
That fixes the locale problem. There are few other issues. Please see below.
Also, please do a koji scratch build.
Please add
BuildRequires: desktop-file-utils
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- update-desktop-database is invoked in %post and %postun if package contains
desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in birdie
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v3 or later), Unknown or generated. 41 files have unknown
license. Detailed output of licensecheck in
/home/mukundan/personal/pkgs/reviews/birdie/licensecheck.txt
--- This looks fine.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/sr_RS@latin/LC_MESSAGES,
/usr/share/indicators, /usr/share/indicators/messages,
/usr/share/locale/sr_RS@latin,
/usr/share/indicators/messages/applications
--- I have to look at it further.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/indicators,
/usr/share/locale/sr_RS@latin,
/usr/share/indicators/messages/applications, /usr/share/appdata,
/usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/indicators/messages
--- This looks fine.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: glib-compile-schemas is run in %postun and %posttrans if package has
*.gschema.xml files.
Note: gschema file(s) in birdie
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in birdie
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]:
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #17 from Mukundan Ragavan nonamed...@gmail.com --- OK, I took care of the koji builds. The package builds on all architectures (with BR added spec file and SRPM). http://koji.fedoraproject.org/koji/taskinfo?taskID=6566098 Please make sure BuildRequires: desktop-file-utils is added. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #18 from Ryan Lerch rle...@redhat.com --- so all left to do is to add desktop-file-utils to the buildrequires? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #19 from Mukundan Ragavan nonamed...@gmail.com --- And this, Issues: === - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in birdie See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #20 from Mukundan Ragavan nonamed...@gmail.com --- I am looking at the packaging guidelines again to confirm the status on this - [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/indicators, /usr/share/indicators/messages, /usr/share/locale/sr_RS@latin, /usr/share/indicators/messages/applications --- I have to look at it further. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/indicators, /usr/share/locale/sr_RS@latin, /usr/share/indicators/messages/applications, /usr/share/appdata, /usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/indicators/messages --- I have to look at it further. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #21 from Ryan Lerch rle...@redhat.com --- (In reply to Mukundan Ragavan from comment #19) And this, Issues: === - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in birdie See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database Okies, these two should be fixed in this commit: https://github.com/ryanlerch/my-fedora-package-reviews/commit/55249ef30961e67cd3a0f4bfe4747cc084a2fee5 Also kicked off a koji build with this new version: http://koji.fedoraproject.org/koji/taskinfo?taskID=6566800 cheers, ryanlerch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747
--- Comment #22 from Mukundan Ragavan nonamed...@gmail.com ---
Ryan, That looks good. I think almost everything is done. Just a couple of
minor issues and then I think it's done.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/sr_RS@latin/LC_MESSAGES,
/usr/share/indicators, /usr/share/indicators/messages,
/usr/share/locale/sr_RS@latin,
/usr/share/indicators/messages/applications
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/indicators,
/usr/share/locale/sr_RS@latin,
/usr/share/indicators/messages/applications, /usr/share/appdata,
/usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/indicators/messages
Here, based on my discussion on #fedora-devel, we can ignore the messages about
the locales since these should be owned by the filesystem.
The package must own /usr/share/indicators.
So, add in %files section
%{_datadir}/indicators/*
instead of /usr/share/indicators/messages/applications/birdie so that the
directory is owned by the package.
Based on -
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_wholly_contained_in_your_package.2C_or_involves_core_functionality_of_your_package
I believe that should be it.
If you could please fix that, upload the spec and srpm (link is broken), I can
run fedora-review again (just in case) and approve the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747
--- Comment #23 from Mukundan Ragavan nonamed...@gmail.com ---
Sorry! There is a typo - my comment should read as -
add in %files section
%{_datadir}/indicators/
This will own everything under it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #24 from Michael Schwendt bugs.mich...@gmx.net --- Summary:A twitter client for Linux Even more concise would be: Summary: Twitter client Or, since the %description mentions GNOME, also mention GNOME in the %summary if it's considered relevant. https://fedoraproject.org/wiki/Examples_of_good_package_summaries It's widely accepted practice to omit leading articles, such as A, An and The. There are exceptions, however. %description A beautiful GNOME Twitter client for Linux The description ought to be built from full sentences including punctuation marks. The upstream spec file at https://github.com/birdieapp/birdie/blob/master/birdie.spec contains: Birdie is a beautiful Twitter client for Linux. For the description and unlike %summary, it isn't a bad idea to repeat the program name with its correct spelling. For both summary and description, why is Linux mentioned? Is that important? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #10 from Christopher Meng cicku...@gmail.com --- (In reply to Mukundan Ragavan from comment #9) Is the granite build requires needed for birdie to work in pantheon - because, it seems to build fine without granite at the moment ... (I can verify that again). It's an optional requirement, I will track it and file bug later after this gets approved. So currently we don't need it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #11 from Ryan Lerch rle...@redhat.com --- (In reply to Christopher Meng from comment #7) Thanks for packaging birdie, I finally don't need to submit it by myself. 1. Summary: A twitter client for Linux Since we all use Linux, this summary looks not perfect, would you like to improve it? With some fantastic words if you can... Summary is okay. It is concise, and accurately describes what birdie is. 2. I see an appdata file, I just talked with Richard, and I think we need to improve the guideline like desktop file, so please use that tool provided from appdata to validate or install the file. I have had reviews before that contain appdata files, and i included them in the same manner as this package. If you want the packaging guidelines changed, please email devel-list. This is not the best place to discuss new packaging guidlines. Leaving the appdata inclusion the same -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #12 from Ryan Lerch rle...@redhat.com --- (In reply to Christopher Meng from comment #8) 3. %description bad, please visit upstream and give some love here. Please clarify what makes it bad. I have no idea what you mean here. The description also concisely desribes what the birdie package is and does. 4. Granite is going to be included in Fedora. You can add it later as BR. granite is not in fedora, and is an optional BuildRequires. File a bug once the package is in. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747
--- Comment #13 from Ryan Lerch rle...@redhat.com ---
(In reply to Mukundan Ragavan from comment #5)
Just noticed - the release tag should start with 1 - as in - 1%{?dist}
Quoting from the naming guidelines -
... The release number (referred to in some older documentation as a
vepoch) is how the maintainer marks build revisions, starting from 1. ...
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
Thanks Mukundan!
I have fixed this in this commit:
https://github.com/ryanlerch/my-fedora-package-reviews/commit/fad7d705244513a3730e63cb71087e13b7b4931a
cheers,
ryanlerch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #14 from Mukundan Ragavan nonamed...@gmail.com --- That looks good Ryan. Please also fix the LOCALE issues as described in wiki (comment 6) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Christopher Meng cicku...@gmail.com changed: What|Removed |Added URL||https://fedoraproject.org/w ||iki/Changes/PantheonDesktop CC||cicku...@gmail.com Blocks||1068850 (Pantheon) --- Comment #8 from Christopher Meng cicku...@gmail.com --- 3. %description bad, please visit upstream and give some love here. 4. Granite is going to be included in Fedora. You can add it later as BR. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1068850 [Bug 1068850] Fedora 22 Change Pantheon Desktop tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Alias||birdie -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #9 from Mukundan Ragavan nonamed...@gmail.com --- Is the granite build requires needed for birdie to work in pantheon - because, it seems to build fine without granite at the moment ... (I can verify that again). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Mukundan Ragavan nonamed...@gmail.com changed: What|Removed |Added CC||nonamed...@gmail.com --- Comment #1 from Mukundan Ragavan nonamed...@gmail.com --- Some quick comments - * gcc-c++ does not need to explicitly specified in BuildRequires * source URL missing --- https://github.com/birdieapp/birdie/archive/1.1.tar.gz rpmlint output - birdie.x86_64: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/tr/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/vi/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/birdie.mo birdie.src: W: strange-permission birdie-1.1.tar.gz 0600L birdie.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2) birdie.src: W: invalid-url Source0: birdie-1.1.tar.gz 2 packages and 0 specfiles checked; 0 errors, 32 warnings. Some information from minGW on file-not-in%lang - http://fedoraproject.org/wiki/MinGW/Rpmlint#file-not-in-.25lang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #2 from Ryan Lerch rle...@redhat.com --- (In reply to Mukundan Ragavan from comment #1) Some quick comments - * gcc-c++ does not need to explicitly specified in BuildRequires Fixed. * source URL missing --- https://github.com/birdieapp/birdie/archive/1.1.tar.gz That URL actually resolves to download birdie-1.1.tar.gz. Added a comment above the source0 line stating that this is the URL. Is there a better way to handle it? rpmlint output - birdie.x86_64: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/tr/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/vi/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/birdie.mo birdie.x86_64: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/birdie.mo birdie.src: W: strange-permission birdie-1.1.tar.gz 0600L birdie.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2) birdie.src: W: invalid-url Source0: birdie-1.1.tar.gz 2 packages and 0 specfiles checked; 0 errors, 32 warnings. Some information from minGW on file-not-in%lang - http://fedoraproject.org/wiki/MinGW/Rpmlint#file-not-in-.25lang removed the stray tab that got in there. Also, how did you run rpmline to get the file-not-in%lang errors? I can not reproduce those. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #3 from Ryan Lerch rle...@redhat.com --- (In reply to Ryan Lerch from comment #2) (In reply to Mukundan Ragavan from comment #1) * source URL missing --- https://github.com/birdieapp/birdie/archive/1.1.tar.gz That URL actually resolves to download birdie-1.1.tar.gz. Added a comment above the source0 line stating that this is the URL. Is there a better way to handle it? Updated the source URL to the format in this thread: https://lists.fedoraproject.org/pipermail/devel/2014-January/194210.html and it works now. On my end, RPM lint is not producing any warnings anymore. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 Mukundan Ragavan nonamed...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? --- Comment #4 from Mukundan Ragavan nonamed...@gmail.com --- (In reply to Ryan Lerch from comment #2) Also, how did you run rpmline to get the file-not-in%lang errors? I can not reproduce those. The line below indicates it's the binary rpm. You can build the package in mock and run rpmlint on source and binary rpms which is what produced those rpmlint warnings. I ran fedora-review. birdie.x86_64: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/birdie.mo Also, I will take this for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747
--- Comment #5 from Mukundan Ragavan nonamed...@gmail.com ---
Just noticed - the release tag should start with 1 - as in - 1%{?dist}
Quoting from the naming guidelines -
... The release number (referred to in some older documentation as a
vepoch) is how the maintainer marks build revisions, starting from 1. ...
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #6 from Mukundan Ragavan nonamed...@gmail.com --- Take a look at this page for handling locales - http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files I will do a more detailed review later tonight or tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068747] Review Request: birdie - A twitter client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1068747 --- Comment #7 from Christopher Meng cicku...@gmail.com --- Thanks for packaging birdie, I finally don't need to submit it by myself. 1. Summary: A twitter client for Linux Since we all use Linux, this summary looks not perfect, would you like to improve it? With some fantastic words if you can... 2. I see an appdata file, I just talked with Richard, and I think we need to improve the guideline like desktop file, so please use that tool provided from appdata to validate or install the file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
