[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-django15-1.5.5-7.fc2 ||0 Resolution|--- |ERRATA Last Closed||2014-04-08 21:04:06 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- python-django15-1.5.5-7.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- python-django15-1.5.5-7.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- python-django15-1.5.5-7.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-django15-1.5.5-7.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230
--- Comment #12 from Matthias Runge mru...@redhat.com ---
(In reply to Lars Kellogg-Stedman from comment #11)
This latest spec file seems to resolve all the directory ownership issues,
but you still need to fix the quoting on your find statements (bottom of
comment #8). With that in place we should be all set :).
Ah, sorry, I forgot that.
After removing that, I ran rpmlint again on the files:
[mrunge@sofja SPECS (master)]$ rpmlint ./python-django15.spec
/home/mrunge/rpmbuild/SRPMS/python-django15-1.5.5-7.fc20.src.rpm
/home/mrunge/rpmbuild/RPMS/noarch/python-django15-1.5.5-7.fc20.noarch.rpm
/home/mrunge/rpmbuild/RPMS/noarch/python-django15-doc-1.5.5-7.fc20.noarch.rpm
/home/mrunge/rpmbuild/RPMS/noarch/python3-django15-doc-1.5.5-7.fc20.noarch.rpm
/home/mrunge/rpmbuild/RPMS/noarch/python3-django15-1.5.5-7.fc20.noarch.rpm
./python-django15.spec:210: W: macro-in-comment %{__python3}
python-django15.src: W: spelling-error %description -l en_US Django - Fandango
python-django15.src:210: W: macro-in-comment %{__python3}
python-django15.noarch: W: spelling-error %description -l en_US Django -
Fandango
python3-django15.noarch: W: spelling-error %description -l en_US Django -
Fandango
5 packages and 1 specfiles checked; 0 errors, 5 warnings.
Spelling issues are clear, and Macro in comment issue: I left out running
checks, line 210 (was at that time, now 204)
%{__python3} runtests.py --settings=test_sqlite --verbosity=2
Updated
SPEC: http://www.matthias-runge.de/fedora/python-django15.spec
SRPM: http://www.matthias-runge.de/fedora/python-django15-1.5.5-7.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230
Lars Kellogg-Stedman l...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #13 from Lars Kellogg-Stedman l...@redhat.com ---
Those errors may have been...erroneous. I fixed my broken rawhide mock config,
so I can build against rawhide, and I'm not seeing those shebang errors
anymore. I'm declaring this all set.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Binary eggs must be removed in %prep
Note: Binary egg files not removed in %prep:
./tests/regressiontests/utils/eggs/test_egg.egg
./tests/regressiontests/templates/eggs/tagsegg.egg
./tests/regressiontests/app_loading/eggs/nomodelapp.egg
./tests/regressiontests/app_loading/eggs/modelapp.egg
./tests/regressiontests/app_loading/eggs/brokenapp.egg
./tests/regressiontests/app_loading/eggs/omelet.egg
See:
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
MIT/X11 (BSD like), PSF (v2), Apache (v2.0), Unknown or
generated, BSD (3 clause). 1416 files have unknown license. Detailed
output of licensecheck in /home/lkellogg/tmp/python-
django15/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /etc/bash_completion.d(be,
python-django, git, lldpad, rpmdevtools, fcoe-utils, mercurial, stgit,
fedpkg, python-novaclient, yum-utils, tuned, python-django15, bash-
completion, filesystem, python3-django15, python-neutronclient, rhpkg,
mock, bzr)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Matthias Runge mru...@redhat.com --- Lars, thank you very much for your review! I really appreciate it! New Package SCM Request === Package Name: python-django15 Short Description: A high-level Python Web framework Owners: mrunge Branches: f20 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #11 from Lars Kellogg-Stedman l...@redhat.com --- This latest spec file seems to resolve all the directory ownership issues, but you still need to fix the quoting on your find statements (bottom of comment #8). With that in place we should be all set :). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #10 from Matthias Runge mru...@redhat.com --- Lars, thank you for your proposal. Sadly, this doesn't seem to work (excluding, including later): this leeds to many messages like: warning: File listed twice: /usr/lib/python2.7/site-packages/Django-1.5.5-py2.7.egg/django/contrib/sites/locale/zh_CN/LC_MESSAGES/django.mo or: python-django15.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/Django-1.5.5-py2.7.egg/django/contrib/admin/locale/udm/LC_MESSAGES/django.mo I'd appreciate to make the files section smaller and cleaner. Sadly. I haven't found a solution, to make this happen :-( Thus, I updated my old spec and SRPM, and finally fixed all unowned dirs and files. I fixed that RPMlint compress issue as well. SPEC: http://www.matthias-runge.de/fedora/python-django15.spec SRPM: http://www.matthias-runge.de/fedora/python-django15-1.5.5-6.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #9 from Lars Kellogg-Stedman l...@redhat.com --- Matthias, I've put a modified spec file here: - https://gist.github.com/larsks/9430481 This dramatically reduces the complexity of the %files sections by moving all the locale files into a -locale subpackage, which lets us make much better use of wildcards and the %exclude option. This spec file also tries to fix permissions as correctly as possible without too much special-casing. Take a look and tell me what you think. With this spec file, the only errors from rpmlint are: python-django15.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/Django-1.5.5-py2.7.egg/django/bin/profiling/gather_profile_stats.py python-django15.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/Django-1.5.5-py2.7.egg/django/bin/profiling/__init__.py python3-django15.noarch: E: script-without-shebang /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg/django/bin/profiling/gather_profile_stats.py python3-django15.noarch: E: script-without-shebang /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg/django/contrib/admin/bin/compress.py python3-django15.noarch: E: script-without-shebang /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg/django/bin/profiling/__init__.py ...and this is largely because Django's file organization is insane, so I'm inclined to ignore these last few items. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #7 from Matthias Runge mru...@redhat.com --- Updated SPEC: http://www.matthias-runge.de/fedora/python-django15.spec SRPM: http://www.matthias-runge.de/fedora/python-django15-1.5.5-5.fc20.src.rpm - fixed docs build on rawhide (due an updted sphinx version - dropped obsoletes/provides - owned directories missing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #8 from Lars Kellogg-Stedman l...@redhat.com --- Matthias, You're going to hate me, but this package still results in a bunch of unowned directory errors: [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/en_GB, /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/zh_TW/LC_MESSAGES, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/es_MX/LC_MESSAGES, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/admin/locale/udm, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/en_GB/LC_MESSAGES, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/sr_Latn, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/admindocs/locale/udm, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/pt_BR, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/fy_NL/LC_MESSAGES, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/zh_TW, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/zh_CN, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/es_AR, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/fy_NL, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/zh_CN/LC_MESSAGES, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/es_MX, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/pt_BR/LC_MESSAGES, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/flatpages/locale/udm, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/es_AR/LC_MESSAGES, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/conf/locale/__pycache__, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/conf/locale/udm, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/sr_Latn/LC_MESSAGES [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/en, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/eo, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/el, /usr/lib/python3.3/site- packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/en_GB, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/sl/LC_MESSAGES, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/ar/LC_MESSAGES, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/sr_Latn, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/et, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/eu, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/eu/LC_MESSAGES, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/es, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/mk/LC_MESSAGES, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/ja/LC_MESSAGES, /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/nl, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/nb, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/zh_CN/LC_MESSAGES, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/is/LC_MESSAGES, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/admin/locale/udm, /usr/lib/python2.7/site- packages/Django-1.5.5-py2.7.egg/django/contrib/localflavor/locale/bs/LC_MESSAGES, /usr/lib/python2.7/site-
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #3 from Matthias Runge mru...@redhat.com --- - bundled eggs are used for tests, but not distributed in rpm. - Docs require base package to be installed (though forcing License to be installed) SPEC: http://www.matthias-runge.de/fedora/python-django15.spec SRPM: http://www.matthias-runge.de/fedora/python-django15-1.5.5-4.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #4 from Lars Kellogg-Stedman l...@redhat.com --- Matthias, Thanks for the updated packages; I'm checking them out right now. I still have a question about how these packages are supposed to work with existing Django applications: For example, the package darkserver requires Django: $ rpm -q --requires darkserver /usr/bin/python Django config(darkserver) = 0.5.4-3.fc19 httpd koji mod_wsgi mysql python(abi) = 2.7 rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(FileDigests) = 4.6.0-1 rpmlib(PartialHardlinkSets) = 4.0.4-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 rpmlib(PayloadIsXz) = 5.2-1 Django is provided by your python-django15 package: $ rpm -q --provides python-django15 Django = 1.5.5-3.fc19 config(python-django15) = 1.5.5-3.fc19 django = 1.5.5-3.fc19 python-django15 = 1.5.5-3.fc19 But when you install darkserver it will fail to run because it can't import the django module: mod_wsgi (pid=21157): Target WSGI script '/usr/sbin/darkserver.wsgi' cannot be loaded as Python module. mod_wsgi (pid=21157): Exception occurred processing WSGI script '/usr/sbin/darkserver.wsgi'. Traceback (most recent call last): File /usr/sbin/darkserver.wsgi, line 7, in module import django.core.handlers.wsgi ImportError: No module named django.core.handlers.wsgi I just picked this package as an example after running repoquery --whatrequires Django; there are several other matching packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #5 from Lars Kellogg-Stedman l...@redhat.com --- Running fedora-review on the new package results in pages of: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/fi/LC_MESSAGES, /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg, /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/ro/LC_MESSAGES, /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/el, /usr/lib/python3.3/site-packages/Django-1.5.5-py3.3.egg/django/contrib/localflavor/locale/en, ... Why not just have the package own .../site-packages/Django-1.5.5-py3.3.egg and .../site-packages/Django-1.5.5-py2.7.egg? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 --- Comment #6 from Matthias Runge mru...@redhat.com --- Ah yes, you're right. I need to remove Django from provides. For darkserver to use this package, we'd need to change darkserver a bit to be able to pick up this parallel installable version. Regarding: Why not just have the package own .../site-packages/Django-1.5.5-py3.3.egg and .../site-packages/Django-1.5.5-py2.7.egg? When I just do that (instead of using this insane long file list), I'll end up with listing the locale files twice. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230
--- Comment #2 from Matthias Runge mru...@redhat.com ---
Lars, thank you for your review!it's really appreciated and this one is a tough
one!
First of all, I'm very sorry,I should have provided a matching spec file to the
srpm!
Addressing the issues:
- I simply forgot to own %{python3_sitelib}/Django-%{version}-py?.?.egg/
(fixed)
- how to test:
from pkg_resources import require
require(Django =1.5)
import django
print django.VERSION
(or so)
from http://fedoraproject.org/wiki/Packaging:Python_Eggs#Multiple_Versions
It is highly recommended that any such compatibility packages install a
README.fedora file explaining how to use this module.
(fixed)
- {__python} vs. {__python2}: I added a macro to the top:
%{!?__python2:%global __python2 %{__python}} (to make __python2 run on rhel6
and changed __python to __python2
- I know about all those duplicate files. those are language files. When not
listing them, it saves about 200 lines (or so) in the spec file. Will add them
back.
- the bundled eggs are (currently) required for tests. Will remove them, or
will take care not to distribute them in the RPM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=1070230 Lars Kellogg-Stedman l...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
