[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Daniel Vrátil changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-03-31 05:44:02 --- Comment #19 from Daniel Vrátil --- Thanks, I'll fix the upstream URL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #18 from Patrick Uiterwijk --- Please note that the upstream URL is incorrect, correct is: http://code.google.com/p/accounts-sso Please note that the upstream URL is on Google Code, which means it will need updating when upstram moves. Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Patrick Uiterwijk changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Daniel Vrátil changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from Daniel Vrátil --- New Package SCM Request === Package Name: signon Short Description: Accounts framework for Linux and POSIX based platforms Upstream URL: http://code.google.com/p/accounts.sso Owners: group::kde-sig Branches: f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #16 from Rex Dieter --- looks good to me thanks, approved++ double plus good -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Kevin Kofler changed: What|Removed |Added Summary|Review Request: signon-qt5 |Review Request: signon - |- Accounts framework for|Accounts framework for |Linux and POSIX based |Linux and POSIX based |platforms |platforms Alias||signon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #8 from Christopher Meng --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - Header files in -devel subpackage, if present. Note: signon-doc : /usr/share/doc/signon-plugins-dev/example/exampledata.h signon-doc : /usr/share/doc/signon-plugins-dev/example/exampleplugin.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 24412160 bytes in 1101 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "LGPL (v2.1)". 3 files have unknown license. Detailed output of licensecheck: LGPL (v2.1) --- signon-8.56/lib/SignOn/async-dbus-proxy.cpp signon-8.56/lib/SignOn/async-dbus-proxy.h signon-8.56/lib/SignOn/authservice.cpp signon-8.56/lib/SignOn/authservice.h signon-8.56/lib/SignOn/authserviceimpl.cpp signon-8.56/lib/SignOn/authserviceimpl.h signon-8.56/lib/SignOn/authsession.cpp signon-8.56/lib/SignOn/authsession.h signon-8.56/lib/SignOn/authsessionimpl.cpp signon-8.56/lib/SignOn/authsessionimpl.h signon-8.56/lib/SignOn/connection-manager.cpp signon-8.56/lib/SignOn/connection-manager.h signon-8.56/lib/SignOn/dbusinterface.cpp signon-8.56/lib/SignOn/dbusinterface.h signon-8.56/lib/SignOn/identity.cpp signon-8.56/lib/SignOn/identity.h signon-8.56/lib/SignOn/identityimpl.cpp signon-8.56/lib/SignOn/identityimpl.h signon-8.56/lib/SignOn/identityinfo.cpp signon-8.56/lib/SignOn/identityinfo.h signon-8.56/lib/SignOn/identityinfoimpl.cpp signon-8.56/lib/SignOn/identityinfoimpl.h signon-8.56/lib/SignOn/libsignoncommon.h signon-8.56/lib/SignOn/sessiondata.h signon-8.56/lib/SignOn/signon.h signon-8.56/lib/SignOn/signonerror.h signon-8.56/lib/plugins/SignOn/authpluginif.h signon-8.56/lib/plugins/SignOn/signonplugincommon.h signon-8.56/lib/plugins/SignOn/uisessiondata.h signon-8.56/lib/plugins/SignOn/uisessiondata_priv.h signon-8.56/lib/plugins/signon-plugins-common/SignOn/blobiohandler.cpp signon-8.56/lib/plugins/signon-plugins-common/SignOn/blobiohandler.h signon-8.56/lib/plugins/signon-plugins-common/SignOn/ipc.h signon-8.56/lib/signond/SignOn/abstract-access-control-manager.cpp signon-8.56/lib/signond/SignOn/abstract-access-control-manager.h signon-8.56/lib/signond/SignOn/abstract-crypto-manager.cpp signon-8.56/lib/signond/SignOn/abstract-crypto-manager.h signon-8.56/lib/signond/SignOn/abstract-key-authorizer.cpp signon-8.56/lib/signond/SignOn/abstract-key-authorizer.h signon-8.56/lib/signond/SignOn/abstract-key-manager.cpp signon-8.56/lib/signond/SignOn/abstract-key-manager.h signon-8.56/lib/signond/SignOn/abstract-secrets-storage.cpp signon-8.56/lib/signond/SignOn/abstract-secrets-storage.h signon-8.56/lib/signond/SignOn/debug.cpp signon-8.56/lib/signond/SignOn/debug.h signon-8.56/lib/signond/SignOn/export.h signon-8.56/lib/signond/SignOn/extension-interface.cpp signon-8.56/lib/signond/SignOn/extension-interface.h signon-8.56/lib/signond/SignOn/key-handler.cpp signon-8.56/lib/signond/SignOn/key-handler.h signon-8.56/lib/signond/SignOn/misc.cpp signon-8.56/lib/signond/SignOn/misc.h signon-8.56/lib/signond/signoncommon.h signon-8.56/src/extensions/cryptsetup/crypto-handlers.cpp signon-8.56/src/extensions/cryptsetup/crypto-handlers.h signon-8.56/src/extensions/cryptsetup/crypto-manager.cpp signon-8.56/src/extensions/cryptsetup/crypto-manager.h signon-8.56/src/extensions/cryptsetup/cryptsetup-plugin.cpp signon-8.56/src/extensions/cryptsetup/cryptsetup-plugin.h signon-8.56/src/extensions/cryptsetup/debug.h signon-8.56/src/extensions/cryptsetup/misc.cpp signon-8.56/src/extensions/cryptsetup/misc.h signon-8.56/src/plugins/example/exampledata.h signon-8.56/src/plugins/example/exampleplugin.cpp signon-8.56/src/plugins/example/exampleplugin.h signon-8.56/src/plugins/password/passwordplugin.cpp signon-8.56/src/plugins/password/passwordplugin.h signon-8.56/src/plugins/test/ssotest2data.h signon-8.56/src/plugins/test/ssotest2plugin.cpp signon-8.56/src/plugins/test/ssotest2plugin
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Dan Vrátil changed: What|Removed |Added Flags|needinfo?(dvra...@redhat.co | |m) | --- Comment #7 from Dan Vrátil --- Updated spec with a patch to fix build (submitted upstream) Updated spec: http://dvratil.fedorapeople.org/spec/signon.spec Updated SRPML: http://dvratil.fedorapeople.org/spec/signon-8.56-3.fc20.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6923844 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Christopher Meng changed: What|Removed |Added CC||dvra...@redhat.com Flags||needinfo?(dvra...@redhat.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #6 from Christopher Meng --- http://koji.fedoraproject.org/koji/taskinfo?taskID=6744458 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Christopher Meng changed: What|Removed |Added Flags||fedora-review? --- Comment #5 from Christopher Meng --- FTBFS on rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #4 from Dan Vrátil --- Ping, could you please review the updated spec? :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #3 from Dan Vrátil --- Thanks for your comments. Updated spec: http://dvratil.fedorapeople.org/spec/signon.spec Updated SRPML: http://dvratil.fedorapeople.org/spec/signon-8.56-2.fc20.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6617508 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406
--- Comment #2 from Christopher Meng ---
I started from packaging it in 8.53, but then stopped as I had no time.
Initial comments:
1. No static libraries please.
2. %qmake_qt4 should be used instead of the one you are using, as missing some
FLAGS.
3. -docs --> doc
4. Requires: %{name} = %{version}-%{release} -->
Requires: glib2-devel
Requires: %{name}{?_isa} = %{version}-%{release}
Requires: glib2-devel{?_isa}
5. Where is libproxy dep?
6. BuildRequires: qt-devel --?> BuildRequires: qt4-devel
Just a cosmetic change.
7. %description
%{summary}.
No, that's too short, please igve some love here.
8. You remove group tag in the main package, good!
But don't forget the one in -devel:
Group: Development/Libraries
9.%{_sysconfdir}/signond.conf
-->
%config(noreplace) %{_sysconfdir}/signond.conf
10. %{_datadir}/doc --> %{_docdir}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com --- Comment #1 from Christopher Meng --- I just started packaging it :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
