[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149
Christopher Meng changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #1 from Christopher Meng ---
1. %define --> %global
2. Requires: %{name} = %{version}-%{release}
-->
Requires: %{name}%{?_isa} = %{version}-%{release}
3. Drop Requires: pkgconfig
4. devel package template:
%packagedevel
Summary:Development files for %{name}
Requires: %{name}%{?_isa} = %{version}-%{release}
%descriptiondevel
This package contains libraries and header files for
developing applications that use %{name}.
5. autoreconf -v --install || exit 1
-->
autoreconf -fiv || exit 1
6. find $RPM_BUILD_ROOT -type f -name '*.la' | xargs rm -f -- || :
Hint:
find $RPM_BUILD_ROOT -type f -name '*.la' -delete -print
7. Drop
%defattr(-,root,root,-)
8. %{_includedir}/epoxy/*
You forgot to own the
%{_includedir}/epoxy/
itself.
Solution:
i. Change to %{_includedir}/epoxy/
ii. A bit detailed:
%dir %{_includedir}/epoxy/
%{_includedir}/epoxy/*
9. http://dri.sourceforge.net
Redirected to http://dri.freedesktop.org/
What I can get from Google is:
https://github.com/anholt/libepoxy
Ideas?
10. Group tags is optional now, you can choose to drop them ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #2 from Dave Airlie --- I've updated the spec and srpm at the same place, I think I've address all the raised issues, Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149
--- Comment #3 from Christopher Meng ---
(In reply to Dave Airlie from comment #2)
>
> I've updated the spec and srpm at the same place, I think I've address all
> the raised issues,
>
> Thanks for the review.
NP.
1. %defattr(-,root,root,-)
is still in -devel package ;)
2. Missing one dot at the end of the %description in -devel.
3. https://github.com/anholt/libepoxy/releases
I can see 1.1 has been released about a month ago. So at least "Release:
0.1%{?dist}" is not good for the current status. As there are 11 commits ahead,
this package is a snapshot package now:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #4 from Dave Airlie --- Indeed good point, okay I've updated the spec and new srpm with a new version as per the wiki. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #5 from Christopher Meng --- SRPM link?(Can't be the same in comment 0 per changes you've made to %version) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #6 from Dave Airlie --- srpm:http://people.fedoraproject.org/~airlied/epoxy/libepoxy-1.2-0.1.20140307gitd4ad80f.fc20.src.rpm spec is the same one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149
--- Comment #7 from Christopher Meng ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck:
MIT/X11 (BSD like)
--
libepoxy-20140307/include/epoxy/egl.h
libepoxy-20140307/include/epoxy/gl.h
libepoxy-20140307/include/epoxy/glx.h
libepoxy-20140307/include/epoxy/wgl.h
libepoxy-20140307/src/dispatch_common.c
libepoxy-20140307/src/dispatch_common.h
libepoxy-20140307/src/dispatch_egl.c
libepoxy-20140307/src/dispatch_glx.c
libepoxy-20140307/src/dispatch_wgl.c
libepoxy-20140307/src/gen_dispatch.py
libepoxy-20140307/test/egl_common.c
libepoxy-20140307/test/egl_common.h
libepoxy-20140307/test/egl_has_extension_nocontext.c
libepoxy-20140307/test/egl_without_glx.c
libepoxy-20140307/test/glx_beginend.c
libepoxy-20140307/test/glx_common.c
libepoxy-20140307/test/glx_common.h
libepoxy-20140307/test/glx_glxgetprocaddress_nocontext.c
libepoxy-20140307/test/glx_has_extension_nocontext.c
libepoxy-20140307/test/glx_public_api.c
libepoxy-20140307/test/glx_public_api_core.c
libepoxy-20140307/test/glx_static.c
libepoxy-20140307/test/headerguards.c
libepoxy-20140307/test/khronos_typedefs.c
libepoxy-20140307/test/khronos_typedefs.h
libepoxy-20140307/test/khronos_typedefs_nonepoxy.c
libepoxy-20140307/test/miscdefines.c
libepoxy-20140307/test/wgl_common.c
libepoxy-20140307/test/wgl_common.h
libepoxy-20140307/test/wgl_core_and_exts.c
Unknown or generated
libepoxy-20140307/.dir-locals.el
libepoxy-20140307/autogen.sh
[x]: License file installed when any subpackage combination is installed.
[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a n
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #8 from Michael Schwendt --- These two apply also: * https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control * https://fedoraproject.org/wiki/Packaging:SourceURL#Github Even if a script like make-git-snap-shot.sh is included, a one-line comment should tell how to replicate the included source tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #9 from Dave Airlie --- srpm: http://people.fedoraproject.org/~airlied/epoxy/libepoxy-1.2-0.1.20140307gitd4ad80f.fc21.src.rpm same spec file, I've moved to using the github method, thanks for pointing that out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Dave Airlie changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Dave Airlie --- Package Change Request == Package Name: libepoxy New Branches: el6 epel7 Owners: airlied InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #16 from Jens Petersen --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Jens Petersen changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Dan Horák changed: What|Removed |Added CC||d...@danny.cz --- Comment #10 from Dan Horák --- Christopher, ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Christopher Meng --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #12 from Dave Airlie --- New Package SCM Request === Package Name: libepoxy Short Description: OpenGL pointer management library Owners: airlied Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Dave Airlie changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Christopher Meng changed: What|Removed |Added Resolution|CURRENTRELEASE |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Christopher Meng changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2014-04-20 07:18:34 --- Comment #14 from Christopher Meng --- I see building failure of new snapshot package in koji, but as it has been built with an older version, I will mark this bug as RAWHIDE(f20 not pushed yet). Hope you can fix the package soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
