[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Config-Generator-0.5-1 ||.el6 Resolution|--- |ERRATA Last Closed||2014-04-28 16:37:09 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- perl-Config-Generator-0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Config-Generator-0.5-1 |perl-Config-Generator-0.5-1 |.el6|.el5 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- perl-Config-Generator-0.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #18 from Adrien Devresse ade...@gmail.com --- Gne ? Listen, I Apologize if my quick message made you angry, I posted it in a hurry. It was nothing personnal. Forgot to mention: This is NEED-SPONSOR request, which means reviewers are expected to *teach* newcomers to Fedora practices. You (Adrian) failed to do so. i.e. disqualified yourself from being a packager sponsor. You speak without knowing anything. I know Alexandre personnaly, he is in the same organization than me. He did several informal reviews and packaging training during almost one month with me. It's what I name teaching and it is exactly what my sponsor did with me at the time. I fully take his actions under my responsability. If you are not happy with my way to proceed, I'm perfectly open to your explanation of what is teaching. You obviously are lacking suffient experience to unterstand the rationales behind this - It's a safety belt against stupid mistakes, which is causing misunderstandings and confusion. I am not willing to tolerate reviewers who accept such bad habits. I have currently more than 200 updates on my own, and around 50 packages under my responsability. A lot of packager ask to not increase the release tag during the review ( includind my sponsor if I remember properly ) for the good and simple reason that it avoids to rollback the release tag to 1 at the first import. If you are not fine with my method, I would be happy to discuss of this. But that does not justify your public attacks nor your agressivity or your way to proceed. Adev -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- perl-Config-Generator-0.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- perl-Config-Generator-0.5-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Config-Generator-0.5-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #15 from Ralf Corsepius rc040...@freenet.de --- (In reply to Adrien Devresse from comment #9) Not quite. You did not increment the Release-Tag. This is ok as long as it is under review, You are wrong - This is *not* OK. You obviously are lacking suffient experience to unterstand the rationales behind this - It's a safety belt against stupid mistakes, which is causing misunderstandings and confusion. I am not willing to tolerate reviewers who accept such bad habits. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #16 from Ralf Corsepius rc040...@freenet.de --- Forgot to mention: This is NEED-SPONSOR request, which means reviewers are expected to *teach* newcomers to Fedora practices. You (Adrian) failed to do so. i.e. disqualified yourself from being a packager sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #17 from Ralf Corsepius rc040...@freenet.de --- (In reply to Alexandre Beche from comment #11) InitialCC: adev Perl packages should have an InitialCC: perl-sig. This echoes all BZs to the perl-devel list and thus notifies other perl-module maintainers of upcoming issues/updates etc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Alexandre Beche alexandre.be...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Alexandre Beche alexandre.be...@gmail.com --- New Package SCM Request === Package Name: perl-Config-Generator Short Description: This module contains all the global variables used by the Config::Generator modules. Owners: abeche Branches: f19 f20 el5 el6 epel7 InitialCC: adev -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- perl-Config-Generator-0.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Config-Generator-0.5-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969
--- Comment #10 from Adrien Devresse ade...@gmail.com ---
Ok, Official review
Legend:
X - valid
! - Invalid
N∕A - not concerned
[X]: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[X]: The package must be named according to the Package Naming Guidelines .
[X]: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
[X]: The package must meet the Packaging Guidelines .
[X]: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
GPL+ artistic - perl recommendation
[X]: The License field in the package spec file must match the actual license.
[3]
[X]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
[X]: The spec file must be written in American English. [5]
[X]: The spec file for the package MUST be legible. [6]
[X]: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as it is
used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
dd2e02f59a118bd5f02f377002c1dc3f
perl-Config-Generator-0.5-1.el6.noarch/Config-Generator-0.5.tar.gz
dd2e02f59a118bd5f02f377002c1dc3f Config-Generator-0.5.tar.gz
[X]: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
http://koji.fedoraproject.org/koji/taskinfo?taskID=6647982
[N/A]: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[X]: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[N/A]: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[N/A]: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
[N/A]: Packages must NOT bundle copies of system libraries.[11]
[N/A]: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
[X]: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13]
[X]: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
[X]: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15]
[X]: Each package must consistently use macros. [16]
- see comments
[X]: The package must contain code, or permissable content. [17]
[N/A]: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
[X]: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present. [18]
[N/A]: Static libraries must be in a -static package. [19]
[N/A]: Development files must be in a -devel package. [20]
[N/A]: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21]
[N/A]: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[19]
[N/A]: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[22]
[X]: Packages must not own files or directories already owned by other
packages. The
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Adrien Devresse ade...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #9 from Adrien Devresse ade...@gmail.com --- Not quite. You did not increment the Release-Tag. This is ok as long as it is under review, there is no need to start a package to release 10. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Adrien Devresse ade...@gmail.com changed: What|Removed |Added CC||ade...@gmail.com Assignee|nob...@fedoraproject.org|ade...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Adrien Devresse ade...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Adrien Devresse ade...@gmail.com --- Hi, I sponsor Alexandre, I take care of this review. Adrien -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #6 from Adrien Devresse ade...@gmail.com --- The spec file seems to have been updated but not the SRPM which does not compile on rawhide : http://koji.fedoraproject.org/koji/taskinfo?taskID=6626776 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #7 from Alexandre Beche alexandre.be...@gmail.com --- Hello, source rpm updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #8 from Ralf Corsepius rc040...@freenet.de --- (In reply to Alexandre Beche from comment #7) Hello, source rpm updated. Not quite. You did not increment the Release-Tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #2 from Alexandre Beche alexandre.be...@gmail.com --- Hello, Does it works now? Cheers, Alex -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969
--- Comment #3 from Ralf Corsepius rc040...@freenet.de ---
(In reply to Alexandre Beche from comment #2)
Does it works now?
Yes, it does.
Some comments on your package:
* Package fails to build:
error: Installed (but unpackaged) file(s) found:
/usr/bin/yacg
/usr/share/man/man1/yacg.1.gz
You need to add
%{_bindir}/yacg
%{_mandir}/man1/yacg*
or similar to %files
* Except of the Require: perl(:MODULE_COMPAT*), all Requires: perl(*)
should all be removed from the spec.
RPM automatically generates the necessary Requires: itself.
* Unless you plan to support epel 6, you can tighten up the spec-file by
removing many anachronims from the spec (%clean, rm -rf $RPM_BUILD_ROOT,
BuildRoot:, %defattr, etc.).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 --- Comment #4 from Alexandre Beche alexandre.be...@gmail.com --- Done, I uploaded the new spec. I do need the EPEL5 compat. Cheers, Alex -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Alexandre Beche alexandre.be...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules
https://bugzilla.redhat.com/show_bug.cgi?id=1074969 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #1 from Ralf Corsepius rc040...@freenet.de --- (In reply to Alexandre Beche from comment #0) Spec URL: http://abeche.web.cern.ch/abeche/perl-Config-Generator.spec This URL is inaccessible: This website is only visible from within CERN -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
