[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Bug 1075047 depends on bug 1075219, which changed state. Bug 1075219 Summary: Review Request: nodejs-stream-counter - Keeps track of how many bytes have been written to a stream https://bugzilla.redhat.com/show_bug.cgi?id=1075219 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-03-15 12:36:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||1003338 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1003338 [Bug 1003338] nodejs-connect-2.14.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Tom Hughes t...@compton.nu changed: What|Removed |Added Status|NEW |ASSIGNED CC||t...@compton.nu Assignee|nob...@fedoraproject.org|t...@compton.nu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #1 from Tom Hughes t...@compton.nu --- This appears to have a dependency (run time, not just build time) on stream-counter which you don't seem to have filed a request for currently. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047
--- Comment #2 from Tom Hughes t...@compton.nu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: %check is present and all tests pass.
I'm getting two test failures, running with npm installed
dependencies:
1) standalone test-issue-36:
Error: exited with code 8
at ChildProcess.anonymous
(/home/tom/rpm/BUILD/package/test/test.js:49:33)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at Process.ChildProcess._handle.onexit (child_process.js:797:12)
2) standalone test-issue-5:
Error: exited with code 8
at ChildProcess.anonymous
(/home/tom/rpm/BUILD/package/test/test.js:49:33)
at ChildProcess.EventEmitter.emit (events.js:98:17)
at Process.ChildProcess._handle.onexit (child_process.js:797:12)
[!]: Rpmlint is run on all installed packages.
Failed due to install failure related to missing dependency on
stream-counter module.
[!]: Unpackaged doc file
The README is not being included in the built package.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #3 from Jamie Nguyen jamieli...@fedoraproject.org --- (In reply to Tom Hughes from comment #1) This appears to have a dependency (run time, not just build time) on stream-counter which you don't seem to have filed a request for currently. Ah sorry. I'd already packaged it but forgot to add it to my list of reviews to open. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||1075219 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1075219 [Bug 1075219] Review Request: nodejs-stream-counter - Keeps track of how many bytes have been written to a stream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- I'm only getting one error when running `npm test`: 1) standalone test-issue-36: Error: exited with code 8 at ChildProcess.anonymous (/home/tom/rpm/BUILD/package/test/test.js:49:33) at ChildProcess.EventEmitter.emit (events.js:98:17) at Process.ChildProcess._handle.onexit (child_process.js:797:12) This is related to patching out npm(readable-stream), which is a mirror of streams2 from Node 0.10 (readable-stream@1.0.x) and streams3 from Node 0.11 (readable-stream@1.1.x). Not sure if FPC will allow a straight copy of these files/functions from Node core. Looks like a total of around 1700 lines pretty much copy-pasted from Node :( Patching out readable-stream appeared to be simple at first But I just realised that they are using readable-stream@1.1.x :( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #5 from Jamie Nguyen jamieli...@fedoraproject.org --- Seems like we have three options: 1) Ignore the failing test. I'm really not sure how much impact this will have. 2) Package multiparty@2.1.9 (which uses readable-stream@1.0.x so it can be patched out easily to use Node core). connect@2.14.1 still passes the test suite with multiparty@2.1.9. 3) Open FPC ticket to see if readable-stream can be packaged, but it's not a fork and is a straight copy of a large amount of code so I somehow doubt it will be approved. What do you think Tom? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #6 from Tom Hughes t...@compton.nu --- So the second test failure I was seeing is because I was running mocha by hand, while npm test applies a ulimit first, and the test in question is testing what happens when it runs out of file descriptors so relies on the lower ulimit. The spec file will presumably need to do the ulimit. Passing the tests is only a SHOULD anyway, so if you're happy to try and make that the rest of the stack will work despite the failing test then fine. Hopefylly 0.12 will be along soon anyway... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #7 from Jamie Nguyen jamieli...@fedoraproject.org --- Ok cool. connect@2.14.1 still passes the whole test suite with the current multiparty package so fingers crossed we'll not see any strange problems. When I find the energy I might open FPC tickets for nodejs-extend and nodejs-readable-stream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Tom Hughes t...@compton.nu --- So the README needs adding to %doc but other than that it looks good, so package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 --- Comment #9 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/connect/nodejs-multiparty.spec SRPM URL: http://jamielinux.fedorapeople.org/connect/SRPMS/nodejs-multiparty-3.2.3-2.fc21.src.rpm * Tue Mar 11 2014 Jamie Nguyen jamieli...@fedoraproject.org - 3.2.3-2 - add README.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-multiparty Short Description: A multipart/form-data parser for Node.js which supports streaming Owners: jamielinux patches Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075047] Review Request: nodejs-multiparty - A multipart/form-data parser for Node.js which supports streaming
https://bugzilla.redhat.com/show_bug.cgi?id=1075047 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
