[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ghc-transformers-compat-0.3 |ghc-transformers-compat-0.3 |.3.4-2.fc19 |.3.4-2.el7 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- ghc-transformers-compat-0.3.3.4-2.el7, ghc-optparse-applicative-0.11.0.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- ghc-optparse-applicative-0.11.0.1-2.el7,ghc-transformers-compat-0.3.3.4-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-optparse-applicative-0.11.0.1-2.el7,ghc-transformers-compat-0.3.3.4-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ghc-transformers-compat-0.3 |ghc-transformers-compat-0.3 |.3.4-2.fc20 |.3.4-2.fc19 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- ghc-transformers-compat-0.3.3.4-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #14 from Jens Petersen peter...@redhat.com --- Ping? :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- ghc-transformers-compat-0.3.3.4-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-transformers-compat-0.3.3.4-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-transformers-compat-0.3 ||.3.4-2.fc20 Resolution|--- |ERRATA Last Closed|2014-03-25 21:38:30 |2014-07-30 17:56:45 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- ghc-transformers-compat-0.3.3.4-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Jens Petersen peter...@redhat.com changed: What|Removed |Added Blocks||1094423 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1094423 [Bug 1094423] ghc-optparse-applicative-0.9.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- ghc-transformers-compat-0.3.3.4-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595
Jens Petersen peter...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Blocks|1075598 (ghc-contravariant) |1116575
Assignee|nob...@fedoraproject.org|peter...@redhat.com
Summary|Review Request: |Review Request:
|ghc-transformers-compat - A |ghc-transformers-compat - A
|compatibility shim exposing |compatibility shim exposing
|the new types from newer|the new types from
|transformers|transformers 0.3
Flags||fedora-review+
--- Comment #8 from Jens Petersen peter...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 9 files have unknown license. Detailed output of
licensecheck in /home/petersen/pkgreview/1075595-ghc-transformers-
compat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 419840 bytes in 28 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Haskell:
[x]: This should never happen
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #9 from Jens Petersen peter...@redhat.com --- Created attachment 916004 -- https://bugzilla.redhat.com/attachment.cgi?id=916004action=edit ghc-transformers-compat.spec-1.patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Ricky Elrod rel...@redhat.com --- New Package SCM Request === Package Name: ghc-transformers-compat Short Description: A compatibility shim exposing the new types from transformers 0.3 Upstream URL: https://hackage.haskell.org/package/transformers-compat Owners: codeblock petersen Branches: f20 f19 epel7 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- ghc-transformers-compat-0.3.3.4-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-transformers-compat-0.3.3.4-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #6 from Jens Petersen peter...@redhat.com --- The best way to enable the three flag is to use run: cabal-tweak-flag three True in %prep. Failing that patching is also okay, but using cabal-tweak-flag is much easier to maintain. (What I said on irc about setting flags with %cabal_configure_options or $cabal_configure_extra_options is suboptimal since it is not visible to tools like cblrpm or cblrepo.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #7 from Ricky Elrod rel...@redhat.com --- Spec URL: http://codeblock.fedorapeople.org/packages/ghc-transformers-compat/ghc-transformers-compat.spec SRPM URL: http://codeblock.fedorapeople.org/packages/ghc-transformers-compat/ghc-transformers-compat-0.3.3.4-2.fc20.src.rpm Scratch build: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7110763 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|CLOSED |NEW Resolution|WONTFIX |--- Keywords||Reopened --- Comment #4 from Jens Petersen peter...@redhat.com --- Reopening, since contravariant-0.6 needs this with transformers-0.3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC||peter...@redhat.com --- Comment #5 from Jens Petersen peter...@redhat.com --- If Ricky if you want to update to 0.3.* I can review this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Jens Petersen peter...@redhat.com changed: What|Removed |Added Blocks|1075601 (ghc-exceptions)| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1075601 [Bug 1075601] Review Request: ghc-exceptions - Extensible optionally-pure exceptions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(rel...@redhat.com | |) | Last Closed||2014-03-25 21:38:30 --- Comment #3 from Ricky Elrod rel...@redhat.com --- Ok, we can patch instead. Closing this, then. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 --- Comment #2 from Jens Petersen peter...@redhat.com --- (In reply to Jens Petersen from comment #1) However I think (untested;) it should be trivial to patch contravariant, distributive, exceptions, etc to depend on transformers instead of this compat package. For reference I attached a sample patch to bug 1075598 showing how we could do this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Jens Petersen peter...@redhat.com changed: What|Removed |Added Blocks|999011 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=999011 [Bug 999011] idris-0.9.11.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC||rel...@redhat.com Flags||needinfo?(rel...@redhat.com ||) --- Comment #1 from Jens Petersen peter...@redhat.com --- I am happy to review this: we discussed with the author about allowing revdeps to depend instead on transformers-0.3 but he felt it is still too early for the whole Haskell library eco-system (he will probably wait after HP 2014.4). However I think (untested;) it should be trivial to patch contravariant, distributive, exceptions, etc to depend on transformers instead of this compat package. How do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Ricky Elrod rel...@redhat.com changed: What|Removed |Added CC||haskell-devel@lists.fedorap ||roject.org Blocks||999011 Alias||ghc-transformers-compat Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=999011 [Bug 999011] idris-0.9.11.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Blocks||1075598 (ghc-contravariant) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1075598 [Bug 1075598] Review Request: ghc-contravariant - Contravariant functors -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Blocks||1075601 (ghc-exceptions) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1075601 [Bug 1075601] Review Request: ghc-exceptions - Extensible optionally-pure exceptions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075595] Review Request: ghc-transformers-compat - A compatibility shim exposing the new types from transformers 0.3
https://bugzilla.redhat.com/show_bug.cgi?id=1075595 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Blocks||1075605 (ghc-distributive) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1075605 [Bug 1075605] Review Request: ghc-distributive - Haskell 98 Distributive functors -- Dual to Traversable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
