[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774
Christopher Meng changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #1 from Christopher Meng ---
1. Drop
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
2. env CFLAGS=%{_optflags}?
$ rpm -E %{_optflags}
%{_optflags}
I guess you mean %{optflags}?
3. Does it support /usr/lib64/passwd|/usr/lib64/group? I've added my self to sw
bugzilla and want to know more bits about it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774
--- Comment #2 from Colin Walters ---
(In reply to Christopher Meng from comment #1)
> 1. Drop
>
> Requires(post): /sbin/ldconfig
> Requires(postun): /sbin/ldconfig
Ok, fixed.
> I guess you mean %{optflags}?
Fixed.
> 3. Does it support /usr/lib64/passwd|/usr/lib64/group? I've added my self to
> sw bugzilla and want to know more bits about it.
No, that'd make no sense - there is only one nss database regardless of the
process' CPU architecture.
One could argue it should be /usr/share/passwd since it is machine-independent
data, but I was mainly following systemd's lead on /usr/lib/systemd.
New version uploaded to the same URLs.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774
--- Comment #3 from Christopher Meng ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or
generated". 1 files have unknown license. Detailed output of licensecheck:
LGPL (v2.1 or later) (with incorrect FSF address)
-
nss-altfiles-e2a80593727e659af90db87a73ea2129fc52f499/files-XXX.c
nss-altfiles-e2a80593727e659af90db87a73ea2129fc52f499/files-grp.c
nss-altfiles-e2a80593727e659af90db87a73ea2129fc52f499/files-have_o_cloexec.c
nss-altfiles-e2a80593727e659af90db87a73ea2129fc52f499/files-parse.c
nss-altfiles-e2a80593727e659af90db87a73ea2129fc52f499/files-pwd.c
Unknown or generated
nss-altfiles-e2a80593727e659af90db87a73ea2129fc52f499/compat.h
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[x]: De
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 --- Comment #4 from Colin Walters --- (In reply to Christopher Meng from comment #3) > > Generic: > [!]: Rpmlint is run on all installed packages. > Note: Mock build failed > See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Fixed now: http://fedorapeople.org/~walters/nss-altfiles.spec http://fedorapeople.org/~walters/nss-altfiles-2.18.1-1.el7.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774
--- Comment #5 from Christopher Meng ---
Issues:
Rpmlint (installed packages)
# rpmlint nss-altfiles
nss-altfiles.i686: W: spelling-error Summary(en_US) passwd -> passed, password
nss-altfiles.i686: W: unexpanded-macro %description -l C %{prefix}
nss-altfiles.i686: W: unexpanded-macro %description -l C %{prefix}
nss-altfiles.i686: W: no-version-in-last-changelog
nss-altfiles.i686: E: library-not-linked-against-libc
/usr/lib/libnss_altfiles.so.2
1 packages and 0 specfiles checked; 1 errors, 5 warnings.
# echo 'rpmlint-done:'
Suggestions:
1. %setup -q -n nss-altfiles-%{version} --> %setup -q
2. Source0: https://github.com/aperezdc/nss-altfiles/archive/v2.18.1.tar.gz
-->
Source0: https://github.com/aperezdc/nss-altfiles/archive/v%{version}.tar.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774
--- Comment #6 from Colin Walters ---
(In reply to Christopher Meng from comment #5)
> nss-altfiles.i686: E: library-not-linked-against-libc
Fixed by cherry-picking a patch from a pull request.
> 1. %setup -q -n nss-altfiles-%{version} --> %setup -q
I went one up on this and switched to %autosetup.
> Source0: https://github.com/aperezdc/nss-altfiles/archive/v%{version}.tar.gz
Sure, done.
New versions uploaded.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 --- Comment #7 from Colin Walters --- (In reply to Colin Walters from comment #6) > New versions uploaded. Hi Christopher, do you see any other issues? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Christopher Meng --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 Colin Walters changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Colin Walters --- New Package SCM Request === Package Name: nss-altfiles Short Description: NSS module to look up users in /usr/lib/passwd too Owners: walters mattdm Branches: f20 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075774] Review Request: nss-altfiles - NSS module to look up users in /usr/lib/passwd too
https://bugzilla.redhat.com/show_bug.cgi?id=1075774 Colin Walters changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-04-03 17:39:01 --- Comment #11 from Colin Walters --- http://koji.fedoraproject.org/koji/taskinfo?taskID=6705183 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
