[Bug 1076516] Review Request: rubygem-spring - Rails application preloader
https://bugzilla.redhat.com/show_bug.cgi?id=1076516 Josef Stribny changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||rubygem-spring-1.1.2-2.fc21 Resolution|--- |RAWHIDE Last Closed||2014-03-18 09:57:23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1076516] Review Request: rubygem-spring - Rails application preloader
https://bugzilla.redhat.com/show_bug.cgi?id=1076516 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1076516] Review Request: rubygem-spring - Rails application preloader
https://bugzilla.redhat.com/show_bug.cgi?id=1076516 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1076516] Review Request: rubygem-spring - Rails application preloader
https://bugzilla.redhat.com/show_bug.cgi?id=1076516 Josef Stribny changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Josef Stribny --- Thank you. Will do. New Package SCM Request === Package Name: rubygem-spring Short Description: Rails application preloader Owners: jstribny Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1076516] Review Request: rubygem-spring - Rails application preloader
https://bugzilla.redhat.com/show_bug.cgi?id=1076516 Vít Ondruch changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Vít Ondruch --- Just from the beginning, please do not link the SRPM from Koji, since it will get garbage collected soon, i.e. the link will become invalid. * Bundled OkJson library - This library has bundling exception, but you should mark it properly via virtual provide [1] * Test suite - I failed to execute the test suite as well. Listen is only one piece, but there is also extensively used Bundler, which might bring another issues. - However, could you fix the comment? rubygem-listen actually *is* in Fedora, but in old version. Unfortunately looking in direction in which Listen developers go, I am not sure it will be ever updated. I wouldn't be surprised that this might be the reason why spring does not depend on recent version if listen. * Missing 'ps' dependency - It seems that '$ spring status' requires 'ps' command to work: /usr/share/gems/gems/spring-1.1.2/lib/spring/client/status.rb:20:in ``': No such file or directory - ps (Errno::ENOENT) - Please comment the require appropriately, in case the 'ps' requirement is dropped from code base one day. * Hidden file - There is shipped unnecessary hidden file: rubygem-spring-doc.noarch: E: version-control-internal-file /usr/share/gems/gems/spring-1.1.2/test/apps/.gitignore Otherwise the package looks sand => APPROVED Please fix the OkJson and 'ps' dependency prior import. [1] https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_exceptions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1076516] Review Request: rubygem-spring - Rails application preloader
https://bugzilla.redhat.com/show_bug.cgi?id=1076516 Vít Ondruch changed: What|Removed |Added Status|NEW |ASSIGNED CC||vondr...@redhat.com Assignee|nob...@fedoraproject.org|vondr...@redhat.com Flags||fedora-review? --- Comment #1 from Vít Ondruch --- I'll take this for a review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
