[Bug 1077301] Review Request: python-aaargh - An astonishingly awesome application argument helper
https://bugzilla.redhat.com/show_bug.cgi?id=1077301 Vitaly Kuznetsov changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077301] Review Request: python-aaargh - An astonishingly awesome application argument helper
https://bugzilla.redhat.com/show_bug.cgi?id=1077301
Adrien Vergé changed:
What|Removed |Added
CC||adrienve...@gmail.com
--- Comment #1 from Adrien Vergé ---
Hi Vitaly,
You can remove the "-n %{name}-%{version}" part in %setup, that's the default.
The %description for the Python3 version contains a too long line. Actually it
overflows of just *one* character, I guess it's caused by the '3' of Python3.
;-)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077301] Review Request: python-aaargh - An astonishingly awesome application argument helper
https://bugzilla.redhat.com/show_bug.cgi?id=1077301
--- Comment #2 from Vitaly Kuznetsov ---
(In reply to Adrien Vergé from comment #1)
> Hi Vitaly,
>
Thanks for your review!
> You can remove the "-n %{name}-%{version}" part in %setup, that's the
> default.
I'm not using "%{name}-%{version}" but "%{modname}-%{version}" where "modname"
stands for "aaargh" (without 'python-' prefix). I need to do that due to the
fact that aaargh (as other python modules) is distributed in
'aaargh-VERSION.tar.gz' form.
>
> The %description for the Python3 version contains a too long line. Actually
> it overflows of just *one* character, I guess it's caused by the '3' of
> Python3. ;-)
Fixed! SRPM and SPEC updated.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077301] Review Request: python-aaargh - An astonishingly awesome application argument helper
https://bugzilla.redhat.com/show_bug.cgi?id=1077301 Miroslav Suchý changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077301] Review Request: python-aaargh - An astonishingly awesome application argument helper
https://bugzilla.redhat.com/show_bug.cgi?id=1077301
Dan Scott changed:
What|Removed |Added
CC||d...@coffeecode.net
--- Comment #3 from Dan Scott ---
Hi Vitaly:
Please use the versioned macros for python2, to prepare for the cutover to
python3 as the default, per
https://fedoraproject.org/wiki/Packaging:Python#Macros (for example,
"%{__python2}" instead of "%{__python}").
And hey, if you're up for a review swap, I've got bug 1089553 in the hopper
waiting for a reviewer :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077301] Review Request: python-aaargh - An astonishingly awesome application argument helper
https://bugzilla.redhat.com/show_bug.cgi?id=1077301 Yajo changed: What|Removed |Added CC||yajo@gmail.com --- Comment #4 from Yajo --- > Fixed! SRPM and SPEC updated. Please update %changelog even for review updates. > %define modname aaargh Please use %global. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define > %doc LICENSE.rst Please add README.rst too. Upstream provides tests, so a %check section would be good. Always remember to pass the built packages through rpmlint to fix them as much as possible. Right now it says: python-aaargh.noarch: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, commandant python-aaargh.noarch: W: incoherent-version-in-changelog 0.7-1 ['0.7.1-1.fc20', '0.7.1-1'] python3-aaargh.noarch: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, commandant 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Also, a personal suggestion: is there any reason for all the `with_python3` stuff? If not, just simplify your life: always build both packages. Please note that this is an unofficial review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077301] Review Request: python-aaargh - An astonishingly awesome application argument helper
https://bugzilla.redhat.com/show_bug.cgi?id=1077301 Vitaly Kuznetsov changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2014-08-14 12:22:13 --- Comment #5 from Vitaly Kuznetsov --- I've lost my interest in putting this package in Fedora as I don't use it anymore. Thanks for reviews anyway! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
