[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Tom Hughes t...@compton.nu --- Great. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-zlibjs Short Description: JavaScript library reimplementing compression, made available for Node.js Owners: jamielinux zbyszek patches Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 --- Comment #5 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-zlibjs Short Description: JavaScript library reimplementing compression, made available for Node.js Owners: jamielinux zbyszek patches Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Bug 1077322 depends on bug 1024589, which changed state. Bug 1024589 Summary: Review Request: js-zlib - JavaScript library reimplementing compression https://bugzilla.redhat.com/show_bug.cgi?id=1024589 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||zbys...@in.waw.pl Resolution|--- |RAWHIDE Last Closed||2014-03-18 10:08:10 --- Comment #7 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Built for rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=505201 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||1024589 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1024589 [Bug 1024589] Review Request: zlib-js - JavaScript library reimplementing compression -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||977137 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=977137 [Bug 977137] Review Request: nodejs-zlib-browserify - Wrapper for zlib.js to allow for use in browsers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 Tom Hughes t...@compton.nu changed: What|Removed |Added Status|NEW |ASSIGNED CC||t...@compton.nu Assignee|nob...@fedoraproject.org|t...@compton.nu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322
--- Comment #1 from Tom Hughes t...@compton.nu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= Issues =
[!]: Requires correct, justified where necessary.
I don't think the web-assets-filesystem require is needed?
[!]: Rpmlint is run on all installed packages.
nodejs-zlibjs.noarch: W: spelling-error Summary(en_US) reimplementing - re
implementing, re-implementing, implementing
nodejs-zlibjs.src: W: spelling-error Summary(en_US) reimplementing - re
implementing, re-implementing, implementing
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated. 4 files have unknown license.
Detailed output of licensecheck in /home/tom/1077322-nodejs-
zlibjs/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library reimplementing compression, made available for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1077322 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- (In reply to Tom Hughes from comment #1) [!]: Requires correct, justified where necessary. I don't think the web-assets-filesystem require is needed? Indeed. Thanks! [!]: Rpmlint is run on all installed packages. nodejs-zlibjs.noarch: W: spelling-error Summary(en_US) reimplementing - re implementing, re-implementing, implementing nodejs-zlibjs.src: W: spelling-error Summary(en_US) reimplementing - re implementing, re-implementing, implementing Noted. Reference.com and Wiktionary.com seem to be happy that it is a word. Other online dictionaries seem to have implement defined with a variety of suffixes but no mention of prefixes, either hyphenated or not. Spec URL: http://jamielinux.fedorapeople.org/gruntjs/nodejs-zlibjs.spec SRPM URL: http://jamielinux.fedorapeople.org/gruntjs/SRPMS/nodejs-zlibjs-0.2.0-1.fc21.src.rpm * Mon Mar 17 2014 Jamie Nguyen jamieli...@fedoraproject.org - 0.2.0-2 - remove redundant Requires: web-assets-filesystem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
