[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|copr-cli-1.32-1.fc20|copr-cli-1.32-1.el6 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- copr-cli-1.32-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||copr-cli-1.32-1.fc19 Resolution|--- |ERRATA Last Closed||2014-04-24 03:39:03 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- copr-cli-1.32-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|copr-cli-1.32-1.fc19|copr-cli-1.32-1.fc20 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- copr-cli-1.32-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- copr-cli-1.32-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- copr-cli-1.31-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/copr-cli-1.31-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- copr-cli-1.31-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/copr-cli-1.31-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- copr-cli-1.31-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/copr-cli-1.31-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Miroslav Suchý msu...@redhat.com --- New Package SCM Request === Package Name: copr-cli Short Description: Command line interface for COPR Owners: msuchy Branches: f19 f20 el6 el5 el7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792
--- Comment #8 from Miroslav Suchý msu...@redhat.com ---
I done rawhide build using mock and I see it owned. One problem is that those
doc files are in both packages (but that is obviously bug 1078760), but
%{_pkgdocdir} is owned.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792
Antonio Trande anto.tra...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #9 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Miroslav Suchý from comment #8)
I done rawhide build using mock and I see it owned. One problem is that
those doc files are in both packages (but that is obviously bug 1078760),
but %{_pkgdocdir} is owned.
%doc (/usr/share/doc/copr-cli in Fedora =20) macro defines documentation
directory in main package.
*-doc sub-package needs /usr/share/doc/copr-cli to locate own directory but
it's not dependent by main package*.
See
http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function
/usr/share/doc/copr-cli can be co-owned by both packages.
Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792
--- Comment #4 from Miroslav Suchý msu...@redhat.com ---
- BR 'make' can be omitted.
fixed
- -doc sub-package is independent by main package.
It must install own License files.
fixed
- '/usr/share/doc/copr-cli' directory is not owned
???
When using rpm -qpl I see:
...
/usr/share/doc/copr-cli-1.29
/usr/share/doc/copr-cli-1.29/LICENSE
/usr/share/doc/copr-cli-1.29/README.rst
..
- Please, specify '%{python_sitelib}/' sub-directory owned by this package
and, above all, the .egg-info file.
??
There is:
%files
%{python_sitelib}/*
which include all sub directories including egg-infor directory.
Note: Package building fails in EPEL6.
I was unable to make it work on el6 due epydoc. Therefore I build -doc only on
fedora, which is what did original copr package anyway.
Updated:
Spec URL: http://miroslav.suchy.cz/copr/copr-cli.spec
SRPM URL: http://miroslav.suchy.cz/copr/copr-cli-1.30-1.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792
--- Comment #5 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Miroslav Suchý from comment #4)
- Please, specify '%{python_sitelib}/' sub-directory owned by this package
and, above all, the .egg-info file.
??
There is:
%files
%{python_sitelib}/*
which include all sub directories including egg-infor directory.
Yes, you're right, in fact I wrote specify; they are just two files and one
directory.
- '/usr/share/doc/copr-cli' directory is not owned
???
When using rpm -qpl I see:
...
/usr/share/doc/copr-cli-1.29
/usr/share/doc/copr-cli-1.29/LICENSE
/usr/share/doc/copr-cli-1.29/README.rst
Which Fedora release?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 --- Comment #6 from Miroslav Suchý msu...@redhat.com --- Which Fedora release? Fedora 20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792
--- Comment #7 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Miroslav Suchý from comment #6)
Which Fedora release?
Fedora 20
I've done two builds, rawhide (%{_pkgdocdir} = /usr/share/doc/copr-cli) and
EPEL6 (%{_pkgdocdir} = /usr/share/doc/copr-cli-1.29); that's right.
Anyway this directory must be owned by -doc sub-package (just in Fedora).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added CC||anto.tra...@gmail.com --- Comment #1 from Antonio Trande anto.tra...@gmail.com --- Your copr-* packages are already in the Fedora repositories. Why new reviews? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? --- Comment #2 from Antonio Trande anto.tra...@gmail.com --- (In reply to Antonio Trande from comment #1) Your copr-* packages are already in the Fedora repositories. Why new reviews? Okay. I've read your mail just now. Taken for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077792] Review Request: copr-cli - Command line interface for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077792
--- Comment #3 from Antonio Trande anto.tra...@gmail.com ---
- BR 'make' can be omitted.
- -doc sub-package is independent by main package.
It must install own License files.
- '/usr/share/doc/copr-cli' directory is not owned
- Please, specify '%{python_sitelib}/' sub-directory owned by this package
and, above all, the .egg-info file.
Note: Package building fails in EPEL6.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: make
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 5 files have unknown license. Detailed output of
licensecheck in /home/sagitter/1077792-copr-cli/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/doc/copr-cli
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 378880 bytes in 33 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[!]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in copr-cli-
doc
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
