[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Ralf Corsepius changed: What|Removed |Added Blocks||665096 ||(rt4-dependencies-tracker) --- Comment #1 from Ralf Corsepius --- This package is a dependency of rt4-4.2.x Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=665096 [Bug 665096] rt4 tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074
Xavier Bachelot changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||xav...@bachelot.org
--- Comment #2 from Xavier Bachelot ---
The package looks good, only SHOULD stuff to take a look at. Fix before import
if you wish :
- You should set AUTOMATED_TESTING=1 in the test section and add a couple BR:s
for better test coverage (Test::CPAN::Meta, Perl::MinimumVersion,
Test::MinimumVersion, Test::Pod). One of the tests is still skipped though, I
haven't looked why.
- You should ask upstream to add a license file.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 2 files have unknown license. Detailed output of
licensecheck in /home/xavierb/1078074-perl-Set-Tiny/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[-]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Set
(perl-Set-Array, perl-Set-Scalar, perl-Set-Infinite, perl-Set-Crontab,
perl-Set-IntSpan, perl-DateTime-Set)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Descriptio
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Xavier Bachelot changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Ralf Corsepius changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Ralf Corsepius --- Thanks for the review, Xavier! (In reply to Xavier Bachelot from comment #2) > The package looks good, only SHOULD stuff to take a look at. Fix before > import if you wish : > - You should set AUTOMATED_TESTING=1 in the test section and add a couple > BR:s for better test coverage (Test::CPAN::Meta, Perl::MinimumVersion, > Test::MinimumVersion, Test::Pod). These days, most perl-module maintainers don't care about AUTOMATED_TESTING tests anymore (many maintainers seem to be trying hard to prevent us from running them), which has led me not to look into them anymore. I'll likely have a brief look into it after git import, but definitely won't invest much effort. > - You should ask upstream to add a license file. Nothing on this planet requires upstreams to do so. I have no idea why people are enforcing this - Likely it's rpmlint's brokenness ;) New Package SCM Request === Package Name: perl-Set-Tiny Short Description: Simple sets of strings Owners: corsepiu Branches: f19 f20 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 --- Comment #5 from Fedora Update System --- perl-Set-Tiny-0.01-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Set-Tiny-0.01-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 --- Comment #6 from Fedora Update System --- perl-Set-Tiny-0.01-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Set-Tiny-0.01-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- perl-Set-Tiny-0.01-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Set-Tiny-0.01-1.fc20 Resolution|--- |ERRATA Last Closed||2014-03-30 02:04:41 --- Comment #8 from Fedora Update System --- perl-Set-Tiny-0.01-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078074] Review Request: perl-Set-Tiny - Simple sets of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-Set-Tiny-0.01-1.fc20 |perl-Set-Tiny-0.01-1.fc19 --- Comment #9 from Fedora Update System --- perl-Set-Tiny-0.01-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
