[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jamie Nguyen changed: What|Removed |Added Blocks||1078470 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078470 [Bug 1078470] Review Request: nodejs-maxmin - Get pretty output of the original, minified gzipped size of a string/buffer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jamie Nguyen changed: What|Removed |Added Blocks|1078470 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078470 [Bug 1078470] Review Request: nodejs-maxmin - Get pretty output of the original, minified gzipped size of a string/buffer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jamie Nguyen changed: What|Removed |Added Depends On||1078467 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078467 [Bug 1078467] Review Request: nodejs-concat-stream - Writable stream that concatenates data and calls a callback with the result -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jamie Nguyen changed: What|Removed |Added Blocks||1078470 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078470 [Bug 1078470] Review Request: nodejs-maxmin - Get pretty output of the original, minified gzipped size of a string/buffer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jamie Nguyen changed: What|Removed |Added Depends On||977137 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=977137 [Bug 977137] Review Request: nodejs-zlib-browserify - Wrapper for zlib.js to allow for use in browsers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Bug 1078469 depends on bug 977137, which changed state. Bug 977137 Summary: Review Request: nodejs-zlib-browserify - Wrapper for zlib.js to allow for use in browsers https://bugzilla.redhat.com/show_bug.cgi?id=977137 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |ASSIGNED CC||zbys...@in.waw.pl Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
Issues
==
- LICENSE should be removed
- %check can be enabled
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
https://github.com/sindresorhus/gzip-size/pull/1
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 --- Comment #2 from Jamie Nguyen --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > - LICENSE should be removed https://bugzilla.redhat.com/show_bug.cgi?id=1078472#c2 > - %check can be enabled Thanks. I will enable before importing into git. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 --- Comment #4 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-gzip-size Short Description: Get the gzipped size of a string or buffer Owners: jamielinux patches Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 --- Comment #3 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-gzip-size Short Description: Get the gzipped size of a string or buffer Owners: jamielinux patches Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Bug 1078469 depends on bug 1078467, which changed state. Bug 1078467 Summary: Review Request: nodejs-concat-stream - Writable stream that concatenates data and calls a callback with the result https://bugzilla.redhat.com/show_bug.cgi?id=1078467 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078469] Review Request: nodejs-gzip-size - Get the gzipped size of a string or buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1078469 Jamie Nguyen changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-03-21 18:23:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
