[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.03-3 Resolution|--- |RAWHIDE Last Closed||2014-06-05 16:29:18 --- Comment #14 from Sven Nierlein sven.nierl...@consol.de --- build and upload completed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Sven Nierlein sven.nierl...@consol.de --- New Package SCM Request === Package Name: perl-Test-Image-GD Short Description: Module for testing images using GD Owners: sni Branches: f21 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Petr Šabata psab...@redhat.com --- Ok, I'm going to approve this. However, you've just added yet another BR entry for File::Spec while, in fact, you don't need any; the code only requires File::Spec::Functions (which you already list), despite what Makefile.PL says. Drop both of the File::Spec BRs before pushing. I suggest sorting the dependency list so you don't overlook things like this next timne. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #10 from Sven Nierlein sven.nierl...@consol.de --- perl compat requires added and updated BRs and requires according to cpanspec. new files are here: http://nierlein.com/fedora/2014-05-20/perl-Test-Image-GD.spec http://nierlein.com/fedora/2014-05-20/perl-Test-Image-GD-0.03-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #9 from Sven Nierlein sven.nierl...@consol.de --- New spec file is here: http://nierlein.com/fedora/2014-04-21/perl-Test-Image-GD.spec The middle dots were leftofers from copy past, they are now removed. I also increased the release number. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Alias||perl-Test-Image-GD -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #7 from Petr Šabata psab...@redhat.com --- Ok, this is better. Two more things, though. 1. Can you explain the MIDDLE DOTs in your %description? 2. Some people care about bumping the Release with every new submission, even for reviews. I do not, however you can't have multiple changelog entries for the same NVR. Either merge them into one or bump the Release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #8 from Sven Nierlein sven.nierl...@consol.de --- There was a complain about the NEVR in #1079733 already, so i will bump the number and upload new files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #5 from Sven Nierlein sven.nierl...@consol.de --- I updated the spec file and uploaded a source rpm here: http://nierlein.com/fedora/2014-04-06/perl-Test-Image-GD.spec http://nierlein.com/fedora/2014-04-06/perl-Test-Image-GD-0.03-1.fc21.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #6 from Sven Nierlein sven.nierl...@consol.de --- New source RPM: http://nierlein.com/fedora/2014-04-06/perl-Test-Image-GD-0.03-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Blocks||1080201 Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1080201 [Bug 1080201] Review Request: perl-Catalyst-View-GD - A Catalyst View for GD images -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #3 from Petr Šabata psab...@redhat.com --- I see you've removed some of the old cruft Ralf pointed out but not all of it. Since the answer to Do you intend to support rhel 6? is obviously no, drop the line 33, too. There are still one more missing build-time dependencies you should add: perl, used in the spec perl(File::Spec::Functions), used in various tests For the optional tests, you may also buildrequire: perl(Test::Pod) = 1.14 perl(Test::Pod::Coverage) = 1.04 Consider using the description from the POD instead of just paraphrasing the Summary. Package the README and Changes files as documentation, e.g. by adding the following to your %files section: %doc Changes README More tips: Line 39 is not needed and may be safely dropped. Sort your deps alphabetically; it's easier to maintain later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #4 from Sven Nierlein sven.nierl...@consol.de --- Thanks. Yes, i currently don't intend to support older releases and will focus on the upcoming ones. I will update the specs and src rpms and upload them over the weekend. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #2 from Sven Nierlein sven.nierl...@consol.de --- Updated spec and src rpm above. * Removed %clean, BuildRoot and %defattr. Added missing BR:s. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||1069988 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1069988 [Bug 1069988] Review Request: naemon - Open Source Host, Service And Network Monitoring Program -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #1 from Ralf Corsepius rc040...@freenet.de --- * These Requires: should be removed from the spec. Requires: perl(GD) Requires: perl(Scalar::Util) Requires: perl(Test::Builder) Rpm's perl-deptracker generates these (and others) automatically. * Some BR:s are missing. Please add: BuildRequires: perl(Exporter) BuildRequires: perl(Test::Builder::Tester) BuildRequires: perl(strict) BuildRequires: perl(warnings) * Do you intend to support rhel 6? If no, you can get rid of many rpm-anacronisms inside of your spec, such as %clean, rm -rf $RPM_BUILD_ROOT, BuildRoot:..., %defattr etc. NB: cpanspec is a tool aiming at assisting packagers. The spec files it generates are far from being perfect and usually require to be manually modified. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
