[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.05-4 Resolution|--- |RAWHIDE Last Closed||2014-12-28 07:00:04 --- Comment #12 from Sven Nierlein sven.nierl...@consol.de --- build and upload completed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Sven Nierlein sven.nierl...@consol.de --- New Package SCM Request === Package Name: perl-Excel-Template-Plus Short Description: An extension to the Excel::Template module Owners: sni Branches: f21 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 --- Comment #8 from Sven Nierlein sven.nierl...@consol.de --- finally... sorry for the delay. Here are the updated specs and source rpm file: http://nierlein.com/fedora/2014-12-19/perl-Excel-Template-Plus.spec http://nierlein.com/fedora/2014-12-19/perl-Excel-Template-Plus-0.05-4.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 David Dick dd...@cpan.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from David Dick dd...@cpan.org --- Builds fine at http://koji.fedoraproject.org/koji/taskinfo?taskID=8441644 rpmlint is ok (spelling warnings may be ignored) Package APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 --- Comment #7 from Sven Nierlein sven.nierl...@consol.de --- thanks for your detailed remarks. I will take care of them after my vacation, so don't expect any update soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 --- Comment #5 from Sven Nierlein sven.nierl...@consol.de --- sorry my bad, spec and source rpm is here: http://www.nierlein.com/fedora/2014-10-13/perl-Excel-Template-Plus-0.05-3.fc22.src.rpm http://www.nierlein.com/fedora/2014-10-13/perl-Excel-Template-Plus.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203
--- Comment #6 from David Dick dd...@cpan.org ---
Builds successfully at
http://koji.fedoraproject.org/koji/taskinfo?taskID=7857678
License is correct
You need to add all the perl modules that are used during the build, test and
install cycles. In this case, all the perl modules when running perl
Makefile.PL make make test make install
Therefore, add the following BRs
BR: perl(Exporter) # in lib/Test/Excel/Template/Plus.pm at line 15
BR: perl(File::Spec::Functions) # in t/001_basic.t at line 7
BR: perl(Test::Pod) = 1.14 # in t/pod.t at line 8
BR: perl(Test::Pod::Coverage) = 1.04 # in t/pod_coverage.t at line 8
BR: perl(Moose::Util::TypeConstraints) # in lib/Excel/Template/Plus/TT.pm at
line 4
BR: perl(strict) # in t/000_load.t at line 3
BR: perl(Test::Builder) # in lib/Test/Excel/Template/Plus.pm at line 8
BR: perl(warnings) # in t/000_load.t at line 4
Remove the following BRs
BR: perl(Module::Build) # you are using Makefile.PL, there is no need for
Module::Build.
BR: perl(File::Spec) # there is no reference to File::Spec, only
File::Spec::Functions, therefore, include File::Spec::Functions explicitly, rpm
will make the connection to install File::Spec
BR: perl(Test::More) # there are two separate instances in BuildRequires.
Remove one
Remove the following RunTime requires
Requires: perl(Excel::Template)
Requires: perl(IO::String)
Requires: perl(Spreadsheet::ParseExcel)
Requires: perl(Template)
Requires: perl(Test::Deep)
as these are automatically detected
Add the following lines just before the %description line
%global __requires_exclude
%{?__requires_exclude:__requires_exclude|}^perl\\(Moose\\)$
%global __requires_exclude %__requires_exclude|^perl\\(MooseX::Param\\)$
as your explicitly versioned run time requires make the generic requires
unnecessary.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 David Dick dd...@cpan.org changed: What|Removed |Added CC||dd...@cpan.org Assignee|nob...@fedoraproject.org|dd...@cpan.org Flags||fedora-review? --- Comment #4 from David Dick dd...@cpan.org --- (In reply to Sven Nierlein from comment #3) I added the missing perl compat requires and updated BRs and requires according to cpanspec. I also change the source url to the generic cpan url. New files are here: http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus.spec http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus-0.05-3.fc21. noarch.rpm Hi Sven, Thats an RPM not an SRPM that you've uploaded. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 David Dick dd...@cpan.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Bug 1080203 depends on bug 1079745, which changed state. Bug 1079745 Summary: Review Request: perl-Excel-Template - Create Excel files from templates https://bugzilla.redhat.com/show_bug.cgi?id=1079745 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 --- Comment #3 from Sven Nierlein sven.nierl...@consol.de --- I added the missing perl compat requires and updated BRs and requires according to cpanspec. I also change the source url to the generic cpan url. New files are here: http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus.spec http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus-0.05-3.fc21.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 --- Comment #2 from Sven Nierlein sven.nierl...@consol.de --- new spec file: http://nierlein.com/fedora/2014-04-21/perl-Excel-Template-Plus.spec i only changed the release number. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Alias||perl-Excel-Template-Plus -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Blocks||1080204 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1080204 [Bug 1080204] Review Request: perl-Catalyst-View-Excel-Template-Plus - Catalyst View for Excel::Template::Plus -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de Depends On||1079745 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1079745 [Bug 1079745] Review Request: perl-Excel-Template - Create Excel files from templates -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 --- Comment #1 from Sven Nierlein sven.nierl...@consol.de --- updated spec file according to comments from the related bugs and uploaded new files: http://nierlein.com/fedora/2014-04-06/perl-Excel-Template-Plus.spec http://nierlein.com/fedora/2014-04-06/perl-Excel-Template-Plus-0.05-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Sven Nierlein sven.nierl...@consol.de changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||1069988 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1069988 [Bug 1069988] Review Request: naemon - Open Source Host, Service And Network Monitoring Program -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
