[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #1 from David Shea --- Updated to latest upstream version. Spec URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover.spec SRPM URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover-0.4.0-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #2 from David Shea --- Updated to latest upstream version. Spec URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover.spec SRPM URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover-0.4.1-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #3 from David Shea --- Updated to latest upstream version. Spec URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover.spec SRPM URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover-0.4.2-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #4 from David Shea --- Updated to latest upstream version. Spec URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover.spec SRPM URL: http://dshea.fedorapeople.org/python-diff-cover/v1/python-diff-cover-0.4.3-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 David Shea changed: What|Removed |Added Depends On||1117483 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1117483 [Bug 1117483] Review Request: python-jinja2_pluralize - Jinja2 pluralize filters -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #5 from David Shea --- Updated to latest upstream version. Spec URL: http://dshea.fedorapeople.org/python-diff-cover/0.5.4-1/python-diff-cover.spec SRPM URL: http://dshea.fedorapeople.org/python-diff-cover/0.5.4-1/python-diff-cover-0.5.4-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 Julien Enselme changed: What|Removed |Added Status|NEW |ASSIGNED CC||juj...@jujens.eu Assignee|nob...@fedoraproject.org|juj...@jujens.eu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #6 from David Shea --- Updated to latest upstream version. Spec URL: http://dshea.fedorapeople.org/python-diff-cover/0.5.7-1/python-diff-cover.spec SRPM URL: http://dshea.fedorapeople.org/python-diff-cover/0.5.7-1/python-diff-cover-0.5.7-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #7 from David Shea --- I guess it would help if I actually cleaned up the dependencies instead of just talking about it in the changelog. Spec URL: http://dshea.fedorapeople.org/python-diff-cover/0.5.7-2/python-diff-cover.spec SRPM URL: http://dshea.fedorapeople.org/python-diff-cover/0.5.7-2/python-diff-cover-0.5.7-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #8 from David Shea --- New upstream version, and fixed a missing requires in the python3 package. Spec URL: https://dshea.fedorapeople.org/python-diff-cover/0.6.0-1/python-diff-cover.spec SRPM URL: https://dshea.fedorapeople.org/python-diff-cover/0.6.0-1/python-diff-cover-0.6.0-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 Bug 1082656 depends on bug 1117483, which changed state. Bug 1117483 Summary: Review Request: python-jinja2_pluralize - Jinja2 pluralize filters https://bugzilla.redhat.com/show_bug.cgi?id=1117483 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656
--- Comment #9 from Julien Enselme ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 11 files have unknown license. Detailed output of
licensecheck in /run/media/jenselme/Data/1082656-python-diff-
cover/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[X]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 102400 bytes in 6 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3
-diff-cover
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[X]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that th
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #10 from David Shea --- Ok? So now what? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #11 from Julien Enselme --- [!]: %check is present and all tests pass. => Please add the %check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #12 from David Shea --- There are no tests. Or rather, there are no tests in the source distribution. The tests in git only make sense when run against a git tree. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 Julien Enselme changed: What|Removed |Added Flags||fedora-review+ --- Comment #13 from Julien Enselme --- Didn't notice that. Sorry. Approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 David Shea changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from David Shea --- New Package SCM Request === Package Name: python-diff-cover Short Description: Automatically find diff lines that need test coverage Upstream URL: https://pypi.python.org/pypi/diff_cover Owners: dshea Branches: f20 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 --- Comment #16 from Fedora Update System --- python-diff-cover-0.6.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-diff-cover-0.6.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- python-diff-cover-0.6.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1082656] Review Request: python-diff-cover - Automatically find diff lines that need test coverage
https://bugzilla.redhat.com/show_bug.cgi?id=1082656 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-diff-cover-0.6.0-1.f ||c20 Resolution|--- |ERRATA Last Closed||2014-08-29 23:57:51 --- Comment #18 from Fedora Update System --- python-diff-cover-0.6.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
