[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Antonio Trande  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR),|
   |505154 (FE-SCITECH) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-05-13 14:20:00



--- Comment #39 from Antonio Trande  ---


*** This bug has been marked as a duplicate of bug 1335988 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #38 from Han Frederic  ---
Thank you! If it helps here is a current update.

http://webusers.imj-prg.fr/~frederic.han/fedora/SPECS/giac.spec

http://webusers.imj-prg.fr/~frederic.han/fedora/SRPMS/giac-1.2.2-1.fc22.src.rpm

The testsuite is very sentitive and needed a small patch. (I took the one I
have done for the sage spkg)

I have done something with the upstream naming scheme (1.2.2-43) but you may
find a better solution...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #37 from Antonio Trande  ---
(In reply to Han Frederic from comment #36)
> (In reply to Antonio Trande from comment #35)
> > You need a sponsor; do you still want become an official packager? If yes,
> > please update your package, i can review again, but i can't sponsor you yet.
> 
> Thank you for this proposition. I need to think if I still have time for
> this because we both worked alot on this 2 years ago. May be it would be
> better for the package if an official packager could take the job.
> I will try to help with an updated version.

I'm going to complete this packaging in this case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #36 from Han Frederic  ---
(In reply to Antonio Trande from comment #35)
> You need a sponsor; do you still want become an official packager? If yes,
> please update your package, i can review again, but i can't sponsor you yet.

Thank you for this proposition. I need to think if I still have time for this
because we both worked alot on this 2 years ago. May be it would be better for
the package if an official packager could take the job.
I will try to help with an updated version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #35 from Antonio Trande  ---
You need a sponsor; do you still want become an official packager? If yes,
please update your package, i can review again, but i can't sponsor you yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Han Frederic  changed:

   What|Removed |Added

  Flags|needinfo?(han@math.jussieu. |
   |fr) |



--- Comment #34 from Han Frederic  ---
(In reply to Antonio Trande from comment #33)
> Is this package still under review?
I don't have news about a review process for this package. There was no
activity for a long time and this 1.1.1 version is now old with respect to the
current stable upstream source avaible in: 
http://www-fourier.ujf-grenoble.fr/~parisse/debian/dists/stable/main/source/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com
  Flags||needinfo?(han@math.jussieu.
   ||fr)



--- Comment #33 from Antonio Trande  ---
Is this package still under review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #32 from Upstream Release Monitoring 
 ---
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
for f22-candidate and
git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #31 from Han Frederic h...@math.jussieu.fr ---
Update to the latest 1.1.1 version of the upstream source.
This upstream 1.1.1 file should not change anymore, next modifications will be
in 1.1.2. 
(cf: http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=8t=1490start=15)


The corresponding srpm is avaible here:

http://www.math.jussieu.fr/~han/fedora/1083941/giac-1.1.1-1.fc20.src.rpm 

or on this koji scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=7120387

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #27 from Han Frederic h...@math.jussieu.fr ---
I have updated to giac 1.1.1 version (current stable) and cleanup the giac.spec
accordingly. 
Also add a new dependency because of some new features in 1.1.1

http://www.math.jussieu.fr/~han/fedora/1083941/comment27/giac.spec
The scratch build on koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=7109745

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 CC||i...@cicku.me



--- Comment #28 from Christopher Meng i...@cicku.me ---
Thanks for package giac, I do need this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #29 from Christopher Meng i...@cicku.me ---
%dir %{_datadir}/icons/hicolor 
%dir %{_datadir}/icons/hicolor/128x128
%dir %{_datadir}/icons/hicolor/128x128/apps
%dir %{_datadir}/icons/hicolor/128x128/mimetypes
%dir %{_datadir}/icons/hicolor/16x16
%dir %{_datadir}/icons/hicolor/16x16/apps
%dir %{_datadir}/icons/hicolor/16x16/mimetypes
%dir %{_datadir}/icons/hicolor/256x256
%dir %{_datadir}/icons/hicolor/256x256/apps
%dir %{_datadir}/icons/hicolor/256x256/mimetypes
%dir %{_datadir}/icons/hicolor/32x32
%dir %{_datadir}/icons/hicolor/32x32/apps
%dir %{_datadir}/icons/hicolor/32x32/mimetypes
%dir %{_datadir}/icons/hicolor/64x64
%dir %{_datadir}/icons/hicolor/64x64/apps
%dir %{_datadir}/icons/hicolor/64x64/mimetypes

You should add requires of hicolor-icon-theme instead of owning them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #30 from Han Frederic h...@math.jussieu.fr ---
Thank you,
so I have remove these lines.

http://www.math.jussieu.fr/~han/fedora/1083941/comment30/giac.spec

The 1.1.1 tests have been updated with the legal pari syntax so the pari crash

https://bugzilla.redhat.com/show_bug.cgi?id=1104802

won't appear anymore during the giac check.

NB: It is my first package and I still have many things to learn about Fedora,
so if someone have the time to take the package feel free to take it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Han Frederic h...@math.jussieu.fr changed:

   What|Removed |Added

 Depends On|1104802 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1104802
[Bug 1104802] gp segfault
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Blocks||505154 (FE-SCITECH)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #26 from Han Frederic h...@math.jussieu.fr ---
Thank you for this crash report. I can manage to avoid it by swiching to the
legal pari syntax with:

sed -i
's/pari_ellpow(\[0,1,0,2,-15\]/pari_ellpow(pari_ellinit(\[0,1,0,2,-15\])/g'
check/TP08*.cas


but before updating the giac.spec I will have a look at the 1.1.1 version of
giac to see if it is time to switch to it. (It would clean the giac.spec a lot
because many changes were accepted by upstream)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Jerry James loganje...@gmail.com changed:

   What|Removed |Added

 CC||loganje...@gmail.com
 Depends On||1104802



--- Comment #25 from Jerry James loganje...@gmail.com ---
There is currently a test failure when building in Rawhide, due to bug 1104802.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1104802
[Bug 1104802] gp segfault
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #24 from Han Frederic h...@math.jussieu.fr ---
Add a scratch build link of the latest version:
https://koji.fedoraproject.org/koji/taskinfo?taskID=6820481

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #23 from Han Frederic h...@math.jussieu.fr ---
Thank you for your comments, and sorry for the delay I was off line last week.

. So I have allowed the doc package to be installable independently. To obtain
this I took M. Schwendt idea of a filesystem package because some directories 
contain doc files and also files needed at runtime.

. Some of  remarks in comment22 didn't look to match the version of giac.spec
in the link of comment 21, sorry for the confusion, as discussions with A.
Trande made this file moving a lot I got the (bad) idea to keep old files and
add a new link for the newest version. The main difference with the version you
considered is that I have used a file listing to build the doc list.

. From previous discussions I let the directories /usr/share/mime and
/usr/share/mime/packages without owner and without the extra dep to
shared-mime-info, but I don't find references to this case in the fedora doc. 

So now I will alway update the original link to the newest version.
best regards.
http://www.math.jussieu.fr/~han/fedora/1083941/comment23/giac.spec
http://www.math.jussieu.fr/~han/fedora/1083941/comment23/giac-1.1.0-1.fc20.src.rpm
http://www.math.jussieu.fr/~han/fedora/1083941/comment23/rpmlint.txt

F.Han

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #22 from Michael Schwendt bugs.mich...@gmx.net ---
 %package doc
 Summary: Detailled html documentation for Giac/Xcas

Detailed
HTML

 Requires: %{name}%{?_isa} = %{version}-%{release}
 BuildArch: noarch

If it is noarch, the dependency cannot be arch-specific. The noarch package
will be copied into all repositories.

Further, plain documentation packages ought to be installable without having to
install base package dependencies (i.e. the application and its dep-chain).
Especially, if you can read the documentation with any external browser (e.g.
PDF, HTML, …), separate documentation packages are a convenience for people who
want to peruse/study them.


 %doc %{_docdir}/giac/LICENSE

Files below %_docdir are marked as %doc implicitly. See: rpm -E %__docdir_path

Currently, the package does not include the %_docdir/giac directory:

 
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
  https://fedoraproject.org/wiki/Packaging:UnownedDirectories


 %{_datadir}/giac/doc/*/keywords
 %{_datadir}/giac/aide_cas

More unowned directories here: /usr/share/giac, /usr/share/giac/doc,
/usr/share/giac/doc/* also at least one dir


 %{_datadir}/icons/hicolor/128x128/apps/xcas.png

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership


 %files doc
 %doc README COPYING README.fedora
 %{_datadir}/giac/
 %{_docdir}/giac/

Oh, you've got the dependency chain backwards. The base package ought to
include these dirs. Especially, since a line such as

  %{_datadir}/giac/

includes not just the directory but everything in it. That sounds wrong for the
-doc subpackage.

Alternatively, if there are many subpackages and many base dirs to include, a
packaging technique to apply is to create a -filesystem subpackage, which
contains the common empty dirs.

Plus, plain %doc for local files and %_docdir/giac conflict with eachother.
Decide on either %doc or %_docdir/giac:

  https://fedorahosted.org/fpc/ticket/338
  https://fedoraproject.org/wiki/Changes/UnversionedDocdirs

To sum up, as of Fedora 20, the %doc magic stores files in %_docdir/%name -
also known as the new macro %_pkgdocdir. As a side-effect, it includes the
directory and everything in it, regardless of which files you specify in the
%doc lines.

For this particular package, that currently only means the two lines

  %doc README COPYING README.fedora
  %{_docdir}/giac/

include files more than once, since the former includes also the %_docdir/giac
directory entry, and the latter includes it again plus everything in it (for
Fedora 20 also the three files on the %doc line).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #21 from Han Frederic h...@math.jussieu.fr ---
Ok, so 
1) I have used the -f for the file list.
2) for /usr/share/mime and /usr/share/mime/packages without owner:
I have tried to install the file from the Makefile and the result was the
same. So I don't shared their ownership as you asked (the fedora doc just say
to not add shared-mime-info as an extra dep if not necessary ) let me know if I
should change this.
http://www.math.jussieu.fr/~han/fedora/1083941/comment21/giac.spec
http://www.math.jussieu.fr/~han/fedora/1083941/comment21/giac-1.1.0-1.fc20.src.rpm
http://www.math.jussieu.fr/~han/fedora/1083941/comment21/rpmlint.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #19 from Han Frederic h...@math.jussieu.fr ---
Thanks for your answer on mime, I will try to avoid the *manually*.

 Also, under '%files' section
 
 %dir %{_datadir}/giac
 %dir %{_datadir}/giac/doc
 %dir %{_datadir}/giac/doc/de
 %dir %{_datadir}/giac/doc/el
 %dir %{_datadir}/giac/doc/en
 %dir %{_datadir}/giac/doc/es
 %dir %{_datadir}/giac/doc/fr
 %dir %{_datadir}/giac/doc/pt
 %dir %{_datadir}/giac/doc/zh
 #The following files are Required at runtime by icas AND xcas. 
 #   (Ex: if LANG is fr, alea(5) should give an INT)
 #   Moreover, without aide_cas the keywords files are not found in icas 
 #   and xcas. Additionally xcas uses it for tab completions.
 %{_datadir}/giac/doc/*/keywords
 %{_datadir}/giac/aide_cas
 %{_datadir}/giac/doc/aide_cas
 
 may not be listed because already included under '%files doc' with
 
 %{_datadir}/giac/ ---
 
 'giac-doc' will be installed always together with 'giac'; those files will
 be available in runtime however.
I understand why installing giac-doc implies installing giac,
but why isn't it possible for giac (and giac-xcas) packages to be installed
without giac-doc? In that situation  if I remove the entries: 
%{_datadir}/giac/doc/*/keywords
%{_datadir}/giac/aide_cas
%{_datadir}/giac/doc/aide_cas
from giac %files
they won't be installed and icas won't run properly.(worse than just some doc
not found)

Do you prefer that I try to build the giac-doc list of files and dir from some
file built automatically in the spec, so that there are no shared files and dir
between giac and giac-doc?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #20 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Han Frederic from comment #19)
  Also, under '%files' section
  
  %dir %{_datadir}/giac
  %dir %{_datadir}/giac/doc
  %dir %{_datadir}/giac/doc/de
  %dir %{_datadir}/giac/doc/el
  %dir %{_datadir}/giac/doc/en
  %dir %{_datadir}/giac/doc/es
  %dir %{_datadir}/giac/doc/fr
  %dir %{_datadir}/giac/doc/pt
  %dir %{_datadir}/giac/doc/zh
  #The following files are Required at runtime by icas AND xcas. 
  #   (Ex: if LANG is fr, alea(5) should give an INT)
  #   Moreover, without aide_cas the keywords files are not found in icas 
  #   and xcas. Additionally xcas uses it for tab completions.
  %{_datadir}/giac/doc/*/keywords
  %{_datadir}/giac/aide_cas
  %{_datadir}/giac/doc/aide_cas
  
  may not be listed because already included under '%files doc' with
  
  %{_datadir}/giac/ ---
  
  'giac-doc' will be installed always together with 'giac'; those files will
  be available in runtime however.
 I understand why installing giac-doc implies installing giac,
 but why isn't it possible for giac (and giac-xcas) packages to be installed
 without giac-doc? In that situation  if I remove the entries: 
 %{_datadir}/giac/doc/*/keywords
 %{_datadir}/giac/aide_cas
 %{_datadir}/giac/doc/aide_cas
 from giac %files
 they won't be installed and icas won't run properly.(worse than just some
 doc not found)

Ops! You're right. It's a my inattention.
It's possible of course.

Better if 'giac' owns %{_datadir}/giac/doc, %{_datadir}/giac/doc/* and all
files it needs in runtime.
Any files else in %{_datadir}/giac/doc will be owned by 'giac-doc'.

In a few words, pay attention to don't list same files and/or directories more
times under all %files section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #15 from Han Frederic h...@math.jussieu.fr ---
OK,
I have changed  the spec only and regenerate the srpm:
http://www.math.jussieu.fr/~han/fedora/1083941/comment15/giac.spec
http://www.math.jussieu.fr/~han/fedora/1083941/comment15/giac-1.1.0-1.fc20.src.rpm
http://www.math.jussieu.fr/~han/fedora/1083941/comment15/rpmlint.txt

For 1. I have change the License tag and deleted the texinfo.tex and use the
texinfo package to rebuild the giac_*.info + utf8 conversion

For 2. I have added those %dir but I wonder why not those 2:
(I have tried with and without them and I didn't see complains in both cases.
(neither system-dir nor shared warning)
#%dir %{_datadir}/applications
#%dir %{_datadir}/pixmaps

Where can I find the list of system-dir that must not be included. 
(Ex: it is not clear for me why /usr/share/icons gave me the system-dir error
and not /usr/share/applications)

Did 3. but need to modify configure/makefiles and regenerate
Did 4.

About 5. I removed the extra +x, and add a warning about the .xws Indeed, they
are not text files, they are saved examples from xcas and any uft8 conversion
will give a mess. Is there some way to mark them as non text files to avoid
those warning?
All the best.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #16 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Han Frederic from comment #15)
 For 2. I have added those %dir but I wonder why not those 2:
 (I have tried with and without them and I didn't see complains in both cases.
 (neither system-dir nor shared warning)
 #%dir %{_datadir}/applications
 #%dir %{_datadir}/pixmaps

%{_datadir}/applications and %{_datadir}/pixmaps are owned by a main system
package (filesystem). Your package doesn't need to own them.

Verify with command:

 yum provides /usr/share/pixmaps /usr/share/applications  

 
 Where can I find the list of system-dir that must not be included. 
 (Ex: it is not clear for me why /usr/share/icons gave me the system-dir
 error and not /usr/share/applications)

/usr/share/icons is not in the review log (comment#14) and should not be owned
by your package. 
Not even /usr/share/mime and /usr/share/mime/packages.
Sorry, I had not noted the latter ones.

 
 Did 3. but need to modify configure/makefiles and regenerate

Should not be so. ABOUT-NLS file says:

By default, this package will be installed to allow translation of
messages.  It will automatically detect whether the system already
provides the GNU `gettext' functions.  If not, the included GNU
`gettext' library will be used.  This library is wholly contained
within this package, usually in the `intl/' subdirectory, so prior
installation of the GNU `gettext' package is _not_ required.

Therefore, you just need:

%prep
...
rm -rf intl/*.h
rm -rf intl/*.c

%build
%configure --enable-static=0 --with-included-gettext=no --enable-nls
...

 
 About 5. I removed the extra +x, and add a warning about the .xws Indeed,
 they are not text files, they are saved examples from xcas and any uft8
 conversion will give a mess. Is there some way to mark them as non text
 files to avoid those warning?
 All the best.

I think we can just ignore all file-not-utf8 warnings ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #17 from Han Frederic h...@math.jussieu.fr ---
 %{_datadir}/applications and %{_datadir}/pixmaps are owned by a main system
 package (filesystem). Your package doesn't need to own them.
 
 Verify with command:
 
  yum provides /usr/share/pixmaps /usr/share/applications  
good, so the answer is dir of the package filesystem must not be owned by our
package

 /usr/share/icons is not in the review log (comment#14) and should not be
 owned by your package. 
Yes it was an example for my question
 Not even /usr/share/mime and /usr/share/mime/packages.
 Sorry, I had not noted the latter ones.

Sorry I am lost, do I missunderstand the comma presentation?

/usr/share/mime and /usr/share/mime/packages look to be in your review of

[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/16x16/mimetypes, /usr/share/giac/doc/de,
 /usr/share/icons/hicolor/32x32/apps, /usr/share/mime,  ===here?===

 /usr/share/icons/hicolor/64x64/mimetypes, /usr/share/icons/hicolor/16x16,
 /usr/share/icons/hicolor, /usr/share/mime/packages,   ===here?===

but they belong to: shared-mime-info-1.2-2.fc21.x86_64 so was I right to
package those dir?


  About 5. I removed the extra +x, and add a warning about the .xws Indeed,
  they are not text files, they are saved examples from xcas and any uft8
  conversion will give a mess. Is there some way to mark them as non text
  files to avoid those warning?
  All the best.
 
 I think we can just ignore all file-not-utf8 warnings ;)

Good!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #18 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Han Frederic from comment #17)
 
  /usr/share/icons is not in the review log (comment#14) and should not be
  owned by your package. 
 Yes it was an example for my question
  Not even /usr/share/mime and /usr/share/mime/packages.
  Sorry, I had not noted the latter ones.
 
 Sorry I am lost, do I missunderstand the comma presentation?
 
 /usr/share/mime and /usr/share/mime/packages look to be in your review of
  
 [!]: Package must own all directories that it creates.
  Note: Directories without known owners:
  /usr/share/icons/hicolor/16x16/mimetypes, /usr/share/giac/doc/de,
  /usr/share/icons/hicolor/32x32/apps, /usr/share/mime,  ===here?===
 
  /usr/share/icons/hicolor/64x64/mimetypes,
 /usr/share/icons/hicolor/16x16,
  /usr/share/icons/hicolor, /usr/share/mime/packages,   ===here?===
 
 but they belong to: shared-mime-info-1.2-2.fc21.x86_64 so was I right to
 package those dir?
  

mime/* dirs are listed because *manually* created probably.

Also, under '%files' section

%dir %{_datadir}/giac
%dir %{_datadir}/giac/doc
%dir %{_datadir}/giac/doc/de
%dir %{_datadir}/giac/doc/el
%dir %{_datadir}/giac/doc/en
%dir %{_datadir}/giac/doc/es
%dir %{_datadir}/giac/doc/fr
%dir %{_datadir}/giac/doc/pt
%dir %{_datadir}/giac/doc/zh
#The following files are Required at runtime by icas AND xcas. 
#   (Ex: if LANG is fr, alea(5) should give an INT)
#   Moreover, without aide_cas the keywords files are not found in icas 
#   and xcas. Additionally xcas uses it for tab completions.
%{_datadir}/giac/doc/*/keywords
%{_datadir}/giac/aide_cas
%{_datadir}/giac/doc/aide_cas

may not be listed because already included under '%files doc' with

%{_datadir}/giac/ ---

'giac-doc' will be installed always together with 'giac'; those files will be
available in runtime however.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #11 from Han Frederic h...@math.jussieu.fr ---
(In reply to Han Frederic from comment #7)
 Dear antonio,
 . I have managed to adapt the 1.1.1 make check running from the spec.
 
 But before submitting a new spec I have some questions.
 
 . I found GPLv3 and GPLv2 files in the original 1.1.0 source archive, so I
 can put them where we want to. But GPLv2 was baddly located in the original
 1.1.0 source so I asked upstream for some clean up about License (code vs
 non fr doc). 
 As a consequence all the GPLv2+ files in the doc were raised in 1.1.1 to
 GPLv3+. So do you think we can release the non fr DOC under GPLV3+ with the
 1.1.0 package?
 
 (In term of binaries, 1.1.1 is recent and evolving while 1.1.0 is fixed,
 that's why I worked on the 1.1.0 packaging.)
 
 best
 
 F.H

Add some comments (and links):
B.Parisse's answer (in french) to my post that he had raised all the GPLv2+ doc
to GPLv3+ to have a homogeneous situation:
http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=5t=1458
this modification was effective since the 9 Apr 2014 in the README of:
http://www-fourier.ujf-grenoble.fr/~parisse/giac/giac-1.1.1.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #12 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Antonio Trande from comment #10)
 As a consequence all the GPLv2+ files in the doc were raised in 1.1.1 to 
 GPLv3+. So do you think we can release the non fr DOC under GPLV3+ with the 
 1.1.0 package?
 
 Okay so; leave a comment to your
 https://bugzilla.redhat.com/show_bug.cgi?id=1083941#c7

I always refer to the SPEC file when I say leave a comment  :D

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #13 from Han Frederic h...@math.jussieu.fr ---
:D

Dear antonio,
I have updated the spec and SRPM.
Spec URL: http://www.math.jussieu.fr/~han/fedora/SPECS/giac.spec
SRPM URL:
http://www.math.jussieu.fr/~han/fedora/SRPMS/giac-1.1.0-1.fc20.src.rpm
rpmlint output: http://www.math.jussieu.fr/~han/fedora/rpmlint-giac.txt


1. Due to the confusion, I have removed the README patch and package the
original 1.1.0 README unchanged, so rpmlint will detect a bad FSF address, but
I add a README.fedora to explain.

2. I put all the files of /usr/doc/giac in the doc package except the LICENSE
file.

3. I have renamed the giac-gui package to giac-xcas because many xcas users
doesn't know the name giac. But if you don't like this you can change it back.

4. add a check patch

(and some other changes, cf changelog)

5. about the make dvi, I found equivalent pdf files and I asked parisse who
confirmed that it was an obsolote instruction and removed it from the 1.1.1
INSTALL.

Best 
Frederic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #7 from Han Frederic h...@math.jussieu.fr ---
Dear antonio,
. I have managed to adapt the 1.1.1 make check running from the spec.

But before submitting a new spec I have some questions.

. I found GPLv3 and GPLv2 files in the original 1.1.0 source archive, so I can
put them where we want to. But GPLv2 was baddly located in the original 1.1.0
source so I asked upstream for some clean up about License (code vs non fr
doc). 
As a consequence all the GPLv2+ files in the doc were raised in 1.1.1 to
GPLv3+. So do you think we can release the non fr DOC under GPLV3+ with the
1.1.0 package?

(In term of binaries, 1.1.1 is recent and evolving while 1.1.0 is fixed, that's
why I worked on the 1.1.0 packaging.)

best

F.H

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #8 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Han Frederic from comment #7)
 As a consequence all the GPLv2+ files in the doc were raised in 1.1.1 to
 GPLv3+. So do you think we can release the non fr DOC under GPLV3+ with the
 1.1.0 package?
 

Are you sure?

README in giac-1.1.1 says:

* Documentation:
  The on-line help is included in xcas and giac/cas. The resposible
file is doc/aide_cas. It is released under the GPL version 2 or above
and is copyrighted by R. de Graeve, B. Parisse and M. Lopez de la Fuente.
  There is currently no English complete documentation. A tutorial
is available in French and English, released under the GPL version 2,
copyrighted by B. Parisse. A few information are also available in the
files giac_us.texinfo and giac_es.texinfo, both files are released under
the GPL version 2 or above and are (c) B. Parisse or M. Lopez de la Fuente.
  The French documentation is *not* released under the GPL. It is (c)
by Renee de Graeve. It can be freely distributed for non commercial purpose.
Other kind of redistributions require the consent of the copyright holder.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #9 from Han Frederic h...@math.jussieu.fr ---
Yes, see Parisse's answer to my post:
http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=5t=1458

The problem is that 1.1.1 is frequently moving, that's why I had considered the 
1.1.0 packaging.

since 2 days the readme of:
http://www-fourier.ujf-grenoble.fr/~parisse/giac/giac-1.1.1.tar.gz

have:
...
* Documentation:
  The on-line help is included in Xcas and giac/icas. The resposible
file is doc/aide_cas. It is released under the GPL version 3 or above
and is copyrighted by R. de Graeve, B. Parisse (English/French), M. Lopez de la
Fuente
and X. Vidaux (Spanish), and A. Akritas (Greek).
  The English documentation is currently incomplete (help welcome!). A tutorial
is available in English, released under the FDL,
copyrighted by B. Parisse. A few information are also available in the
files giac_us.texinfo and giac_es.texinfo, both files are released under
the GPL version 3 or above and are (c) B. Parisse or M. Lopez de la Fuente.
  The French documentation is *not* released under the GPL. It is (c)
by Renee de Graeve. It can be freely distributed for non commercial purpose.
Other kind of redistributions require the consent of the copyright holder.


...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #10 from Antonio Trande anto.tra...@gmail.com ---
As a consequence all the GPLv2+ files in the doc were raised in 1.1.1 to 
GPLv3+. So do you think we can release the non fr DOC under GPLV3+ with the 
1.1.0 package?

Okay so; leave a comment to your
https://bugzilla.redhat.com/show_bug.cgi?id=1083941#c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #4 from Han Frederic h...@math.jussieu.fr ---
Thanks again for your help,
I have put updated versions here:
Spec URL: http://www.math.jussieu.fr/~han/fedora/SPECS/giac.spec
SRPM URL: http://www.math.jussieu.fr/~han/fedora/SRPMS/giac-1.1.0-1.src.rpm

For 4. I put comments in  giac.spec. (did you want them in the description
field?)

For 5. The licence info was in the README so I put a link, but some parts were
old and I asked for a refresh. So I patch the README with the giac-1.1.1
README.

For 6. The english html doc is good. (about 1700 files and 12Mo) but the french
one was 6 times more.
I'am trying to provide some minimal man pages, is there some fedora script that
I should use to install man pages?

For 8. This make check won't work for an automatic build, the outputs are too
old.

For 9. I have done a patch to allow -Werror=format-security and reported it.

Best regards
Frederic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #5 from Antonio Trande anto.tra...@gmail.com ---
Created attachment 883764
  -- https://bugzilla.redhat.com/attachment.cgi?id=883764action=edit
giac.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #6 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Han Frederic from comment #4)

1. ---
 For 4. I put comments in  giac.spec. (did you want them in the description
 field?)

No. Here, with explicit, I meant putting all executables under '%files'
section:

%{_bindir}/icas
%{_bindir}/giac
%{_bindir}/xcas
%{_bindir}/pgiac

Rather, you may split in more sub-packages further.
See file that I attached.

2. --
 
 For 5. The licence info was in the README so I put a link, but some parts
 were old and I asked for a refresh. So I patch the README with the
 giac-1.1.1 README.

I think it's no so simple.
We need complete license files. See
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
Talk about with upstream.

Quoting README file:

The giac library and the xcas program are released under the GPL license,
version 3 or above, as published by the Free Software Foundation,
...
The on-line help is included in xcas and giac/cas. The resposible
file is doc/aide_cas. It is released under the GPL version 2 or above
and is copyrighted by R. de Graeve, B. Parisse and M. Lopez de la Fuente.

Both these licenses are compatible. Main package must to have 'GPLv3+' License
tag; -doc subpackage the 'GPLv2+ instead.

There is also documentation no compiled. See INSTALL file.

3. -
Files above are needed at runtime and the directories which contain them are
owned by -doc sub-package; -doc subpackage requires main package. That's fine.
Both packages could also co-own those directories which contain the files
needed at runtime (see
http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function)
but, since GUI will use all documentation files if called  by its Help menu,
'giac-doc' sub-package must requires 'giac' (like so happens for 'giac-devel').
In fine, giac/doc/ directory is entirely owned by 'giac-doc' that *must* be
installed together with 'giac'. 

See file attached.

4. -

 
 For 6. The english html doc is good. (about 1700 files and 12Mo) but the
 french one was 6 times more.
 I'am trying to provide some minimal man pages, is there some fedora script
 that I should use to install man pages?

Not one in particular.
As you see, I've just installed them then build system will gzip manpage
files. 

5. -
 
 For 8. This make check won't work for an automatic build, the outputs are
 too old.
 

And in newest release?

6. 

Please, update %Changelog section when change the SPEC file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #2 from Han Frederic h...@math.jussieu.fr ---
Dear Trande,
thanks a lot for your helpfull comments. So I have done a new spec.

Spec URL: http://www.math.jussieu.fr/~han/fedora/SPECS/giac.spec
SRPM URL:
http://www.math.jussieu.fr/~han/fedora/SRPMS/giac-1.1.0-1.fc20.src.rpm
rpmlint output: http://www.math.jussieu.fr/~han/fedora/rpmlint-giac.txt

Best regards

Frederic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #3 from Antonio Trande anto.tra...@gmail.com ---
Okay, we can go on.

1. 'rm -rf $RPM_BUILD_ROOT' 
   '%clean' section 
all file permission settings (%defattr..)

are not necessary anymore.
See http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

2. No mix $RPM_BUILD_ROOT and %{buildroot}; use just one of them.

3. rm -rf `find %{buildroot}%{_datadir}/giac -empty`
   rm -rf `find %{buildroot}%{_datadir}/giac -name *~`
   rm -rf `find %{buildroot}%{_datadir}/doc/giac -empty`
   rm -rf `find %{buildroot}%{_datadir}/doc/giac -name *~`

A 'find %{buildroot} -size 0 -delete' should be sufficient

4. Please, make %{_bindir}/* more explicit.

5. %doc doesn't list any License file.

6. %doc %{_datadir}/doc/giac
   %doc %{_datadir}/giac/doc
   %doc %{_datadir}/giac/examples

If a documentation exists (English is better), you can package it in a '-doc'
sub-package.
http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

7. %package devel
   Summary: Development files for libgiac
   Requires: %{name} = %{version}-%{release}

Use %{name}%{?_isa} = %{version}-%{release} because your package is
architecture dependent.

8. You can perform a 'make check' in a %check section. Read INSTALL file in the
source archive.

9. 'configure' considers an active --enable-lapack option by default. Lapack is
not among BR packages.

10. Package build fails in rawhide with

 cc1plus: some warnings being treated as errors

Please, check it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)
Summary|Review Request:  giac - |Review Request:  giac -
   |Computer Algebra System -   |Computer Algebra System
   |FE-NEEDSPONSOR  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #1 from Antonio Trande anto.tra...@gmail.com ---
Hi Han.

Just some initial comments.

1. Please, use %{?dist} tag in Release.
   http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag

2. Vendor is no necessary
3. You don't need to include gcc-c++ as BR 
   http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

4. List the BR (BuildRequires) packages in multi-lines
   Too long lines are no good.
5. %configure goes under %build section
6. Put %post/%postun sections before %files
   See
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview

7. You don't need to use rm, make, chmod, mkdir, cp, sed commands as macro.

8. Libtool archives (*.la files) must NOT be packaged
  
http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

9. Leave a comment when you perform extra commands (like 'chmod ...' or 'rm
...'), in order to clarify your work to the reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review