[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #53 from Fedora Update System --- jdns-2.0.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/jdns-2.0.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Fedora Update System changed: What|Removed |Added Fixed In Version|iris-1.0.0-0.17.20140424git |jdns-2.0.1-1.fc20 |4dcc9f49.fc20 | --- Comment #54 from Fedora Update System --- jdns-2.0.1-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #1 from Ivan Romanov --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6707163 rpmlint output: jdns.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns.x86_64: W: incoherent-version-in-changelog 2.0.0-1 ['2.0.0-1.fc20.R', '2.0.0-1.R'] jdns.x86_64: W: obsolete-not-provided qjdns jdns.x86_64: W: obsolete-not-provided qjdns-devel jdns.x86_64: W: no-manual-page-for-binary jdns qjdns.x86_64: W: spelling-error Summary(en_US) jdns -> jeans qjdns.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast qjdns.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse qjdns.x86_64: W: no-documentation jdns-bin.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns-bin.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns-bin.x86_64: W: no-documentation jdns-bin.x86_64: W: no-manual-page-for-binary jdns jdns-devel.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns-devel.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns-devel.x86_64: W: no-documentation jdns.src: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns.src: W: spelling-error %description -l en_US mdnsd -> mdse 6 packages and 0 specfiles checked; 0 errors, 19 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397
Rex Dieter changed:
What|Removed |Added
CC||rdie...@math.unl.edu
--- Comment #2 from Rex Dieter ---
Thanks.
This part will have to be removed or fixed properly,
# Avoid qt4 dependencies in jdns package
%global __requires_exclude_from ^%{_libdir}/libqjdns.so.*$
%global __requires_exclude_from ^%{_bindir}/jdns$
not hacked around.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Rex Dieter changed: What|Removed |Added Blocks||709328 (psi-plus) Alias||jdns Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=709328 [Bug 709328] Review Request: psi-plus - Jabber client based on Qt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #3 from Ivan Romanov --- How it should be fixed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #4 from Rex Dieter --- I don't know (yet), haven't looked at the package and code. All I *do* know, is hacking around it like this is definitely wrong. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #5 from Rex Dieter --- So, for a practical short-term suggestion, I'd recommend simply removing the hack (for review-purposes), and consider the extra dependencies a bug that can and should be fixed (but non-blocking as far as package review is concerned) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Blocks|709328 (psi-plus) | --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) --- Please remove "rm -rf $RPM_BUILD_ROOT" in %install. Does qt5 supported as well? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=709328 [Bug 709328] Review Request: psi-plus - Jabber client based on Qt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #7 from Ivan Romanov --- (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #6) > Does qt5 supported as well? You can built jdns library against Qt5 and it will be worked. But package built against Qt4. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #8 from Ivan Romanov --- fixed Spec URL: https://raw.githubusercontent.com/drizt/jdns-package/a0f4af50151c6c2289e9dabe0032fe98fdff9aa3/jdns.spec SRPM URL: https://raw.githubusercontent.com/drizt/jdns-package/a0f4af50151c6c2289e9dabe0032fe98fdff9aa3/jdns-2.0.0-2.fc20.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Rex Dieter changed: What|Removed |Added Blocks||709328 (psi-plus) --- Comment #9 from Rex Dieter --- (re-adding blocking psi-plus, please be mindful not to remove that) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=709328 [Bug 709328] Review Request: psi-plus - Jabber client based on Qt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #10 from Ivan Romanov --- Rex, do you take this review request or I should to find somebody else? Also may I include this package to Fedora 20 and Fedora 21 or only to Rawhide? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) --- You may import new package in stable branches too. If you are willing I could take that review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #12 from Ivan Romanov --- Pavel, it will be very good if you take that review. Anyway need some comments from Rex. Now Fedora has qjdns as subpackage of iris. Need to be careful with this and don't break anything. Also need to apply patch for iris to use new jdns. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #13 from Rex Dieter --- I'd say safest plan would be to request F-20 branch (and up), but only build/test for rawhide initially. Once things are working ok, then can consider building updates for f20 too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397
Pavel Alexeev (aka Pahan-Hubbitus) changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|pa...@hubbitus.info
Flags||fedora-review?
--- Comment #14 from Pavel Alexeev (aka Pahan-Hubbitus)
---
>You can built jdns library against Qt5 and it will be worked. But package
>built against Qt4.
May it then be used to be linked with Qt5 application? If no, may be have worth
provide two versions out of the box?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- "Package does not own files or directories owned by other packages", "Package
does not contain duplicates in %files".
%{_bindir}/jdns used in main package and -bin subpackage
[!]: Package does not generate any conflict.
See comments before about twice binarie included.
- Please include README.md in %doc
- Honestly I do not see worth to split that small package on so much
subpackages. I suggest include binary in main package and drop -bin subpackage
completely.
Also even main package requires libQtCore.so.4() (splitting to minimize
dependency may be some justification), so qjdns also seems redundant.
- Requires: qt4%{?_isa} seems redundant as it pulled automatically.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)".
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[!]: Package does not own files or directories owned by other packages.
%{_bindir}/jdns used in main package and -bin
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
See comments before about twice binarie included.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6718749
http://koji.fedoraproject.org/koji/taskinfo?taskID=6718812
[!]: Package installs properly.
Packages can't be installed separate:
$ LANG=C sudo rpm -Uhv jdns-2.0.0-2.fc20.x86_64.rpm
jdns-bin-2.0.0-2.fc20.x86_64.rpm
error: Failed dependencies:
libqjdns.so.2()(64bit) is needed by jdns-2.0.0-2.fc20.x86_64
libqjdns.so.2()(64bit) is needed by jdns-bin-2.0.0-2.fc20.x86_64
qjdns(x86-64) = 2.0.0-2.fc20 is needed by jdns-bin-2.0.0-2.fc20.x86_64
[x]: Rpmlint is run on all rpms the build produces.
Rpmlint
---
Checking: jdns-2.0.0-2.fc20.x86_64.rpm
qjdns-2.0.0-2.fc20.x86_64.rpm
jdns-bin-2.0.0-2.fc20.x86_64.rpm
jdns-devel-2.0.0-2.fc20.x86_64.rpm
jdns-2.0.0-2.fc20.src.rpm
jdns.x86_64: W: spelling-error %description -l en_US Multicast -> Multics,
Simulcast
jdns.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse
jdn
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #15 from Rex Dieter --- Re: Qt5 In my opinion, Qt5 support is only practical, if it's possible to install fully parallel-installable Qt4 and Qt5 versions without conflicts. What that means, is that the Qt5 version would need different library/soname, headers, etc... I suspect upstream does not support that (yet). So probably not something to consider now, but look forward to at some point in the future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397
--- Comment #16 from Ivan Romanov ---
* Wed Apr 9 2014 Ivan Romanov - 2.0.0-3
- removed jdns binary from jdns package
- dropped reduntant dependencies
- use only %%{buildroot}
- merged jdns-bin with qjdns subpackage
Spec URL:
https://raw.githubusercontent.com/drizt/jdns-package/24ff9e1091f664b452f22d6ac1684c269ca4c90d/jdns.spec
SRPM URL:
https://raw.githubusercontent.com/drizt/jdns-package/24ff9e1091f664b452f22d6ac1684c269ca4c90d/jdns-2.0.0-3.fc20.R.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #17 from Ivan Romanov --- (In reply to Rex Dieter from comment #15) > Re: Qt5 > > In my opinion, Qt5 support is only practical, if it's possible to install > fully parallel-installable Qt4 and Qt5 versions without conflicts. > > What that means, is that the Qt5 version would need different > library/soname, headers, etc... I suspect upstream does not support that > (yet). So probably not something to consider now, but look forward to at > some point in the future. So is there a guide or some manual how to all stuff should be named? I can add appropriate changes to upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #18 from Pavel Alexeev (aka Pahan-Hubbitus) --- (In reply to Rex Dieter from comment #15) > Re: Qt5 > > In my opinion, Qt5 support is only practical, if it's possible to install > fully parallel-installable Qt4 and Qt5 versions without conflicts. > > What that means, is that the Qt5 version would need different > library/soname, headers, etc... I suspect upstream does not support that > (yet). So probably not something to consider now, but look forward to at > some point in the future. Is it not the case what we have in current Fedora 20? I have installed on my system concurently: qt3-3.3.8b-56.fc20.x86_64 qt-4.8.5-15.fc20.i686 qt-4.8.5-15.fc20.x86_64 qt5-qtbase-5.2.1-6.fc20.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #19 from Rex Dieter --- Re: comment #18 Yes, notice all those packages do satisfy the constraints I mentioned. Re: comment #17 First off, the library names have to be different with Qt5, some projects inject the string "qt5" or "Qt5" in there somewhere (likewise for any pkgconfig-related files). Headers are easier, since qt4/qt5 have separate header paths, installing stuff into their header prefix (instead of hard-coding /usr/include) takes care of that part. But, this is something that can be resolved post-review (doing so here only needlessly complicates things) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #20 from Pavel Alexeev (aka Pahan-Hubbitus) --- You add in main package: Obsoletes: qjdns < 2.0.0 Obsoletes: qjdns-devel < 2.0.0 If it should be present at least in qjdns subpackage. Then you must also add provides (rpmlint complain that). But if I understand correctly it is not needed - package have same name and you provide greater version, so normal update should happen. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #21 from Pavel Alexeev (aka Pahan-Hubbitus) --- >But, this is something that can be resolved post-review (doing so here only >needlessly complicates things) May be. But if that planned to do and package names will be changed then rename request should be filled later, is not? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #22 from Ivan Romanov --- (In reply to Rex Dieter from comment #19) > First off, the library names have to be different with Qt5, some projects > inject the string "qt5" or "Qt5" in there somewhere (likewise for any > pkgconfig-related files). Headers are easier, since qt4/qt5 have separate > header paths, installing stuff into their header prefix (instead of > hard-coding /usr/include) takes care of that part. But, this is something > that can be resolved post-review (doing so here only needlessly complicates > things) I won't to do it here. I added qt5 support in my TODO. I find the best way to provide qt5 subpackage. Maybe such way will be good https://github.com/rojkov/embedlite-components/commit/2620650eb06e327281afd148b6cbf836ffe43d58 ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #23 from Ivan Romanov --- (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #20) > You add in main package: > Obsoletes: qjdns < 2.0.0 > Obsoletes: qjdns-devel < 2.0.0 > > If it should be present at least in qjdns subpackage. Then you must also add > provides (rpmlint complain that). > But if I understand correctly it is not needed - package have same name and > you provide greater version, so normal update should happen. I tried to drop Obsoletes tags. So when I did 'yum localinstall jdns-2.0.0-3.fc20.R.x86_64.rpm' it installed without any errors. And I have jdns-2.0.0, qjdns-1.0.0 and qjdns-devel-1.0.0. It is wrong. Installing jdns must update old qjdns from iris package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #24 from Ivan Romanov --- * Wed Apr 9 2014 Ivan Romanov - 2.0.0-4 - obsoletes/conflicts/provides fixes Spec URL: https://raw.githubusercontent.com/drizt/jdns-package/8a66a488b1cee2c0bbd798d4b518d8b2e7ea75e6/jdns.spec SRPM URL: https://raw.githubusercontent.com/drizt/jdns-package/8a66a488b1cee2c0bbd798d4b518d8b2e7ea75e6/jdns-2.0.0-4.fc20.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #25 from Rex Dieter --- I'd encourage you to consider not dropping the qjdns-devel subpkg (else risk complaints of qt-devel getting pulled in for any consumer of jdns-devel). Bonus is that you won't have to deal with any Conflicts or Obsoletes/Provides tags then. As is, these should not be needed in the main pkg anyway: Conflicts: qjdns < 2.0.0 Conflicts: qjdns-devel < 2.0.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #26 from Ivan Romanov --- Do you suggest just to remove any conflicts/obsoletes/provides tags? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #27 from Rex Dieter --- The implication of comment #25 was to restore qjdns-devel subpkg, and drop all those, yes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #28 from Ivan Romanov --- My package had no qjdns-devel. What is mean restore? or You mean to rename jdns-devel to qjdns-devel? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #29 from Pavel Alexeev (aka Pahan-Hubbitus) --- (In reply to Ivan Romanov from comment #23) > (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #20) > I tried to drop Obsoletes tags. So when I did 'yum localinstall > jdns-2.0.0-3.fc20.R.x86_64.rpm' it installed without any errors. And I have > jdns-2.0.0, qjdns-1.0.0 and qjdns-devel-1.0.0. It is wrong. Installing jdns > must update old qjdns from iris package. Your jdns does not provides qjdns, why it obsoletes that? What if you install your qjdns-2.0.0 - it should just update qjdns-1.0.0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #30 from Rex Dieter --- iris pkg currently provides jdns jdns-devel qjdns qjdns-devel So, I think this package should follow that same convention. Doing so will avoid the need for any Conflicts/Obsoletes/Provides -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #31 from Ivan Romanov --- # yum install jdns Loaded plugins: langpacks, refresh-packagekit No package jdns available. Error: Nothing to do -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #32 from Rex Dieter --- Oh, you're right, http://pkgs.fedoraproject.org/cgit/iris.git/tree/iris.spec turns out there are only qjdns and qjdns-devel subpkgs to worry about here. So as long as both of those exist here, all will be well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #33 from Ivan Romanov --- Is there the correct way to update your qjdns and qjdns-devel to my qjdns and jdns-devel? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #34 from Pavel Alexeev (aka Pahan-Hubbitus) --- We with Rex mention early what if you provide in your package qjdns and qjdns-devel vith versions which are greater than current from iris all update should be smooth and no other manipulation will be needed (like Obsoletes/Provides). Then it may be just dropped in iris. Please try do it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397
--- Comment #35 from Ivan Romanov ---
Anyway will be need to manipalation with jdns package. I think it's not correct
to have in system jdns-2.0.0 and qjdns-1.0.0.
Now my jdns-devel subpackage uses
Provides: qjdns-devel = %{version}-%{release}
Obsoletes: qjdns-devel < 2.0.0
It's a standart way to rename package
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Renaming.2FReplacing_Existing_Packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #36 from Pavel Alexeev (aka Pahan-Hubbitus) --- (In reply to Ivan Romanov from comment #35) > Anyway will be need to manipalation with jdns package. I think it's not > correct to have in system jdns-2.0.0 and qjdns-1.0.0. Why? If user want new jdns package - they just install it. If they want update qjdns newer version - update it (or whole system). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #37 from Pavel Alexeev (aka Pahan-Hubbitus) --- On my mind it is incorrect obsoletes some functionality by other package which is not provided by him (and have just fake). What happened with software which use library from qjdns-1.0.0? In case user install just jdns-2.0.0 (without qjdns-2.0.0) it became broken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #38 from Ivan Romanov --- Always when I am updating one package will be updated all others. For example if I want to update only qt package will be updated qt-devel also. No other options. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #39 from Pavel Alexeev (aka Pahan-Hubbitus) --- Right, because qt-devel have versioned dependency to qt. It is not your case, so jdns is not dependent from qjdns, so in install second will not be pulled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #40 from Pavel Alexeev (aka Pahan-Hubbitus) --- What concerned of qt4/qt5 versions it discussed not so early: https://lists.fedoraproject.org/pipermail/devel/2014-March/196385.html I think we could follow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #41 from Rex Dieter --- That suggested way of doing it won't work (keeping the same soname) Please keep discussions of Qt5 support out of the package review, it is not relevant. If you want, please work upstream to make that happen. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #42 from Rex Dieter --- I changed my mind, keeping a single -devel pkg isnt so bad, though like I said, there may be complaints. So, all that is really needed is dropping the Conflicts which are not needed (the Obsoletes/Provides takes care of that part) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #43 from Ivan Romanov --- I changed my mind too. It will good to have jdns-devel and qjdns-bevel because this subpackages have very different dependencies (no for jdns-devel and qt-devel for qjdns-devel. So now I think it should be splitted. Rex, Is it ok to have installed jdns-2.0.0 and qjdns-1.0.0 in the same time? Just tehnically it won't any problems, iris and jreen will work as before. But jdns-2.0.0 allready has a part of the functions which bundled in qjdns-1.0.0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #44 from Ivan Romanov --- Also I looked to packages in Fedora. There are packages which provides -devel, -qt-devel and -gtk-devel. So I think it is a good practica to split -devel subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #45 from Ivan Romanov --- * Fri Apr 11 2014 Ivan Romanov - 2.0.0-5 - separated qjdns-devel subpackage - dropped and Confilcts/Obsoletes/Provides tags Spec URL: https://raw.githubusercontent.com/drizt/jdns-package/e35623934fcf3dde8394d27c73723245dc50cdbc/jdns.spec SRPM URL: https://raw.githubusercontent.com/drizt/jdns-package/e35623934fcf3dde8394d27c73723245dc50cdbc/jdns-2.0.0-5.fc20.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397
Pavel Alexeev (aka Pahan-Hubbitus) changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #46 from Pavel Alexeev (aka Pahan-Hubbitus)
---
Please do not copy big text multiple times in spec. Firstly it is not needed at
all: Common practice use description for -devel like: "The %{name}-devel
package contains libraries and header files for developing applications that
use %{name}.". In case where you really want use parent package description you
may replace it by macros %{description}. Introduce other %global parts of text
if copy needed. But again - I highly encourage you to do not use description
copying. All package should have short and descriptive information about itself
- information about requirements (and parents) always accessible in
corresponded packages.
Other seams addressed.
PACKAGE APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Ivan Romanov changed: What|Removed |Added Flags||fedora-cvs? --- Comment #47 from Ivan Romanov --- New Package SCM Request === Package Name: jdns Short Description: A simple DNS queries library Owners: ivanromanov Branches: f20 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #48 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Rex Dieter changed: What|Removed |Added Blocks||1089045 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089045 [Bug 1089045] Cannot load the Jabber protocol plugin. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-04-24 12:08:02 --- Comment #49 from Rex Dieter --- built for rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #50 from Fedora Update System --- jdns-2.0.0-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/jdns-2.0.0-6.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #51 from Fedora Update System --- iris-1.0.0-0.17.20140424git4dcc9f49.fc20,jreen-1.2.0-2.fc20,jdns-2.0.0-7.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/iris-1.0.0-0.17.20140424git4dcc9f49.fc20,jreen-1.2.0-2.fc20,jdns-2.0.0-7.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Fedora Update System changed: What|Removed |Added Fixed In Version||iris-1.0.0-0.17.20140424git ||4dcc9f49.fc20 Resolution|RAWHIDE |ERRATA --- Comment #52 from Fedora Update System --- iris-1.0.0-0.17.20140424git4dcc9f49.fc20, jreen-1.2.0-2.fc20, jdns-2.0.0-7.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
