[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 maria...@tuxette.fr changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2015-09-24 11:28:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Till Maas changed: What|Removed |Added CC||opensou...@till.name --- Comment #13 from Till Maas --- (In reply to Pierre-YvesChibon from comment #12) > This is weird, Jehane did not get commit on any of the Fedora branches. > I will fix things directly in pkgdb, but there is something odd going on > here. It might be that a Package Change Request (or similar) is needed instead of a New Package SCM Request. Or it needs to be spotted manually by the process-git-process operator. Nevertheless, it will all get better with the new process. :-). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Pierre-YvesChibon changed: What|Removed |Added CC||pin...@pingoured.fr --- Comment #12 from Pierre-YvesChibon --- This is weird, Jehane did not get commit on any of the Fedora branches. She got listed as PoC for master and el6 (that she had before). She got 'Awaiting Review' approveacls on master (she had el6 before). She got all the watch* ACLs on all branches but no commit ACL on any branch. The action from the script can be found there: https://admin.fedoraproject.org/pkgdb/package/fusioninventory-agent/timeline#n21 I will fix things directly in pkgdb, but there is something odd going on here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 maria...@tuxette.fr changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from maria...@tuxette.fr --- New Package SCM Request === Package Name: fusioninventory-agent Short Description: FusionInventory agent Upstream URL: http://fusioninventory.org/ Owners: jehane Branches: devel f20 f21 epel7 InitialCC: perl-sig Package was orphaned and retired, still present in el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933
Haïkel Guémar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #9 from Haïkel Guémar ---
Few things:
* clean up tabs in the cron script (the expand command should be enough) before
importing the src.rpm
* consider enabling unit tests during build time
I am confident that you will do that in a timely fashion, not blocking the
review for that.
I hereby approve this package into Fedora Packages Collection since it complies
with our guidelines. Please submit a SCM request.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later)", "Unknown or generated". 259 files have unknown
license. Detailed output of licensecheck in /home/haikel/1090933
-fusioninventory-agent/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/cron.hourly
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 133120 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in perl-
FusionInventory-Agent , fusioninventory-agent-task-esx , fusioninvent
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 --- Comment #8 from maria...@tuxette.fr --- I have updated spec according to your review : SPEC URL : http://giverny.tuxette.fr/~jehane/copr/fusioninventory/fusioninventory-agent.spec SRPM URL : http://giverny.tuxette.fr/copr/fusioninventory/fusioninventory-agent-2.3.14-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? --- Comment #7 from Haïkel Guémar --- Two things before approving this package: 1. Fix the following unowned directories /usr/share/fusioninventory /usr/share/fusioninventory/lib /usr/share/fusioninventory/lib/FusionInventory /usr/share/fusioninventory/lib/FusionInventory/Agent /usr/share/fusioninventory/lib/FusionInventory/Agent/Task http://fedoraproject.org/wiki/Packaging:UnownedDirectories 2. Add a comment explaining why the wakeonlan plugin is not shipping due to a dependency with problematic licensing (Artistic Perl v1) That is not mandatory, but this will avoid that a comaintainer or provenpackager adds it back by mistake. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Haïkel Guémar changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #6 from Haïkel Guémar --- Marianne has been sponsored since, dropping the FE-NEEDSPONSOR. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 maria...@tuxette.fr changed: What|Removed |Added Version|20 |rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 --- Comment #5 from maria...@tuxette.fr --- Uptated to latest version : SPEC URL : http://giverny.tuxette.fr/copr/fusioninventory/fusioninventory-agent.spec SRPM URL : http://giverny.tuxette.fr/~jehane/copr/fusioninventory/fusioninventory-agent-2.3.13-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 --- Comment #4 from maria...@tuxette.fr --- I have updated the spec according to previous (not sure to have correct everything but I will continue working on it) I also add requires I had missed. One of them is not available actually in fedora, so I have created a spec file and open a new review request ( https://bugzilla.redhat.com/show_bug.cgi?id=1100870 ) Spec is http://giverny.tuxette.fr/copr/fusioninventory/fusioninventory-agent.spec src.rpm is http://giverny.tuxette.fr/copr/fusioninventory/fusioninventory-agent-2.3.8-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933
--- Comment #3 from Michael Schwendt ---
Compared with the last official build in koji,
http://koji.fedoraproject.org/koji/packageinfo?packageID=12285
you've introduced several packaging mistakes related to "unowned directories"
and duplicated files:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
The subpackage inter-dependencies are not trivial, so let's see:
%files -n perl-FusionInventory-Agent
%doc Changes LICENSE THANKS
%{_datadir}/fusioninventory
The last line in this %files list includes the directory
/usr/share/fusioninventory *and* everything in it. That means it includes also
the files and subdirs specified in the subpackages -task-esx, -task-network,
-task-deploy and -task-inventory. Example:
%files task-esx
%{_bindir}/fusioninventory-esx
%{_mandir}/man1/fusioninventory-esx.1*
%{_datadir}/fusioninventory/lib/FusionInventory/Agent/Task/ESX.pm
%{_datadir}/fusioninventory/lib/FusionInventory/Agent/SOAP
One way to avoid that is to either %exclude all those files (included in the
subpackages already) in the perl-FusionInventory-Agent package. Or be more
specific about what to include in the perl-FusionInventory-Agent package based
on including only the %dir
%files -n perl-FusionInventory-Agent
%doc Changes LICENSE THANKS
%dir %{_datadir}/fusioninventory
...add specific files and needed %dir entries here...
Note that there are a various subdirs in paths such as
%{_datadir}/fusioninventory/lib/FusionInventory/Agent/Task/, which must not be
"unowned".
A related hint: To increase readability of directory entries in %files lists,
many packagers append a trailing slash to emphasize that the entry is for a
directory tree and not a single file:
%{_datadir}/somedirectory/
[...]
Your %changelog refers to 2.3.6-1 but the spec file is 2.3.6-0:
Version: 2.3.6
Release: 0%{?dist}
Consider pointing the fedora-review tool at this ticket (run "fedora-review -b
1090933") to let it perform many tests not limited to running rpmlint on all
packages.
> find %{buildroot} -type d -depth -exec rmdir {} 2>/dev/null ';'
Not needed anymore for many years.
> %files
> /%{_bindir}/fusioninventory-injector
Why the leading slash?
$ rpm -E %_bindir
/usr/bin
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 --- Comment #2 from maria...@tuxette.fr --- New release : updated spec and srpm http://giverny.tuxette.fr/copr/fusioninventory/fusioninventory-agent-2.3.8-0.fc20.src.rpm http://giverny.tuxette.fr/copr/fusioninventory/fusioninventory-agent.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1090933] Review Request : fusioninventory-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1090933 Haïkel Guémar changed: What|Removed |Added CC||package-review@lists.fedora ||project.org Component|fusioninventory-agent |Package Review Assignee|extras-orphan@fedoraproject |nob...@fedoraproject.org |.org| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
