[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jortho-1.0-2.fc20 Resolution|--- |ERRATA Last Closed||2014-05-14 19:59:27 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- jortho-1.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|jortho-1.0-2.fc20 |jortho-1.0-2.fc19 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- jortho-1.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- jortho-1.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/jortho-1.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- jortho-1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/jortho-1.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Michael Simacek msima...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Michael Simacek msima...@redhat.com --- Thanks! New Package SCM Request === Package Name: jortho Short Description: A spell checker for Java Owners: msimacek mizdebsk msrb Branches: f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- jortho-1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/jortho-1.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- jortho-1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/jortho-1.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- jortho-1.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 --- Comment #6 from Michael Simacek msima...@redhat.com --- Done. Thanks for suggestions. Spec URL: http://msimacek.fedorapeople.org/jortho.spec SRPM URL: http://msimacek.fedorapeople.org/jortho-1.0-1.fc20.src.rpm Koji scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6800060 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 gil cattaneo punto...@libero.it changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #7 from gil cattaneo punto...@libero.it --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: JOrtho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Michael Simacek msima...@redhat.com changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Michael Simacek msima...@redhat.com changed: What|Removed |Added Summary|Review Request: JOrtho - A |Review Request: jortho - A |spell checker for Java |spell checker for Java --- Comment #2 from Michael Simacek msima...@redhat.com --- Spec URL: http://msimacek.fedorapeople.org/jortho.spec SRPM URL: http://msimacek.fedorapeople.org/jortho-1.0-0.fc20.src.rpm I renamed the package to lowercase to be consistent with other Java packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 gil cattaneo punto...@libero.it changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096
--- Comment #3 from gil cattaneo punto...@libero.it ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- This seems like a Java package, please install fedora-review-plugin-java to
get additional checks
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address). Detailed output of
licensecheck in /home/gil/1092096-jortho/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jortho-
javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096
--- Comment #4 from gil cattaneo punto...@libero.it ---
Please, fix:
jortho.noarch: W: incoherent-version-in-changelog 1.0-1 ['1.0-0.fc21', '1.0-0']
jortho.noarch: E: non-standard-dir-perm /usr/share/jortho 0775L
use:
mkdir -p %{buildroot}%{_datadir}/%{name}
install -pm 644 dicts/dictionary_en.ortho %{buildroot}%{_datadir}/%{name}/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 --- Comment #5 from gil cattaneo punto...@libero.it --- more of resources are copied in wrong place see http://maven.apache.org/plugins/maven-resources-plugin/examples/include-exclude.html can you try to change your template pom with resource directorysrc/directory includes include**/*.cnf/include include**/*.properties/include include**/*.png/include /includes excludes exclude**/*.java/exclude exclude**/*.html/exclude /excludes /resource -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: JOrtho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 hannes johannes.l...@googlemail.com changed: What|Removed |Added CC||johannes.l...@googlemail.co ||m --- Comment #1 from hannes johannes.l...@googlemail.com --- *** Bug 923959 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
